Bug 280129 - deskutils/syncthingtray: update to 1.5.5
Summary: deskutils/syncthingtray: update to 1.5.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://github.com/Martchus/syncthing...
Keywords: needs-qa
Depends on:
Reported: 2024-07-04 16:01 UTC by Denis Shaposhnikov
Modified: 2024-07-10 15:31 UTC (History)
1 user (show)

See Also:

syncthingtray-1.5.5.patch (4.37 KB, patch)
2024-07-04 16:01 UTC, Denis Shaposhnikov
dsh: maintainer-approval+
Details | Diff
syncthingtray-1.5.5.patch (4.43 KB, patch)
2024-07-09 15:06 UTC, Denis Shaposhnikov
dsh: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Shaposhnikov 2024-07-04 16:01:04 UTC
Created attachment 251867 [details]


this patch updates deskutils/syncthingtray to the latest release.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2024-07-07 17:23:31 UTC
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
Attachment -> Details -> maintainer-approval [+]

^Triage: Maintainer-feedback flag (+) not required unless requested (?) first.
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2024-07-09 07:11:17 UTC
This does not build for me, would you have a look?

CMake Warning at /wrkdirs/usr/ports/deskutils/syncthingtray/work-qt5/c++utilities/cmake/modules/Doxygen.cmake:32 (message):
  Doxygen not found, unable to add target for generating API documentation
  for syncthingmodel
Call Stack (most recent call first):
  /wrkdirs/usr/ports/deskutils/syncthingtray/work-qt5/syncthingtray/syncthingmodel/CMakeLists.txt:76 (include)

-- Using template for config.h.in from CPP_UTILITIES source directory.
-- Linking syncthingmodel against Qt module Qt5::Test.
CMake Error at /wrkdirs/usr/ports/deskutils/syncthingtray/work-qt5/syncthingtray/syncthingwidgets/CMakeLists.txt:95 (find_package):
  Could not find a configuration file for package "c++utilities" that is
  compatible with requested version "5.25.0".

  The following configuration files were considered but not accepted:

    /wrkdirs/usr/ports/deskutils/syncthingtray/work-qt5/c++utilities/c++utilitiesConfig.cmake, version: 5.24.9

-- Configuring incomplete, errors occurred!
*** Error code 1
Comment 3 Denis Shaposhnikov 2024-07-09 14:08:27 UTC
(In reply to Fernando Apesteguía from comment #2)

could give me its build log? I can't reproduce it in my poudriere.
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2024-07-09 14:50:49 UTC
(In reply to Denis Shaposhnikov from comment #3)
Ummm... The patch does not apply cleanly. I might have messed up trying to fix it manually.

Can you regenerate it and attach it here?
Comment 5 Denis Shaposhnikov 2024-07-09 15:06:39 UTC
Created attachment 251951 [details]
Comment 6 Denis Shaposhnikov 2024-07-09 15:08:24 UTC
(In reply to Fernando Apesteguía from comment #4)
Thanks. I recreated the patch using

git -c diff.suppressBlankEmpty=true diff --no-prefix freebsd..HEAD -- deskutils/syncthingtray

I suppose diff.suppressBlankEmpty=true will help.
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2024-07-10 15:30:45 UTC

Comment 8 commit-hook freebsd_committer freebsd_triage 2024-07-10 15:31:02 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a503b6b0edaa97df21a02aba23602883ba4f6e08

commit a503b6b0edaa97df21a02aba23602883ba4f6e08
Author:     Denis Shaposhnikov <dsh@bamus.cz>
AuthorDate: 2024-07-09 16:03:01 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2024-07-10 15:30:23 +0000

    deskutils/syncthingtray: update to 1.5.5

    ChangeLog: https://github.com/Martchus/syncthingtray/releases/tag/v1.5.5

    PR:             280129
    Reported by:    dsh@bamus.cz (maintainer)

 deskutils/syncthingtray/Makefile | 30 ++++++++++++++++--------------
 deskutils/syncthingtray/distinfo | 14 +++++++-------
 2 files changed, 23 insertions(+), 21 deletions(-)