Created attachment 252040 [details] net/quiche: update to 0.22.0 Bump quiche 0.22.0. - install .so with a version and make symlink. Now libquiche.so has soname, so need to set it up correctly. - replace do-build with a default one - add a default test target
Created attachment 252041 [details] net/quiche: update to 0.22.0
(In reply to Junho Choi from comment #1) I'd prefer DISTVERSION without macros and derive from it the MAJOR_VER if needed: DISTVERSION=0.22.0 MAJOR_VER=${DISTVERSION:C|\..*||} See "man make" (Variable modifiers). In your case it's hard to find the DISTVERSION. And could you please check "portfmt -D Makefile" (part of ports-mgmt/portfmt)?
Created attachment 252124 [details] Updated based on the review. Updated based on the review. - extract a MAJOR_VER from DISTVERSION - portfmt suggestions
(In reply to Junho Choi from comment #3) Now noticed: why do you need link the libraries?
(In reply to Zsolt Udvari from comment #4) Since 0.22.0 quiche set soname in the shared library generated (libquiche.so). (https://github.com/cloudflare/quiche/pull/1769). So it need to install a proper symlink (libquiche.so.0.22.0 -> libquiche.so.0 -> libquiche.so) to be recognized with ldconfig. Lacking soname and its link makes shlib dependency check (pkg check -d) failed. (https://mail-archive.freebsd.org/cgi/getmsg.cgi?fetch=122421+0+archive/2024/freebsd-ports/20240715.freebsd-ports)
(In reply to Junho Choi from comment #5) The dns/dnsdist doesn't build with newest quiche. Maybe should upgrade dnsdist too? doq.cc:270:16: error: no matching function for call to 'quiche_conn_stream_send' 270 | auto res = quiche_conn_stream_send(conn.d_conn.get(), streamID, &response.at(pos), response.size() - pos, true); | ^~~~~~~~~~~~~~~~~~~~~~~
(In reply to Zsolt Udvari from comment #6) Looks like so - https://github.com/cloudflare/quiche/releases/tag/0.22.0 describes the function signature change. I only checked the linking issue, not the build of dnsdist itself... And yes, dnsdist need to be patched to build with quiche 0.22.0.
Looks like it's already there: https://github.com/PowerDNS/pdns/commit/e15b9be22b119ca3ab2d717c34d282f4e02b8cbe
This patch is included in dnsdist 1.9.6: https://dnsdist.org/changelog.html#change-b1adc724e8d0c2c3f7de19ecb32e252a Ports has 1.9.5 https://www.freshports.org/dns/dnsdist/
(In reply to Junho Choi from comment #9) Thanks for exact information. Would you like update dnsdist and send a PR or shall I do it?
(In reply to Zsolt Udvari from comment #10) Ok, looks simple, I filed a ticket for updating dnsdist to 1.9.6: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280360
(In reply to Junho Choi from comment #11) Thanks. Waiting for approval and I'll commit.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=09f836259d2a4dd035f61b27410b32cc74997422 commit 09f836259d2a4dd035f61b27410b32cc74997422 Author: Junho Choi <junho.choi@gmail.com> AuthorDate: 2024-07-22 07:28:48 +0000 Commit: Zsolt Udvari <uzsolt@FreeBSD.org> CommitDate: 2024-07-22 07:35:55 +0000 net/quiche: update to 0.22.0 Install .so with a version and make symlink. Now libquiche.so has soname, so need to set it up correctly. Replace do-build with a default one. Add a default test target. Pet portfmt. Changelogs: https://github.com/cloudflare/quiche/releases/tag/0.22.0 https://github.com/cloudflare/quiche/releases/tag/0.21.0 PR: 280274 Approved by: submitter is maintainer net/quiche/Makefile | 29 ++--- net/quiche/Makefile.crates | 143 +++++++++++----------- net/quiche/distinfo | 288 +++++++++++++++++++++------------------------ 3 files changed, 220 insertions(+), 240 deletions(-)
Committed, thanks!
(In reply to Zsolt Udvari from comment #14) Thanks Zsolt!