Created attachment 252167 [details] upgrade patch A lot of FreeBSD-related fixes were upstreamed to this release. IPv6 support has many improvements. Using Netmap now allows binding threads to specific CPUs, and a lot more Full changelog https://github.com/pavel-odintsov/fastnetmon/commits/master/?after=9e96ae77987b4e8012966a223ecef90b05959df5+0 The port was simplified and a few issues were fixed: script notify_about_attack.sh, network and whitelist files are no longer overwritten during upgrades. I ran the development branch for a long time, so it's runtime tested.
Created attachment 252169 [details] rearranged patch Rearranged patch, less diffs, no functional changes.
LGTM from a functional perspective. I think portlint will not be happy with some missing whitespaces in the Makefile. Would you please run portlint and fix potential issues?
Created attachment 252246 [details] portlinted patch Thank you for the clues. You were completely right, while working on patch simplification I broke it. Here's almost the same patch as the first one. It should now apply clearly with "git am".
(In reply to Babak Farrokhi from comment #3) >LGTM from a functional perspective. Does the maintainer approve the last patch?
Created attachment 252678 [details] patch rebased on commit 8c120afd978777a79b6566f1824080771cbc5b56 This PR is stalled, I am updating the patch rebased on the commit "Bump revisions of dependent ports after Abseil C++ libraries update"[1] Perhaps someone can commit it since the maintainer approved the patch but timed out with regard of committing the upgrade patch to the repository. I am struggling to update this port for another time. It looks like the maintainer lost interest a couple of years ago but still keeps the maintainership since he is the committer too. [1] https://cgit.freebsd.org/ports/commit/?id=8c120afd978777a79b6566f1824080771cbc5b56
Thank you for your patch. The latest patch (before this one) still does not pass the portlint tests. I have updated and rebased it, and it is now building in poudriere. Once I get to build on 13.3 and 14.1 (amd64 and i386), I will commit.
Maybe we are using diffent patches: [poudriere] /<5>net-mgmt/fastnetmon# portlint looks fine.
Created attachment 252679 [details] poudriere log The port builds fine, at least on 14.1 (please see the log attached).
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=90fc03b99996ebb9f040ac305794fe627a8856d3 commit 90fc03b99996ebb9f040ac305794fe627a8856d3 Author: Babak Farrokhi <farrokhi@FreeBSD.org> AuthorDate: 2024-08-11 11:06:19 +0000 Commit: Babak Farrokhi <farrokhi@FreeBSD.org> CommitDate: 2024-08-11 11:06:19 +0000 net-mgmt/fastnetmon: Update to 1.2.7 Release Notes: https://github.com/pavel-odintsov/fastnetmon/releases/tag/v1.2.7 PR: 280367 Reported by: Marek Zarychta <zarychtam@plan-b.pwste.edu.pl> Sponsored by: PANS Jarosław net-mgmt/fastnetmon/Makefile | 27 ++++++++----------- net-mgmt/fastnetmon/distinfo | 8 +++--- .../fastnetmon/files/patch-CMakeLists.txt (gone) | 30 ---------------------- .../files/patch-src_fastnetmon.cpp (gone) | 29 --------------------- .../files/patch-src_man_fastnetmon.8 (gone) | 11 -------- ...src_netmap__plugin_netmap__collector.cpp (gone) | 10 -------- net-mgmt/fastnetmon/pkg-plist | 1 + 7 files changed, 14 insertions(+), 102 deletions(-)
Heh... it looks like the committer hijacked the authorship of this simple patch, anyway thanks for pushing it.