Bug 280403 - [PATCH] games/foobillard: works only on x64 and x86
Summary: [PATCH] games/foobillard: works only on x64 and x86
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-22 09:19 UTC by thomas
Modified: 2024-07-22 19:33 UTC (History)
1 user (show)

See Also:
vvd: merge-quarterly+

Attachments
git patch, limit to x86 and x64 platform (2.31 KB, patch)
2024-07-22 09:19 UTC, thomas 		no flags Details | Diff
Git patch, broken on aarch64 - Improper-alignment (955 bytes, patch)
2024-07-22 18:10 UTC, thomas 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description thomas 2024-07-22 09:19:45 UTC 
Created attachment 252221 [details]
git patch, limit to x86 and x64 platform

Hello,

Add a patch to restrict it to i364 and x64 platform only. It does not work with arm.

I'm the maintainer of this port. Please commit it

Regards,
Tom
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-22 09:33:26 UTC 
Are you talking about armv6, armv7 and aarch64?
FreeBSD also runs on ppc (powerpc64, powerpc64le, powerpc) and riscv64 - are they supported?
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-22 09:34:44 UTC 
https://www.freebsd.org/platforms/
Comment 3 thomas 2024-07-22 09:44:51 UTC 
I've tested it with poudriere for x86 and x64.

Is port project testing it on all platforms like PPC? If so, then only arm64 does not work.

Not working for arm64:
Log URL:        https://pkg-status.freebsd.org/ampere1/data/140arm64-quarterly/60e5cde1cb38/logs/foobillard-3.0a_12.log
Build URL:      https://pkg-status.freebsd.org/ampere1/build.html?mastername=140arm64-quarterly&build=60e5cde1cb38
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-22 17:28:16 UTC 
(In reply to thomas from comment #3)
I would then use:
BROKEN_aarch64= improper alignment for relocation R_AARCH64_LDST64_ABS_LO12_NC: 0x29B694 is not aligned to 8 bytes
Comment 5 thomas 2024-07-22 18:10:42 UTC 
Created attachment 252229 [details]
Git patch, broken on aarch64 - Improper-alignment

Updated the patch with your idea
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-07-22 19:29:29 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e21b20273ae7e25fe6990443a63b0526cc8d1e00

commit e21b20273ae7e25fe6990443a63b0526cc8d1e00
Author:     Thomas Vogt <thomas@bsdunix.ch>
AuthorDate: 2024-07-22 19:24:16 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-07-22 19:24:16 +0000

    games/foobillard: set BROKEN_aarch64, sort out Makefile

    Can't build on aarch64 with error:
    improper alignment for relocation R_AARCH64_LDST64_ABS_LO12_NC: 0x29B694 is not aligned to 8 bytes

    Fix dependencies from GL and XORG, pet portclippy.

    PR:     280403
    MFH:    2024Q3

 games/foobillard/Makefile | 33 ++++++++++++++++++++-------------
 1 file changed, 20 insertions(+), 13 deletions(-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-07-22 19:31:31 UTC 
A commit in branch 2024Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=03a3189d81c370c2474ae1f63215988a3c8b4531

commit 03a3189d81c370c2474ae1f63215988a3c8b4531
Author:     Thomas Vogt <thomas@bsdunix.ch>
AuthorDate: 2024-07-22 19:24:16 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-07-22 19:31:12 +0000

    games/foobillard: set BROKEN_aarch64, sort out Makefile

    Can't build on aarch64 with error:
    improper alignment for relocation R_AARCH64_LDST64_ABS_LO12_NC: 0x29B694 is not aligned to 8 bytes

    Fix dependencies from GL and XORG, pet portclippy.

    PR:     280403
    MFH:    2024Q3
    (cherry picked from commit e21b20273ae7e25fe6990443a63b0526cc8d1e00)

 games/foobillard/Makefile | 33 ++++++++++++++++++++-------------
 1 file changed, 20 insertions(+), 13 deletions(-)
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2024-07-22 19:33:27 UTC 
Check my changes with dependencies from GL and XORG.
poudriere found.