Add a non-default option to build the new OSS driver backend coming in the next JACK release. The backend is a complete rewrite based on the sosso library, with improved stability and low latency capabilities. Let users preview and test the new backend before it becomes default. Patch is coming in a minute.
Created attachment 252499 [details] Add option for new OSS driver backend. This patch adds the option for the new OSS driver backend. Builds with default options are not affected, thus no PORTREVISION bump. While here, cleanup two checks in the RC service script, one of them deprecated, the other was ineffective by mistake. Apply patch with `git am`. I'd really like to get the rewritten OSS driver backend into the hands of some interested parties before it hits everybody in the next Jack release. This will both accomplish some beta testing and allow users to get the new low-latency features, if desired. Unfortunately there's no better way in ports to substitute a non-leaf dependency.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=183213847e99429b8b297db54029fd9e80741ced commit 183213847e99429b8b297db54029fd9e80741ced Author: Florian Walpen <dev@submerge.ch> AuthorDate: 2024-08-06 14:53:06 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-08-06 14:53:06 +0000 audio/jack: Option for new OSS driver backend Add a non-default option to build the new OSS driver backend coming in the next JACK release. The backend is a complete rewrite based on the sosso library, with improved stability and low latency capabilities. Let users preview and test the new backend before it becomes default. Builds with default options are not affected, thus no PORTREVISION bump. While here, cleanup two checks in the RC service script, one of them deprecated, the other was ineffective by mistake. PR: 280611 audio/jack/Makefile | 9 +++++++-- audio/jack/distinfo | 4 +++- audio/jack/files/jackd.in | 6 ++---- 3 files changed, 12 insertions(+), 7 deletions(-)
I looked at the pull request, other commits since 1.9.22 - your version can be replaced with a set of patches necessary to apply your patch using: SOSSO_PATCH_SITES= https://github.com/jackaudio/jack2/commit/ SOSSO_PATCHFILES= xxxx1.patch:-p1 \ xxxx2.patch:-p1 \ ... + your patches in the last lines. This will allow you to use make makesum for generate correct distinfo. You can see an example: https://cgit.freebsd.org/ports/tree/graphics/glfw/Makefile#n37 BTW, you have 2 TIMESTAMPs in distinfo. I have committed your patch, but if you want, you can rework it as described above.
(In reply to Vladimir Druzenko from comment #3) Hi Vladimir, thanks for your commit and the hints. Regarding the extra commits between 1.9.22 and the PR, there aren't many relevant to FreeBSD, but one of them is a requirement for the new driver backend, and another one may be needed to fix start / stop of the Jack server. Since this is also the revision I am running and testing locally, I'd prefer to keep it on the PR commit, and not convert to separate patches. About the timestamp, yes, I copied that over. At least it carries the info when the respective makesum checks were done. If it has some bad side effects we can change it, otherwise this ugliness will vanish when Jack 1.9.23 is released.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=e01ecc14204430b0799d5c4c9bcc77b5599672b4 commit e01ecc14204430b0799d5c4c9bcc77b5599672b4 Author: Vladimir Druzenko <vvd@FreeBSD.org> AuthorDate: 2024-08-06 17:44:07 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-08-06 17:44:07 +0000 audio/jack: remove SOSSO option accidentally added to DEFAULT PR: 280611 Approved by: Florian Walpen <dev@submerge.ch> (maintainer) Fixes: 183213847e99 (Option for new OSS driver backend) audio/jack/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)