Bug 280616 - x11-drivers/xorgxrdp fails to build with 'drm.h' file not found error
Summary: x11-drivers/xorgxrdp fails to build with 'drm.h' file not found error
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Koichiro Iwao
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-04 18:20 UTC by ddrinnon
Modified: 2024-09-02 00:35 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (meta)

Attachments
xorgxrdp-0.10.2.log (144.90 KB, text/plain)
2024-08-06 06:46 UTC, Koichiro Iwao 		no flags Details
Build log (108.39 KB, text/plain)
2024-08-06 13:24 UTC, ddrinnon 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ddrinnon 2024-08-04 18:20:03 UTC 
When building x11-drivers/xorgxrdp in Poudriere, the build fails with 'drm.h' file not found error:

...
Making all in xrdpdev
/bin/sh ../libtool  --tag=CC    --mode=compile cc -DHAVE_CONFIG_H  -I. -I..   -isystem /usr/local/include  -I/usr/local/include/xorg -fvisibility=hidden -I/usr/local/include/pixman-1  -I/wrkdirs/usr/ports/x11-drivers/xorgxrdp/work/xrdp-0.10.1/common  -DPACKAGE_VERSION_MAJOR=0  -DPACKAGE_VERSION_MINOR=10  -DPACKAGE_VERSION_PATCHLEVEL=2  -I../module   -O2 -pipe  -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -Wall -Wwrite-strings -MT xrdpdev.lo -MD -MP -MF .deps/xrdpdev.Tpo -c -o xrdpdev.lo xrdpdev.c
libtool: compile:  cc -DHAVE_CONFIG_H -I. -I.. -isystem /usr/local/include -I/usr/local/include/xorg -fvisibility=hidden -I/usr/local/include/pixman-1 -I/wrkdirs/usr/ports/x11-drivers/xorgxrdp/work/xrdp-0.10.1/common -DPACKAGE_VERSION_MAJOR=0 -DPACKAGE_VERSION_MINOR=10 -DPACKAGE_VERSION_PATCHLEVEL=2 -I../module -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -Wall -Wwrite-strings -MT xrdpdev.lo -MD -MP -MF .deps/xrdpdev.Tpo -c xrdpdev.c  -fPIC -DPIC -o .libs/xrdpdev.o
xrdpdev.c:49:10: fatal error: 'drm.h' file not found
   49 | #include <drm.h>
      |          ^~~~~~~
1 error generated.
*** Error code 1

...
Comment 1 Koichiro Iwao freebsd_committer freebsd_triage 2024-08-05 04:34:28 UTC 
Should be resolved at d20b5abe394e5f2a928b69818d07ee8c0149166f.
Comment 2 ddrinnon 2024-08-06 02:37:46 UTC 
It is still failing to build as of 08/05
Comment 3 ddrinnon 2024-08-06 02:40:28 UTC 
It is still failing to build as of 08/05
Comment 4 Koichiro Iwao freebsd_committer freebsd_triage 2024-08-06 03:49:22 UTC 
report with commit hash, not date.
Comment 5 Koichiro Iwao freebsd_committer freebsd_triage 2024-08-06 03:51:18 UTC 
Also attach the full poudriere log, not copy & paste in comment.
Comment 6 Koichiro Iwao freebsd_committer freebsd_triage 2024-08-06 06:46:13 UTC 
Created attachment 252538 [details]
xorgxrdp-0.10.2.log

It builds successfully for me at aa1abe685f. It seems to be your local issue.
Comment 7 mew14930xvi 2024-08-06 06:58:44 UTC 
It can be built by default, but will fail if the options are changed.

$ cat /usr/local/etc/poudriere.d/make.conf
x11-drivers_xorgxrdp_UNSET+=    DRI3
Comment 8 Koichiro Iwao freebsd_committer freebsd_triage 2024-08-06 08:49:54 UTC 
Thanks. Anyway, I'm still waiting for the original reporter's log.
Comment 9 ddrinnon 2024-08-06 12:49:27 UTC 
(In reply to mew14930xvi from comment #7)
Exactly, with DRI3 UNSET, it fails to build.  It will build with the defaults.
Comment 10 ddrinnon 2024-08-06 13:24:56 UTC 
Created attachment 252554 [details]
Build log

Build log attached as requested.
Comment 11 commit-hook freebsd_committer freebsd_triage 2024-08-07 02:24:54 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e714b6a4c526c57f37adf76efa629d065b4e3290

commit e714b6a4c526c57f37adf76efa629d065b4e3290
Author:     Koichiro Iwao <meta@FreeBSD.org>
AuthorDate: 2024-08-07 02:17:26 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2024-08-07 02:23:40 +0000

    x11-drivers/xorgxrdp: Fix build when DRI3=off

    by applying  patch from upstream. While here, adjust BUILD_DEPENDS for
    DRI3.

    PR:             280616
    Obtained from:  https://github.com/neutrinolabs/xorgxrdp/pull/330

 x11-drivers/xorgxrdp/Makefile | 4 +++-
 x11-drivers/xorgxrdp/distinfo | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)
Comment 12 Koichiro Iwao freebsd_committer freebsd_triage 2024-08-07 02:30:37 UTC 
This is an upstream issue and has been resolved in upstream.
I have backported the patch from upstream. Could you test again?
Comment 13 ddrinnon 2024-08-07 03:29:24 UTC 
(In reply to Koichiro Iwao from comment #12)
I have changed my x11-drivers_xorgxrdp/options to:

# Options for xorgxrdp-0.10.2
_OPTIONS_READ=xorgxrdp-0.10.2
_FILE_COMPLETE_OPTIONS_LIST=DEBUG DRI3
OPTIONS_FILE_UNSET+=DEBUG
OPTIONS_FILE_UNSET+=DRI3


The next build is scheduled for 08:54 EDT.  I will let you know how it goes!
Comment 14 ddrinnon 2024-08-07 13:50:50 UTC 
x11-drivers/xorgxrdp built successfully