Hello, Doing some run tests for devel/libgit2 1.8.1 update: FAILED: libgit2-glib/libgit2-glib-1.0.so.0.200.0.p/ggit-clone-options.c.o cc -Ilibgit2-glib/libgit2-glib-1.0.so.0.200.0.p -Ilibgit2-glib -I../libgit2-glib -I. -I.. -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -fdiagnostics-color=never -D_FILE_OFF SET_BITS=64 -Wall -Winvalid-pch -ffast-math -fstrict-aliasing -Wpointer-arith -Wmissing-declarations -Wformat=2 -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wdeclaration-after -statement -Wunused -Wuninitialized -Wshadow -Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls -Wcast-align -Wno-unused-local-typedefs -Werror=implicit -Werror=init-self -Werror=main -Werror=missing -braces -Werror=return-type -Werror=array-bounds -Werror=write-strings -DG_DISABLE_CAST_CHECKS -DG_DISABLE_CHECKS -DTRANSLATE_WINDOWS_PATHS -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-stri ct-aliasing -isystem /usr/local/include -fPIC -pthread -DGIT_SSH=1 '-DG_LOG_DOMAIN="Ggit"' -MD -MQ libgit2-glib/libgit2-glib-1.0.so.0.200.0.p/ggit-clone-options.c.o -MF libgit2-glib/libgit2-glib-1.0.so.0.200.0.p/ ggit-clone-options.c.o.d -o libgit2-glib/libgit2-glib-1.0.so.0.200.0.p/ggit-clone-options.c.o -c ../libgit2-glib/ggit-clone-options.c ../libgit2-glib/ggit-clone-options.c:153:3: error: call to undeclared function 'git_error_set_str'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] 153 | git_error_set_str (GIT_ERROR, error->message); | ^ ../libgit2-glib/ggit-clone-options.c:153:3: note: did you mean 'giterr_set_str'? /usr/local/include/git2/deprecated.h:476:18: note: 'giterr_set_str' declared here 476 | GIT_EXTERN(void) giterr_set_str(int error_class, const char *string); | ^ ../libgit2-glib/ggit-clone-options.c:195:3: error: call to undeclared function 'git_error_set_str'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] 195 | git_error_set_str (GIT_ERROR, error->message); | ^ 2 errors generated. Any clues? Thanks
I have never upgraded libgit to version 1.8 as it is not supported yet. You can maybe try to ask upstream for libgit2-glib to support libgit2 1.8.
(In reply to Matthias Fechner from comment #1) Hello Natthias, I've found a PR that reflects this issue: https://gitlab.gnome.org/GNOME/libgit2-glib/-/issues/82 I think we have to wait? I'm asking because this PR already have 2 months ... Thanks
(In reply to Nuno Teixeira from comment #2) I see here two possibilities. 1. As the project does not really move, mark it as broken and upgrade libgit2 with a link pointing to this MR. I'm not sure how many ports are using libgit2-glib. 2. Wait for this MR to get merged upstream I personally would prefer option 1, but it depends on how many ports we will break by that change. But libgit2 1.8.x is now out for a very long time and I see every project as dead if the do not move to this version of libgit2.
(In reply to Matthias Fechner from comment #3) > I'm not sure how many ports are using libgit2-glib. editors/elementary-code editors/gedit-plugins editors/pluma-plugins devel/gitg devel/gnome-builder I will put a broken on it and check chain reaction... later today.
(In reply to Nuno Teixeira from comment #4) Thanks Nuno! And just to make it clear, you have permission from my side to update all ports I'm the maintainer to get libgit2 updated.
(In reply to Nuno Teixeira from comment #4) (...) Just a quick check of ports that depends on this list: editors/elementary-code: NONE editors/gedit-plugins: RUN DEPENDS: x11/gnome editors/pluma-plugins: NONE devel/gitg: NONE devel/gnome-builder: NONE So, I'm expecting that x11/gnome will be ignored when libgit2-glib is set to broken. This might be an issue, either way I will do poudriere tests and publish results here and see what we can do.
I think I've found the solution as it is used in Arch and OpenBSD: https://gitlab.gnome.org/GNOME/libgit2-glib/-/merge_requests/40 I will prepare a patch soon.
Created attachment 252627 [details] Fix build
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=d0c81ea46a8de95c2b963e8224318a6a879fb4c3 commit d0c81ea46a8de95c2b963e8224318a6a879fb4c3 Author: Nuno Teixeira <eduardo@FreeBSD.org> AuthorDate: 2024-10-18 14:28:15 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2024-10-18 18:56:41 +0000 devel/libgit2-glib: Fix build with devel/libgit2 1.8.1 PR: 280684 Approved by: maintainer timeout, >2 months devel/libgit2-glib/Makefile | 5 ++++- devel/libgit2-glib/distinfo | 4 +++- 2 files changed, 7 insertions(+), 2 deletions(-)
Committed, thanks.