Bug 280704 - deskutils/basket: Mark BROKEN, deprecate and set expiration date to YYYY-MM-DD
Summary: deskutils/basket: Mark BROKEN, deprecate and set expiration date to YYYY-MM-DD
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks: 280685
  Show dependency treegraph
 
Reported: 2024-08-09 14:15 UTC by Nuno Teixeira
Modified: 2024-10-18 20:28 UTC (History)
0 users

See Also:


Attachments
Deprecate and set removal date (702 bytes, patch)
2024-08-09 14:15 UTC, Nuno Teixeira
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nuno Teixeira freebsd_committer freebsd_triage 2024-08-09 14:15:06 UTC
Created attachment 252629 [details]
Deprecate and set removal date

Unmaintained for years, outdated and fails to build with libgit 1.8.1
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2024-08-10 12:17:28 UTC
FAILED: src/CMakeFiles/basketcommon.dir/gitwrapper.cpp.o 
/usr/bin/c++ -DKCOREADDONS_LIB -DKGUIADDONS_LIB -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_XML_LIB -DTRANSLATION_DOMAIN=\"basket\" -DWITH_LIBGIT2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -Dbasketcommon_EXPORTS -I/wrkdirs/usr/ports/deskutils/basket/work/.build/src -I/wrkdirs/usr/ports/deskutils/basket/work/basket-2.49a-46-g60e38c6/src -I/wrkdirs/usr/ports/deskutils/basket/work/.build/src/basketcommon_autogen/include -I/wrkdirs/usr/ports/deskutils/basket/work/.build -isystem /usr/local/include -isystem /usr/local/include/phonon4qt5 -isystem /usr/local/include/qt5 -isystem /usr/local/include/qt5/QtCore -isystem /usr/local/lib/qt5/mkspecs/freebsd-clang -isystem /usr/local/include/qt5/QtWidgets -isystem /usr/local/include/qt5/QtGui -isystem /usr/local/include/KF5/KArchive -isystem /usr/local/include/KF5 -isystem /usr/local/include/KF5/KConfigWidgets -isystem /usr/local/include/KF5/KWidgetsAddons -isystem /usr/local/include/KF5/KConfig -isystem /usr/local/include/KF5/KConfigGui -isystem /usr/local/include/qt5/QtXml -isystem /usr/local/include/KF5/KConfigCore -isystem /usr/local/include/KF5/KCoreAddons -isystem /usr/local/include/KF5/KCodecs -isystem /usr/local/include/KF5/KAuthWidgets -isystem /usr/local/include/KF5/KAuthCore -isystem /usr/local/include/KF5/KAuth -isystem /usr/local/include/KF5/KCrash -isystem /usr/local/include/KF5/KDBusAddons -isystem /usr/local/include/qt5/QtDBus -isystem /usr/local/include/KF5/KFileMetaData -isystem /usr/local/include/KF5/KGlobalAccel -isystem /usr/local/include/KF5/KGuiAddons -isystem /usr/local/include/KF5/KI18n -isystem /usr/local/include/KF5/KIconThemes -isystem /usr/local/include/KF5/KCMUtils -isystem /usr/local/include/KF5/KService -isystem /usr/local/include/KF5/KIOWidgets -isystem /usr/local/include/KF5/KIOGui -isystem /usr/local/include/KF5/KIOCore -isystem /usr/local/include/KF5/KIO -isystem /usr/local/include/qt5/QtNetwork -isystem /usr/local/include/qt5/QtConcurrent -isystem /usr/local/include/KF5/KWindowSystem -isystem /usr/local/include/KF5/KJobWidgets -isystem /usr/local/include/KF5/Solid -isystem /usr/local/include/KF5/KCompletion -isystem /usr/local/include/KF5/KNotifications -isystem /usr/local/include/KF5/KParts -isystem /usr/local/include/KF5/KXmlGui -isystem /usr/local/include/KF5/KTextWidgets -isystem /usr/local/include/KF5/SonnetUi -isystem /usr/local/include/KF5/Sonnet -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -fno-operator-names -fno-exceptions -Wno-gnu-zero-variadic-macro-arguments -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -Werror=init-self -Wvla -Wdate-time -fdiagnostics-color=always -O2 -pipe -fstack-protector-strong -fno-strict-aliasing   -DNDEBUG -std=gnu++11 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -fPIC -MD -MT src/CMakeFiles/basketcommon.dir/gitwrapper.cpp.o -MF src/CMakeFiles/basketcommon.dir/gitwrapper.cpp.o.d -o src/CMakeFiles/basketcommon.dir/gitwrapper.cpp.o -c /wrkdirs/usr/ports/deskutils/basket/work/basket-2.49a-46-g60e38c6/src/gitwrapper.cpp
/wrkdirs/usr/ports/deskutils/basket/work/basket-2.49a-46-g60e38c6/src/gitwrapper.cpp:129:14: warning: unused variable 'result' [-Wunused-variable]
  129 |         bool result = commitIndex(repo,index);
      |              ^~~~~~
/wrkdirs/usr/ports/deskutils/basket/work/basket-2.49a-46-g60e38c6/src/gitwrapper.cpp:157:10: warning: unused variable 'result' [-Wunused-variable]
  157 |     bool result = commitIndex(repo,index);
      |          ^~~~~~
/wrkdirs/usr/ports/deskutils/basket/work/basket-2.49a-46-g60e38c6/src/gitwrapper.cpp:203:10: warning: unused variable 'result' [-Wunused-variable]
  203 |     bool result = commitIndex(repo,index);
      |          ^~~~~~
/wrkdirs/usr/ports/deskutils/basket/work/basket-2.49a-46-g60e38c6/src/gitwrapper.cpp:267:14: warning: unused variable 'result' [-Wunused-variable]
  267 |         bool result = commitIndex(repo,index);
      |              ^~~~~~
/wrkdirs/usr/ports/deskutils/basket/work/basket-2.49a-46-g60e38c6/src/gitwrapper.cpp:296:10: warning: unused variable 'result' [-Wunused-variable]
  296 |     bool result = commitIndex(repo,index, message);
      |          ^~~~~~
/wrkdirs/usr/ports/deskutils/basket/work/basket-2.49a-46-g60e38c6/src/gitwrapper.cpp:366:13: error: no matching function for call to 'git_commit_create'
  366 |     error = git_commit_create(&commit_id, repo, "HEAD", sig, sig, NULL, commitmessageCString, tree, 1, parentarray);
      |             ^~~~~~~~~~~~~~~~~
/usr/local/include/git2/commit.h:359:17: note: candidate function not viable: no known conversion from 'const git_commit *[1]' to 'git_commit *const *' for 10th argument
  359 | GIT_EXTERN(int) git_commit_create(
      |                 ^
  360 |         git_oid *id,
  361 |         git_repository *repo,
  362 |         const char *update_ref,
  363 |         const git_signature *author,
  364 |         const git_signature *committer,
  365 |         const char *message_encoding,
  366 |         const char *message,
  367 |         const git_tree *tree,
  368 |         size_t parent_count,
  369 |         git_commit * const parents[]);
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5 warnings and 1 error generated.
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2024-10-04 09:27:21 UTC
Note to self:

Last commit is around 2020 and there is a pull request that might fix building with newer libgit2: https://github.com/basket-notepads/basket/pull/47 but there is no progress on it.

Mark as broken only.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-10-18 20:27:49 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=80accc4e562cba94317fc9292dea0ace76ab126d

commit 80accc4e562cba94317fc9292dea0ace76ab126d
Author:     Nuno Teixeira <eduardo@FreeBSD.org>
AuthorDate: 2024-10-18 20:24:42 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2024-10-18 20:26:53 +0000

    deskutils/basket: Deprecate and set expiration date to 2024-12-31

    Unmaintained for years, outdated and fails to build with libgit 1.8.1

    PR:             280704

 deskutils/basket/Makefile | 3 +++
 1 file changed, 3 insertions(+)