Bug 280741 - devel/grpc: fix build with clang 19
Summary: devel/grpc: fix build with clang 19
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks: 280562
  Show dependency treegraph
 
Reported: 2024-08-10 23:19 UTC by Dimitry Andric
Modified: 2024-08-15 14:12 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
devel/grpc: fix build with clang 19 (2.10 KB, patch)
2024-08-10 23:21 UTC, Dimitry Andric
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2024-08-10 23:19:59 UTC
Clang 19 now implements CWG 96 [1], which requires a template argument
list after a 'template' keyword, resulting in errors similar to:

    /wrkdirs/usr/ports/devel/grpc/work/grpc-1.62.2/src/core/lib/promise/detail/basic_seq.h:103:38: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
      103 |                     Traits::template CallSeqFactory(f_, *cur_, std::move(arg)));
          |                                      ^

In these cases, appending "<>" is enough to satisfy the constraint.
Upstream has committed a fix to their main branch [2], so pull this in
as a patch and apply it.

[1] https://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#96
[2] https://github.com/grpc/grpc/commit/e55f69cedd0ef7344e0bcb64b5ec9205e6aa4f04
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2024-08-10 23:21:43 UTC
Created attachment 252672 [details]
devel/grpc: fix build with clang 19
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2024-08-15 14:12:32 UTC
devel/grpc has been updated to 1.65.4 in ports e9a9fe7ceb5a72c0e514a2fe1962cd3c0bb99079 which includes the fix. Thanks.