Bug 280757 - databases/ocaml-sqlite3: update 5.1.0 → 5.2.0
Summary: databases/ocaml-sqlite3: update 5.1.0 → 5.2.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joel Bodenmann
URL: https://github.com/mmottl/sqlite3-oca...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-11 20:16 UTC by Älven
Modified: 2024-10-06 17:52 UTC (History)
2 users (show)

See Also:
freebsd: maintainer-feedback+


Attachments
[PATCH] databases/ocaml-sqlite3: update 5.1.0 → 5.2.0 (1.35 KB, patch)
2024-08-11 20:16 UTC, Älven
jbo: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Älven 2024-08-11 20:16:33 UTC
Created attachment 252695 [details]
[PATCH] databases/ocaml-sqlite3: update 5.1.0 → 5.2.0
Comment 1 Benjamin Jacobs 2024-08-18 16:16:03 UTC
Your patch is ok.
Comment 2 Joel Bodenmann freebsd_committer freebsd_triage 2024-10-02 18:06:31 UTC
Thank you for your patch!

The committer's guide asks for the full name for the git commit author field.
Could you please adjust the patch accordingly and/or update your bugzilla user profile?
Comment 3 Älven 2024-10-03 08:42:51 UTC
Always glad to hear my work is welcomed!

Still I always feel rather confused, being asked for using my official name (not a bit it's a secret). I understand it is not you, but the official guide asks for it.

Some good soul (martymac) had listened to my own stance [0] on me not using that and agreed on it. I may hope the official stance of the FreeBSD as a project may also sometimes change in favor of all the people who prefer to use their real names rather than official ones. At least by using pseudonyms.

For now, I understand you and other commiters being subject to strict rules and have nothing against applying my patches under their own names should they prefer this way, while being thankful for using pseudonyms if they feel appropriate.

Kind regards,
Älven

[0] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=278528#c7
Comment 4 Älven 2024-10-03 08:51:30 UTC
P.S. I may invent/compose some more real looking names (even in different languages) for it being considered "full" (have both first and last name) if it may help. Still as being not official, this likely make some people feel wrong about it and not trust me for it. I'm also not sure whether it will be right even for me, so always use the pseudonym as the greatest common denominator between my official and real names.
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-10-06 17:50:54 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=65f98c5a503ea23c9eda5aeea6bc000f4c180e42

commit 65f98c5a503ea23c9eda5aeea6bc000f4c180e42
Author:     Älven <alster@vinterdalen.se>
AuthorDate: 2024-08-11 20:10:15 +0000
Commit:     Joel Bodenmann <jbo@FreeBSD.org>
CommitDate: 2024-10-06 17:48:46 +0000

    databases/ocaml-sqlite3: Update to 5.2.0

    Changelog: https://github.com/mmottl/sqlite3-ocaml/releases/tag/5.2.0

    PR:             280757
    Approved by:    Benjamin Jacobs <freebsd@dev.thsi.be> (maintainer)

 databases/ocaml-sqlite3/Makefile | 2 +-
 databases/ocaml-sqlite3/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
Comment 6 Joel Bodenmann freebsd_committer freebsd_triage 2024-10-06 17:52:09 UTC
Committed - Thanks!