Created attachment 252764 [details] [PATCH] sysutils/htop: simplify Makefile This change cleans up the Makefile to follow Porter's Handbook guidance. Here is the rationale for each change: * As per https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github, ports are urged to move to using Github releases instead of git tags. This change replaces USE_GITHUB with MASTER_SITES to statically point to htop release tarballs. This also requires the addition of USES=tar:xz * Remove USES=autoreconf because the release tarball doesn't need to run it * Remove USES=compiler:c11 since upstream https://github.com/htop-dev/htop states that a C99 compiler is needed. * htop does not exist in the official NVD CPE dictionary, so as per https://docs.freebsd.org/en/books/porters-handbook/book/#uses-cpe, we should "not ever make up CPE data." Thus, USES=cpe is removed until an entry is contributed to the CPE dictionary * USES={libtool,localbase,pkgconfig,python:build,shebangfix} are not necessary for a successful build and run with the GH release tarball. * GNU_CONFIGURE_MANPREFIX was unnecessary since the PLIST does correctly install the manpage to the right location
Thank you for your contribution. Just a small modification by setting USES=desktop-file-utils.
Created attachment 252766 [details] htop-280820
(In reply to Hung-Yi Chen from comment #2) Thanks! Yeah yours looks good.
Maybe: MASTER_SITES= https://github.com/${PORTNAME}-dev/${PORTNAME}/releases/download/${DISTVERSION}/ ?
Created attachment 252770 [details] [PATCH] sysutils/htop: simplify Makefile Updated patch based on feedback
(In reply to Siva Mahadevan from comment #5) I'll commit if maintainer agree.
ping
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=9d7a750da6e7b15b07f31b21e8bbe7b6d4178b24 commit 9d7a750da6e7b15b07f31b21e8bbe7b6d4178b24 Author: Siva Mahadevan <me@svmhdvn.name> AuthorDate: 2024-08-22 12:09:45 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-08-22 12:09:45 +0000 sysutils/htop: simplify Makefile This change cleans up the Makefile to follow Porter's Handbook guidance. Here is the rationale for each change: * As per https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github, ports are urged to move to using Github releases instead of git tags. This change replaces USE_GITHUB with MASTER_SITES to statically point to htop release tarballs. This also requires the addition of USES=tar:xz * Remove USES=autoreconf because the release tarball doesn't need to run it * Remove USES=compiler:c11 since upstream https://github.com/htop-dev/htop states that a C99 compiler is needed. * Add USES=desktop-file-utils as the port installs htop.desktop * htop does not exist in the official NVD CPE dictionary, so as per https://docs.freebsd.org/en/books/porters-handbook/book/#uses-cpe, we should "not ever make up CPE data." Thus, USES=cpe is removed until an entry is contributed to the CPE dictionary * USES={libtool,localbase,pkgconfig,python:build,shebangfix} are not necessary for a successful build and run with the GH release tarball. * GNU_CONFIGURE_MANPREFIX was unnecessary since default value in Mk/bsd.port.mk is same ${PREFIX}/share PR: 280820 Approved by: Hung-Yi Chen <gaod@hychen.org> (maintainer) sysutils/htop/Makefile | 10 +++------- sysutils/htop/distinfo | 6 +++--- 2 files changed, 6 insertions(+), 10 deletions(-)
Thanks.
(In reply to Hung-Yi Chen from comment #1) > Just a small modification by setting USES=desktop-file-utils. Look like we don't need USES=desktop-file-utils for this port: > desktop-file-utils is only needed when the .desktop file contains a MimeType entry