Bug 280865 - graphics/dcmtk: fix build with clang 19
Summary: graphics/dcmtk: fix build with clang 19
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dimitry Andric
URL:
Keywords:
Depends on:
Blocks: 280562
  Show dependency treegraph
 
Reported: 2024-08-16 15:17 UTC by Dimitry Andric
Modified: 2024-08-16 15:50 UTC (History)
0 users

See Also:
yuri: maintainer-feedback+


Attachments
graphics/dcmtk: fix build with clang 19 (1.87 KB, patch)
2024-08-16 15:19 UTC, Dimitry Andric
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2024-08-16 15:17:05 UTC
Clang 19 now diagnoses incorrect member accesses, which causes
graphics/dcmtk to fail with a errors similar to:

    /wrkdirs/usr/ports/graphics/dcmtk/work/dcmtk-DCMTK-3.6.8/ofstd/include/dcmtk/ofstd/ofutil.h:79:18: error: no member named 'pt' in 'OFrvalue_storage<T, >'
       79 |         : t( rhs.pt ) {}
          |              ~~~ ^

Upstream dcmtk fixed this by changing the affected copy constructor in
https://github.com/DCMTK/dcmtk/commit/c29bebcd1, so pull this in as a
patch and apply it.
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2024-08-16 15:19:56 UTC
Created attachment 252826 [details]
graphics/dcmtk: fix build with clang 19
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2024-08-16 15:26:19 UTC
Approved, thanks for the patch.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-08-16 15:40:17 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e7c6b0ec720fbd79c019f0743a9de46a6df93683

commit e7c6b0ec720fbd79c019f0743a9de46a6df93683
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-08-16 15:17:33 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-08-16 15:37:03 +0000

    graphics/dcmtk: fix build with clang 19

    Clang 19 now diagnoses incorrect member accesses, which causes
    graphics/dcmtk to fail with a errors similar to:

        /wrkdirs/usr/ports/graphics/dcmtk/work/dcmtk-DCMTK-3.6.8/ofstd/include/dcmtk/ofstd/ofutil.h:79:18: error: no member named 'pt' in 'OFrvalue_storage<T, >'
           79 |         : t( rhs.pt ) {}
              |              ~~~ ^

    Upstream dcmtk fixed this by changing the affected copy constructor in
    https://github.com/DCMTK/dcmtk/commit/c29bebcd1, so pull this in as a
    patch and apply it.

    PR:             280865
    Approved by:    yuri (maintainer)
    MFH:            2024Q3

 graphics/dcmtk/Makefile | 3 +++
 graphics/dcmtk/distinfo | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-08-16 15:45:23 UTC
A commit in branch 2024Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5ee80b92e6545b1a7c3e329c93f2205b3088bfc7

commit 5ee80b92e6545b1a7c3e329c93f2205b3088bfc7
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-08-16 15:17:33 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-08-16 15:44:27 +0000

    graphics/dcmtk: fix build with clang 19

    Clang 19 now diagnoses incorrect member accesses, which causes
    graphics/dcmtk to fail with a errors similar to:

        /wrkdirs/usr/ports/graphics/dcmtk/work/dcmtk-DCMTK-3.6.8/ofstd/include/dcmtk/ofstd/ofutil.h:79:18: error: no member named 'pt' in 'OFrvalue_storage<T, >'
           79 |         : t( rhs.pt ) {}
              |              ~~~ ^

    Upstream dcmtk fixed this by changing the affected copy constructor in
    https://github.com/DCMTK/dcmtk/commit/c29bebcd1, so pull this in as a
    patch and apply it.

    PR:             280865
    Approved by:    yuri (maintainer)
    MFH:            2024Q3

    (cherry picked from commit e7c6b0ec720fbd79c019f0743a9de46a6df93683)

 graphics/dcmtk/Makefile | 3 +++
 graphics/dcmtk/distinfo | 4 +++-
 2 files changed, 6 insertions(+), 1 deletion(-)