Bug 280944 - [NEW-PORT] www/domoticz-devel: Home Automation System (Development Branch)
Summary: [NEW-PORT] www/domoticz-devel: Home Automation System (Development Branch)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-20 15:27 UTC by Xavier Beaudouin
Modified: 2024-08-23 09:08 UTC (History)
1 user (show)

See Also:


Attachments
git format-patch for domoticz-devel (61.40 KB, patch)
2024-08-20 15:27 UTC, Xavier Beaudouin
no flags Details | Diff
git format-patch for domoticz-devel (61.10 KB, patch)
2024-08-22 15:46 UTC, Xavier Beaudouin
no flags Details | Diff
git format-patch for domoticz-devel (61.06 KB, patch)
2024-08-23 09:06 UTC, Xavier Beaudouin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xavier Beaudouin 2024-08-20 15:27:24 UTC
Created attachment 252949 [details]
git format-patch for domoticz-devel

This port is the development branch of www/domoticz.

It will be update more or less each months (depending of my time, bugs I found).

Full changelog is : https://github.com/domoticz/domoticz/blob/development/History.txt

Tested on my production server (14.1-RELEASE) builded on my poudriere (amd64) : 14.0 & 14.1.

Portlint, portfmt has been used to check this port.

(notice the patch format will be in mbox format because of bugzilla magic issues).
Comment 1 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-08-20 15:46:31 UTC
Comment on attachment 252949 [details]
git format-patch for domoticz-devel

>From 069b4fa24dee6ccaa970a055e0034f95cea118cf Mon Sep 17 00:00:00 2001
>From: Xavier Beaudouin <kiwi@oav.net>
>Date: Tue, 20 Aug 2024 17:20:53 +0200
>Subject: [PATCH] [NEW-PORT] www/domoticz-devel: Home Automation System
> (Development Branch)
>
>---
> www/Makefile                                  |    1 +
> www/domoticz-devel/Makefile                   |   95 ++
> www/domoticz-devel/distinfo                   |    3 +
> www/domoticz-devel/files/domoticz.in          |   43 +
> www/domoticz-devel/files/patch-CMakeLists.txt |   58 +
> www/domoticz-devel/files/patch-DelayedLink.h  |   45 +
> www/domoticz-devel/files/patch-appversion.h   |    6 +
> www/domoticz-devel/pkg-descr                  |    4 +
> www/domoticz-devel/pkg-message                |   18 +
> www/domoticz-devel/pkg-plist                  | 1177 +++++++++++++++++
> 10 files changed, 1450 insertions(+)
> create mode 100644 www/domoticz-devel/Makefile
> create mode 100644 www/domoticz-devel/distinfo
> create mode 100644 www/domoticz-devel/files/domoticz.in
> create mode 100644 www/domoticz-devel/files/patch-CMakeLists.txt
> create mode 100644 www/domoticz-devel/files/patch-DelayedLink.h
> create mode 100644 www/domoticz-devel/files/patch-appversion.h
> create mode 100644 www/domoticz-devel/pkg-descr
> create mode 100644 www/domoticz-devel/pkg-message
> create mode 100644 www/domoticz-devel/pkg-plist
>
>diff --git a/www/Makefile b/www/Makefile
>index 06b9c69c555d..820c82b36aae 100644
>--- a/www/Makefile
>+++ b/www/Makefile
>@@ -143,6 +143,7 @@
>     SUBDIR += dolibarr17
>     SUBDIR += dolibarr18
>     SUBDIR += domoticz
>+    SUBDIR += domoticz-devel
>     SUBDIR += dooble
>     SUBDIR += dot-http
>     SUBDIR += dpp
>diff --git a/www/domoticz-devel/Makefile b/www/domoticz-devel/Makefile
>new file mode 100644
>index 000000000000..5c6fbbadf7c6
>--- /dev/null
>+++ b/www/domoticz-devel/Makefile
>@@ -0,0 +1,95 @@
>+PORTNAME=	domoticz-devel

This can probably be

PORTNAME=domoticz
PKGNAMESUFFIX=-devel

>+PORTVERSION=	2024.7.${DOMOTICZ_REL}
>+CATEGORIES=	www
>+
>+MAINTAINER=	kiwi@oav.net
>+COMMENT=	Home Automation System (Development Branch)
>+WWW=		https://www.domoticz.com
>+
>+LICENSE=	GPLv3
>+LICENSE_FILE=	${WRKSRC}/License.txt
>+
>+LIB_DEPENDS=	libcurl.so:ftp/curl \
>+		libjsoncpp.so:devel/jsoncpp \
>+		libmosquitto.so:net/mosquitto
>+
>+USES=		cmake compiler:c++11-lang cpe lua:53 minizip pkgconfig sqlite \
>+		ssl

It looks like the other domoticz port received some clean up recently. I think it would be a good idea to base this -devel port on the most recent domoticz version in the ports tree.

>+GH_ACCOUNT=	domoticz
>+GH_PROJECT=	domoticz

GH_ACCOUNT and GH_PROJECT won't be necessary if PORTNAME stays "domoticz".


>+DCMAKE_INSTALL_PREFIX=	${PREFIX}/domoticz

Is DCMAKE... a typo?

>+CMAKE_OFF+=		GIT_SUBMODULE USE_BUILTIN_JSONCPP USE_BUILTIN_MINIZIP \
>+			USE_BUILTIN_MQTT USE_BUILTIN_SQLITE USE_LUA_STATIC
>+
>+.if ${PORT_OPTIONS:MSSSL}
>+CMAKE_ON+=	USE_OPENSSL_STATIC
>+.else
>+CMAKE_OFF+=	USE_OPENSSL_STATIC
>+.endif

SSL_CMAKE_ON=...
SSL_CMAKE_OFF=...

(See biology/seqan-apps/Makefile for example. Same can be done for other if statemnts in this file.)

>+USES+=		python:3.8+

This is already 3.9 in www/domoticz. Please rebase first.
Comment 2 Xavier Beaudouin 2024-08-22 15:46:21 UTC
Created attachment 253019 [details]
git format-patch for domoticz-devel

Here is updated git format-patch for this new port.

It is "synced" with www/domoticz port. 

(I will update both ports with statements ideas suggested when I will push the www/domoticz update to 2024.7).
Comment 3 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-08-22 16:19:51 UTC
Comment on attachment 253019 [details]
git format-patch for domoticz-devel

>+#BUILD_DEPENDS=	cereal>=1.2.2:devel/cereal

Is there a reason to keep this commented out instead of just removed?
Comment 4 Xavier Beaudouin 2024-08-22 16:50:28 UTC
(In reply to Mateusz Piotrowski from comment #3)
Well this was here when the project needed cereal. I forgot to remove it
Comment 5 Xavier Beaudouin 2024-08-23 09:06:49 UTC
Created attachment 253033 [details]
git format-patch for domoticz-devel

Fixed port (without the cereal comment).

Thanks
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-08-23 09:07:54 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3ee6601b7ccfc0053a210a35144fbe0f6f8ef2a6

commit 3ee6601b7ccfc0053a210a35144fbe0f6f8ef2a6
Author:     Xavier Beaudouin <kiwi@oav.net>
AuthorDate: 2024-08-22 15:41:27 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2024-08-23 09:07:15 +0000

    www/domoticz-devel: Home Automation System (Development Branch)

    This port is the development branch of www/domoticz. The plan is to
    update it more or less each months.

    PR:             280944

 www/Makefile                                       |    1 +
 www/domoticz-devel/Makefile (new)                  |   81 ++
 www/domoticz-devel/distinfo (new)                  |    3 +
 www/domoticz-devel/files/domoticz.in (new)         |   43 +
 .../files/patch-CMakeLists.txt (new)               |   58 +
 www/domoticz-devel/files/patch-DelayedLink.h (new) |   45 +
 www/domoticz-devel/files/patch-appversion.h (new)  |    6 +
 www/domoticz-devel/pkg-descr (new)                 |    4 +
 www/domoticz-devel/pkg-message (new)               |   18 +
 www/domoticz-devel/pkg-plist (new)                 | 1177 ++++++++++++++++++++
 10 files changed, 1436 insertions(+)
Comment 7 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-08-23 09:08:17 UTC
Committed! Thanks!