Bug 281099 - net/miniupnpd: Update to 2.3.7
Summary: net/miniupnpd: Update to 2.3.7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-27 19:53 UTC by martin
Modified: 2024-09-12 22:44 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (squat)


Attachments
patch (24.38 KB, patch)
2024-08-27 19:53 UTC, martin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description martin 2024-08-27 19:53:41 UTC
Created attachment 253133 [details]
patch

The port works has been updated to the latest version 2.3.7 and complies with the new libpfctl API.

I've removed the source patches for pf, because they have been merged upstream and use the define --libpfctl.

Test on Playstation 5 shows "NAT type 2" again. So it seems to work.
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-08 11:26:15 UTC
Why did you edit pkg-descr?
Comment 2 martin 2024-09-08 14:33:28 UTC
There shouldn't be any changes done to pkg-descr in this patch.
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-08 19:25:21 UTC
(In reply to martin from comment #2)
Sorry, incorrect window.

Still waiting maintainer…
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-12 21:16:58 UTC
Maintainer timeout > 14 days.

1. Keep "PORTEPOCH=	1", it isn't PORTREVISION.
2. Spaces replace with tabs: LIB_DEPENDS=   libpfctl.so:net/libpfctl.
3. Sort options in: USES= cpe localbase:ldflags ssl
4. Use declared variables (especially in the version):
 GH_ACCOUNT=    miniupnp
-GH_PROJECT=    miniupnp
-GH_TAGNAME=    miniupnpd_2_3_6
+GH_PROJECT=    ${GH_ACCOUNT}
+GH_TAGNAME=    ${PORTNAME}_${DISTVERSION:S|.|_|g}
-USE_RC_SUBR=   miniupnpd
+USE_RC_SUBR=   ${PORTNAME}
-WRKSRC_SUBDIR= miniupnpd
+WRKSRC_SUBDIR= ${PORTNAME}
5. Move CONFIGURE_ARGS after HAS_CONFIGURE.
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-12 21:39:30 UTC
6. Sort options in:
PLIST_FILES=    etc/miniupnpd.conf.sample \
                sbin/miniupnpd \
                share/man/man8/miniupnpd.8.gz
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-12 22:03:14 UTC
7. Use release tarball form upstream instead of USE_GITHUB:
MASTER_SITES=   https://github.com/miniupnp/miniupnp/releases/download/${PORTNAME}_${DISTVERSION:S|.|_|g}/
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-09-12 22:42:07 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f53752043e6e503140cbde418d09dcd0ff1e8874

commit f53752043e6e503140cbde418d09dcd0ff1e8874
Author:     martin <martin@sugioarto.com>
AuthorDate: 2024-09-12 22:36:35 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-09-12 22:36:35 +0000

    net/miniupnpd: Update 2.3.6 → 2.3.7

    Changelog:
     - FreeBSD: use libpfctl (FreeBSD 15+ or --libpfctl)
     - default NOTIFY interval of 900s minus a random value
     - ipv6: prefer globally routable addresses
    http://miniupnp.free.fr/files/changelog.php?file=miniupnpd-2.3.7.tar.gz

    Port improvements:
     - use release tarball from upstream instead of USE_GITHUB;
     - replace spaces with tabs;
     - sort options in USES and in PLIST_FILES;
     - use PORTNAME variable in USE_RC_SUBR;
     - pet portclippy.

    PR:             281099
    Approved by:    squat@squat.no (maintainer, timeout > 14 days)

 net/miniupnpd/Makefile                          |  23 +-
 net/miniupnpd/distinfo                          |   6 +-
 net/miniupnpd/files/patch-pf_obsdrdr.c (gone)   | 458 ------------------------
 net/miniupnpd/files/patch-pf_pfpinhole.c (gone) | 210 -----------
 4 files changed, 12 insertions(+), 685 deletions(-)
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-12 22:44:50 UTC
Thanks.