Bug 281101 - multimedia/x265: checksum of x265-asm-warnings.patch changed due to update git at bitbucket from 2.45.2 to 2.46.0
Summary: multimedia/x265: checksum of x265-asm-warnings.patch changed due to update gi...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Many People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-27 21:45 UTC by Dennis Clarke
Modified: 2024-09-17 13:24 UTC (History)
4 users (show)

See Also:
vvd: maintainer-feedback? (freebsd-2024)
vvd: merge-quarterly+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Clarke 2024-08-27 21:45:54 UTC
Seen in the last few hours : 

[00:00:15] [01] [00:00:00] Builder started
[00:00:15] [01] [00:00:00] Building multimedia/x265 | x265-3.5_2
[00:00:15] [02] [00:00:00] Builder started
[00:00:15] [02] [00:00:00] Building databases/sfcgal | sfcgal-1.5.1_1
[00:00:16] [01] [00:00:01] Finished multimedia/x265 | x265-3.5_2: Failed: checksum
.
.
.

triton# 
triton# pwd
/poudriere/ports/2024Q3/multimedia/x265
triton# 
triton# cat distinfo 
TIMESTAMP = 1723149544
SHA256 (x265-3.5.tar.gz) = 8a5fcfddb3e2db520b637e475a507fb00117d554bdb3204c5828626d888c306a
SIZE (x265-3.5.tar.gz) = 1538610
SHA256 (x265-asm-warnings.patch) = b59df1758664d85347e8f04fdf0a2934b6e0248af62e03a8e0aba0840c6280f3
SIZE (x265-asm-warnings.patch) = 4526
triton# 

Looking at https://www.x265.org/downloads/ there does not appear to
even be a v3.5 so this is a mystery to me.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2024-08-27 21:45:54 UTC
Maintainer informed via mail
Comment 2 Dennis Clarke 2024-08-27 21:54:45 UTC

Seems bizarre to me that the description points to https://www.x265.org/
whereas the Makefile clearly claims : 

    https://bitbucket.org/multicoreware/x265_git/wiki/Home

So this is getting stranger.

$ 
$ curl -4 -L --url 'https://bitbucket.org/multicoreware/x265_git/downloads/x265_3.5.tar.gz' -O 
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 1501k  100 1501k    0     0  1288k      0  0:00:01  0:00:01 --:--:-- 1288k
$ 
$ openssl dgst -sha256 -r x265_3.5.tar.gz 
e70a3335cacacbba0b3a20ec6fecd6783932288ebc8163ad74bcc9606477cae8 *x265_3.5.tar.gz
$

Which is not what we see in distinfo : 

https://cgit.freebsd.org/ports/tree/multimedia/x265/distinfo

So this is just getting even more strange.
Comment 3 Salz 2024-08-27 22:26:46 UTC
When I fetch the tar from the same location as `make fetch` does, I get the correct sha256sum, but the x265-asm-warnings.patch sha256sum is broken (see below).

The .patch file is autogenerated by git and contains the version number at the bottom. When I change that fro 2.46.0 to 2.45.2, the sha256sum of the file matches the one in distinfo. So it seems bitbucket upgraded git and broke the sha256sum.


/usr/ports/multimedia/x265$ sudo make fetch
===>  License GPLv2+ accepted by the user
===>   x265-3.5_2 depends on file: /usr/local/sbin/pkg - found
=> x265-3.5.tar.gz doesn't seem to exist in /usr/ports/distfiles/.
=> Attempting to fetch https://bitbucket.org/multicoreware/x265_git/get/Release_3.5.tar.gz?meow=/x265-3.5.tar.gz
x265-3.5.tar.gz                                       1502 kB 2763 kBps    00s
=> x265-asm-warnings.patch doesn't seem to exist in /usr/ports/distfiles/.
=> Attempting to fetch https://bitbucket.org/multicoreware/x265_git/commits/8f18e3ad32684eee95e885e718655f93951128c3/raw/x265-asm-warnings.patch
x265-asm-warnings.patch                               4526  B   20 MBps    00s
===> Fetching all distfiles required by x265-3.5_2 for building
/usr/ports/multimedia/x265$ sha256sum ../../distfiles/x265-asm-warnings.patch
235e108845b6b24b72825c708d502e1fa90399a3549f73fa7804b35e01e85b89  ../../distfiles/x265-asm-warnings.patch
/usr/ports/multimedia/x265$ cat distinfo 
TIMESTAMP = 1723149544
SHA256 (x265-3.5.tar.gz) = 8a5fcfddb3e2db520b637e475a507fb00117d554bdb3204c5828626d888c306a
SIZE (x265-3.5.tar.gz) = 1538610
SHA256 (x265-asm-warnings.patch) = b59df1758664d85347e8f04fdf0a2934b6e0248af62e03a8e0aba0840c6280f3
SIZE (x265-asm-warnings.patch) = 4526
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-27 22:40:26 UTC
This is a known problem for this port - it has occurred at least three times this year...
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-08-27 22:46:59 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d91a3bbe622bfd57a248bf81bc3aa7df5e525938

commit d91a3bbe622bfd57a248bf81bc3aa7df5e525938
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-08-27 22:43:15 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-08-27 22:43:15 +0000

    multimedia/x265: Refresh distfile

    Footer in patch file x265-asm-warnings.patch now reports 2.46.0 instead
    of 2.45.2 which causes a checksum mismatch

    PR:             281101
    Approved by:    portmgr (blanket, build fix)

 multimedia/x265/distinfo | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-08-27 22:51:01 UTC
A commit in branch 2024Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3d4aa613f26c558d561ff60b8f7816977e8e8166

commit 3d4aa613f26c558d561ff60b8f7816977e8e8166
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-08-27 22:43:15 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-08-27 22:50:13 +0000

    multimedia/x265: Refresh distfile

    Footer in patch file x265-asm-warnings.patch now reports 2.46.0 instead
    of 2.45.2 which causes a checksum mismatch

    PR:             281101
    Approved by:    portmgr (blanket, build fix)

    (cherry picked from commit d91a3bbe622bfd57a248bf81bc3aa7df5e525938)

 multimedia/x265/distinfo | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 7 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-27 22:51:26 UTC
Thanks!
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2024-08-27 23:02:15 UTC
Maybe we should move the patch to files/ to prevent this behavior in the future?
Comment 9 Edward.Sanford.Sutton, III 2024-08-28 00:11:35 UTC
(In reply to Vladimir Druzenko from comment #8)
or at least a post fetch command that chops that line off entirely.
Comment 10 Dennis Clarke 2024-08-28 01:10:54 UTC
Yep .. that works : 

[00:03:52] [01] [00:03:37] Finished multimedia/x265 | x265-3.5_2: Success