Bug 281384 - [PATCH] net-mgmt/check_mk_agent: integrate PR 723 sysctl_mem feature
Summary: [PATCH] net-mgmt/check_mk_agent: integrate PR 723 sysctl_mem feature
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-09 09:49 UTC by Xavier Beaudouin
Modified: 2024-09-19 20:28 UTC (History)
2 users (show)

See Also:
ivalentine: maintainer-feedback+

Attachments
git format-patch for check_mk_agent (3.10 KB, application/mbox)
2024-09-09 09:49 UTC, Xavier Beaudouin 		no flags Details
git format-patch for check_mk_agent (3.10 KB, patch)
2024-09-10 08:22 UTC, Xavier Beaudouin 		no flags Details | Diff
0001-net-mgmt-check_mk_agent-bug-281384.patch (4.65 KB, patch)
2024-09-19 20:28 UTC, Ian Valentine 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xavier Beaudouin 2024-09-09 09:49:12 UTC 
Created attachment 253450 [details]
git format-patch for check_mk_agent

Hello,

This patch integrate the PR#723, this patch permit to have access to memory information without depending of statgrab dependency.

The original PR: https://github.com/Checkmk/checkmk/pull/723

Kind regards,
Xavier
Comment 1 Ian Valentine 2024-09-09 18:17:20 UTC 
The edits to set_variable_defaults() and preamble_1() should be removed, but the actual patch to run_purely_synchronous_sections() looks good to me. I'll switch the libstatgrab dependency to be optional when the serverside changes are made.
Comment 2 Xavier Beaudouin 2024-09-10 08:22:41 UTC 
Created attachment 253477 [details]
git format-patch for check_mk_agent

(In reply to Ian Valentine from comment #1)

Oh ! 
It seems I made a mistake make I applied the patch. Thank to head up me on that.

The git format-patch has been updated without this mistake.

Tell me if you seems this is ok for you ?

Kind regards,
Xavier
Comment 3 Ian Valentine 2024-09-19 20:26:00 UTC 
Comment on attachment 253477 [details]
git format-patch for check_mk_agent

This is still making edits to the directory variables. I've made a patch that reworks how the existing patches to the file function and includes your changes.
Comment 4 Ian Valentine 2024-09-19 20:28:15 UTC 
Created attachment 253671 [details]
0001-net-mgmt-check_mk_agent-bug-281384.patch