Bug 281418 - misc/openvdb: fix build with clang 19
Summary: misc/openvdb: fix build with clang 19
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dimitry Andric
URL:
Keywords:
Depends on:
Blocks: 280562
  Show dependency treegraph
 
Reported: 2024-09-10 14:24 UTC by Dimitry Andric
Modified: 2024-09-10 19:50 UTC (History)
0 users

See Also:
yuri: maintainer-feedback+


Attachments
misc/openvdb: fix build with clang 19 (2.96 KB, patch)
2024-09-10 14:26 UTC, Dimitry Andric
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2024-09-10 14:24:25 UTC
Clang 19 now implements CWG 96 [1], which requires a template argument
list after a 'template' keyword, resulting in errors similar to:

    /wrkdirs/usr/ports/misc/openvdb/work/openvdb-11.0.0/openvdb/openvdb/../openvdb/tree/NodeManager.h:330:31: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
      330 |                 OpT::template eval(mNodeOp, it);
          |                               ^
    /wrkdirs/usr/ports/misc/openvdb/work/openvdb-11.0.0/openvdb/openvdb/../openvdb/tree/NodeManager.h:350:31: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
      350 |                 OpT::template eval(mNodeOp, it);
          |                               ^
    /wrkdirs/usr/ports/misc/openvdb/work/openvdb-11.0.0/openvdb/openvdb/../openvdb/tree/NodeManager.h:375:31: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
      375 |                 OpT::template eval(*mNodeOp, it);
          |                               ^

In these cases, appending "<>" is enough to satisfy the constraint.
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2024-09-10 14:26:21 UTC
Created attachment 253488 [details]
misc/openvdb: fix build with clang 19
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2024-09-10 15:45:45 UTC
Thanks for the patch.
Approved, please commit it.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-09-10 19:48:37 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1f9773e8d9e41c322b14ae6b199bd5a90de27aae

commit 1f9773e8d9e41c322b14ae6b199bd5a90de27aae
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-09-10 14:24:56 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-09-10 19:46:23 +0000

    misc/openvdb: fix build with clang 19

    Clang 19 now implements CWG 96 [1], which requires a template argument
    list after a 'template' keyword, resulting in errors similar to:

        /wrkdirs/usr/ports/misc/openvdb/work/openvdb-11.0.0/openvdb/openvdb/../openvdb/tree/NodeManager.h:330:31: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
          330 |                 OpT::template eval(mNodeOp, it);
              |                               ^
        /wrkdirs/usr/ports/misc/openvdb/work/openvdb-11.0.0/openvdb/openvdb/../openvdb/tree/NodeManager.h:350:31: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
          350 |                 OpT::template eval(mNodeOp, it);
              |                               ^
        /wrkdirs/usr/ports/misc/openvdb/work/openvdb-11.0.0/openvdb/openvdb/../openvdb/tree/NodeManager.h:375:31: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
          375 |                 OpT::template eval(*mNodeOp, it);
              |                               ^

    In these cases, appending "<>" is enough to satisfy the constraint.

    PR:             281418
    Approved by:    yuri (maintainer)
    MFH:            2024Q3

 .../patch-openvdb_openvdb_tree_NodeManager.h (new) | 29 ++++++++++++++++++++++
 1 file changed, 29 insertions(+)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-09-10 19:49:38 UTC
A commit in branch 2024Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c55c3e0628abba7918816d0190c894dd92567358

commit c55c3e0628abba7918816d0190c894dd92567358
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-09-10 14:24:56 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-09-10 19:49:03 +0000

    misc/openvdb: fix build with clang 19

    Clang 19 now implements CWG 96 [1], which requires a template argument
    list after a 'template' keyword, resulting in errors similar to:

        /wrkdirs/usr/ports/misc/openvdb/work/openvdb-11.0.0/openvdb/openvdb/../openvdb/tree/NodeManager.h:330:31: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
          330 |                 OpT::template eval(mNodeOp, it);
              |                               ^
        /wrkdirs/usr/ports/misc/openvdb/work/openvdb-11.0.0/openvdb/openvdb/../openvdb/tree/NodeManager.h:350:31: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
          350 |                 OpT::template eval(mNodeOp, it);
              |                               ^
        /wrkdirs/usr/ports/misc/openvdb/work/openvdb-11.0.0/openvdb/openvdb/../openvdb/tree/NodeManager.h:375:31: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
          375 |                 OpT::template eval(*mNodeOp, it);
              |                               ^

    In these cases, appending "<>" is enough to satisfy the constraint.

    PR:             281418
    Approved by:    yuri (maintainer)
    MFH:            2024Q3

    (cherry picked from commit 1f9773e8d9e41c322b14ae6b199bd5a90de27aae)

 .../patch-openvdb_openvdb_tree_NodeManager.h (new) | 29 ++++++++++++++++++++++
 1 file changed, 29 insertions(+)