Bug 281453 - sysutils/ipmi_exporter: Add listen-address configuration variable
Summary: sysutils/ipmi_exporter: Add listen-address configuration variable
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Zsolt Udvari
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-12 09:18 UTC by Andreas E
Modified: 2024-10-28 05:56 UTC (History)
2 users (show)

See Also:
meka: maintainer-feedback+

Attachments
ipmi_exporter rc-script (791 bytes, patch)
2024-09-12 09:18 UTC, Andreas E 		no flags Details | Diff
new diff with comment for new variable (1.04 KB, patch)
2024-09-30 07:19 UTC, Andreas E 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas E 2024-09-12 09:18:30 UTC 
Created attachment 253512 [details]
ipmi_exporter rc-script

Add separate configuration variable in the same way as sysutils/node_exporter has for configuring a specific IP/hostname to listen on.
Comment 1 Zsolt Udvari freebsd_committer freebsd_triage 2024-09-27 18:19:10 UTC 
What do you think about adding a comment line about new variable, like 'ipmi_exporter_config' (https://cgit.freebsd.org/ports/tree/sysutils/ipmi_exporter/files/ipmi_exporter.in#n12). I suggest it.
Comment 2 Andreas E 2024-09-30 07:19:20 UTC 
Created attachment 253902 [details]
new diff with comment for new variable

Agree. Here's an updated diff with comment on the listen_address variable.
Comment 3 Zsolt Udvari freebsd_committer freebsd_triage 2024-10-28 05:55:30 UTC 
Committed, thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-10-28 05:56:04 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=364d89e1c062f7a2b97615e978e5d94627a2c9e7

commit 364d89e1c062f7a2b97615e978e5d94627a2c9e7
Author:     Andreas E <norrland@nullbyte.se>
AuthorDate: 2024-10-28 05:51:33 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-10-28 05:51:33 +0000

    sysutils/ipmi_exporter: Add listen-address configuration variable

    Add separate configuration variable in the same way as
    sysutils/node_exporter has for configuring a specific IP/hostname to
    listen on.

    PR:             281453
    Approved by:    Goran Mekić <meka@tilda.center> (maintainer)

 sysutils/ipmi_exporter/files/ipmi_exporter.in | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)