As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes www/node18 to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned short>' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ ../deps/v8/src/inspector/string-16.h:113:28: note: in instantiation of template class 'std::basic_string<unsigned short>' requested here 113 | std::basic_string<UChar> m_impl; | ^ /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here 23 | struct _LIBCPP_TEMPLATE_VIS char_traits; | ^ Upstream v8 has fixed this in commit 182d9c05e78 [2], so add it as a backported patch, until the next version of node is released. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals [2] https://chromium.googlesource.com/v8/v8.git/+/182d9c05e78
Created attachment 253545 [details] www/node18: fix build with libc++ 19
LGTM. Thanks.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=2d0cb380eb97a0dcc99d08cfe863954813c42024 commit 2d0cb380eb97a0dcc99d08cfe863954813c42024 Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-09-13 16:11:33 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2024-09-19 07:16:40 +0000 www/node18: fix build with libc++ 19 As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes www/node18 to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned short>' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ ../deps/v8/src/inspector/string-16.h:113:28: note: in instantiation of template class 'std::basic_string<unsigned short>' requested here 113 | std::basic_string<UChar> m_impl; | ^ /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here 23 | struct _LIBCPP_TEMPLATE_VIS char_traits; | ^ Upstream v8 has fixed this in commit 182d9c05e78 [2], so add it as a backported patch, until the next version of node is released. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals [2] https://chromium.googlesource.com/v8/v8.git/+/182d9c05e78 PR: 281485 Approved by: sunpoet (maintainer) MFH: 2024Q3 www/node18/files/patch-libc++19 (new) | 185 ++++++++++++++++++++++++++++++++++ 1 file changed, 185 insertions(+)
A commit in branch 2024Q3 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=abfc745e8a9bc058343fa8bee7f4b43259719294 commit abfc745e8a9bc058343fa8bee7f4b43259719294 Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-09-13 16:11:33 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2024-09-19 07:22:11 +0000 www/node18: fix build with libc++ 19 As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes www/node18 to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned short>' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ ../deps/v8/src/inspector/string-16.h:113:28: note: in instantiation of template class 'std::basic_string<unsigned short>' requested here 113 | std::basic_string<UChar> m_impl; | ^ /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here 23 | struct _LIBCPP_TEMPLATE_VIS char_traits; | ^ Upstream v8 has fixed this in commit 182d9c05e78 [2], so add it as a backported patch, until the next version of node is released. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals [2] https://chromium.googlesource.com/v8/v8.git/+/182d9c05e78 PR: 281485 Approved by: sunpoet (maintainer) MFH: 2024Q3 (cherry picked from commit 2d0cb380eb97a0dcc99d08cfe863954813c42024) www/node18/files/patch-libc++19 (new) | 185 ++++++++++++++++++++++++++++++++++ 1 file changed, 185 insertions(+)