Created attachment 253642 [details] update to 2.8.1 Changes: compat11x not needed anymore, COMPAT11 still required. Generally this is a reroll of an older build, no major changes, just some updates. Newer versions are available but dist has the same binary as this build.
1. Use DISTVERSION in MASTER_SITES. 2. Lines in do-build are too long, better to split: do-build: ${WRKSRC}/rslsync --nodaemon --storage ${WRKSRC} \ --dump-sample-config > ${WRKSRC}/rslsync.conf.sample ${REINPLACE_CMD} -e \ 's;^//\([[:space:]]*"storage_path"[[:space:]]*:[[:space:]]*\)"/.*",$$;\1"/var/db/rslsync",;' \ ${WRKSRC}/rslsync.conf.sample ${REINPLACE_CMD} -e \ 's;^//\([[:space:]]*"pid_file"[[:space:]]*:[[:space:]]*\)"/.*",$$;\1"/var/run/rslsync/rslsync.pid",;' \ ${WRKSRC}/rslsync.conf.sample 2. make maintainer-makesum doesn't work. This version work correctly: maintainer-makesum: for arch in ${ONLY_FOR_ARCHS}; do \ ${MAKE} DISTINFO_FILE=/dev/stdout ARCH=$$arch makesum; \ done | ${GREP} -v '^===> ' | ${AWK} '$$1 != "TIMESTAMP" || NR == 1' \ > ${DISTINFO_FILE}
The do-build section should probably be post-install? https://cgit.freebsd.org/ports/tree/net/gerbera/Makefile#n85
I guess idea behind do-build was to provide sample config in the package without need to generate it during install. Not sure.
ping
Created attachment 254930 [details] fixed patch to 3.0.0.1409 Ahm, that was for me. Sorry, fixed Makefile a little. Anyway I think this will be the last version. They dropped FreeBSD support. Will create rslsync-linux when I have time.
(In reply to Volodymyr Kostyrko from comment #6) My suggestion is: 1. Add "NO_BUILD=yes" (before SUB_FILES). 2. Move all lines from do-build to do-install.
3. Deprecated support for Windows_x86, Linux_i386, FreeBSD, and Docker https://help.resilio.com/hc/en-us/articles/31386579044755-Resilio-Sync-3-0-change-log
Created attachment 255009 [details] update to 2.8.1 Ah, I see your point. Moved everything to install. Also checked versions, newest blob for 3.0.0 actually contains binaries for 2.8.1, so there's no point in fooling everybody...
====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: /var/db/%%USER%%/debug.txt Error: Orphaned: /var/db/%%USER%%/settings.dat Error: Orphaned: /var/db/%%USER%%/sync.lng ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found.
Created attachment 255055 [details] update to 2.8.1 Big thanks for testing, overlooked that part.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=1d5854a31b343cd2162b9795d528734303abb28d commit 1d5854a31b343cd2162b9795d528734303abb28d Author: Volodymyr Kostyrko <arcade@b1t.name> AuthorDate: 2024-11-09 17:45:34 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-11-09 17:50:10 +0000 net-p2p/rslsync: Update 2.7.3 → 2.8.1.1390 Changelog: https://help.resilio.com/hc/en-us/articles/206216855-Sync-2-x-change-log Improve port: split long lines, add NO_BUILD, merge do-build and do-install. PR: 281567 net-p2p/rslsync/Makefile | 25 +++++++++++++++---------- net-p2p/rslsync/distinfo | 10 +++++----- 2 files changed, 20 insertions(+), 15 deletions(-)
Thanks.