Bug 281582 - java/eclipse: Remove unnecessary *.so files
Summary: java/eclipse: Remove unnecessary *.so files
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-19 06:47 UTC by Norbert Grundmann
Modified: 2024-09-20 05:18 UTC (History)
1 user (show)

See Also:


Attachments
remove uneccessary *so files (30.79 KB, application/gzip)
2024-09-19 06:47 UTC, Norbert Grundmann
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Norbert Grundmann 2024-09-19 06:47:14 UTC
Created attachment 253654 [details]
remove uneccessary *so files

Remove *.so files which were in the ports files/addons folder, but which are not necessary for the build.
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-19 17:13:06 UTC
Where is patch for port?
What is in archive?
This name eclipse-freebsd-addons-4.32.tar.gz is for file hosted on your github space with all necessary files from java/eclipse/files/addons.
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-19 17:14:53 UTC
Also you can keep empty dirs in this archive.
Comment 3 Norbert Grundmann 2024-09-19 17:24:10 UTC
mhmmm.  sorry - I cannot follow your comments...  I added the addons without the *.so files.  like it should be.  The other files like Makefile etc. are not influenced and I did not send them.  If you need everything - then on my github

https://github.com/NorbertXYZ/eclipse

in the folder port
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-19 18:45:00 UTC
(In reply to Norbert Grundmann from comment #3)
No. I mean addons dir must be in external file hosted in your github space: https://github.com/NorbertXYZ/eclipse/releases.
Patch with remove addons from files, remove our for with ${MKDIR}, add eclipse-freebsd-addons-4.32.tar.gz as additional DISTFILE.
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-19 23:34:02 UTC
As a temporary workaround I'll commit this:

1. Change in Makefile:
.for _ARCH in aarch64 powerpc64 powerpc64le x86_64
. for DIR in ${EMPTY_DIRS}
        ${MKDIR} ${WRKSRC}/${DIR:S|%%ARCH%%|${_ARCH}|g}
        ${TOUCH} ${WRKSRC}/${DIR:S|%%ARCH%%|${_ARCH}|g}/.empty
. endfor
. for _SO in atk- glx- cairo- awt- "" pi3- webkit-
        ${TOUCH} ${WRKSRC}/eclipse.platform.swt/binaries/org.eclipse.swt.gtk.freebsd.${_ARCH}/libswt-${_SO}gtk-4965r11.so
. endfor
.endfor

2. Remove all *.so files from files/addons/eclipse.platform.swt/binaries/.
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2024-09-19 23:39:32 UTC
Ignore my last message.

As a temporary workaround I'll commit your new addons dir.
But anyway we must move it from files/ to external storage. Best place for it is your github space, IMHO.
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-09-20 00:29:34 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3ec21e417cd5752c96b88587a5a605567ba5cd19

commit 3ec21e417cd5752c96b88587a5a605567ba5cd19
Author:     Norbert Grundmann <ngrundmann@gmx.de>
AuthorDate: 2024-09-20 00:14:47 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-09-20 00:14:47 +0000

    java/eclipse: Remove unnecessary *.so files

    This is a temporary workaround for fix several broken processes.
    Moving java/eclipse/file/addons to external storage comming soon.

    PR:             281582
    Reported by:    several developers via email

 .../binaries/org.eclipse.swt.gtk.freebsd.aarch64/build.properties      | 2 +-
 .../libswt-atk-gtk-4965r11.so (gone)                                   | 3 ---
 .../libswt-awt-gtk-4965r11.so (gone)                                   | 3 ---
 .../libswt-cairo-gtk-4965r11.so (gone)                                 | 3 ---
 .../libswt-glx-gtk-4965r11.so (gone)                                   | 3 ---
 .../org.eclipse.swt.gtk.freebsd.aarch64/libswt-gtk-4965r11.so (gone)   | 3 ---
 .../libswt-pi3-gtk-4965r11.so (gone)                                   | 3 ---
 .../libswt-webkit-gtk-4965r11.so (gone)                                | 3 ---
 .../binaries/org.eclipse.swt.gtk.freebsd.powerpc64/build.properties    | 2 +-
 .../libswt-atk-gtk-4965r11.so (gone)                                   | 3 ---
 .../libswt-awt-gtk-4965r11.so (gone)                                   | 3 ---
 .../libswt-cairo-gtk-4965r11.so (gone)                                 | 3 ---
 .../libswt-glx-gtk-4965r11.so (gone)                                   | 3 ---
 .../org.eclipse.swt.gtk.freebsd.powerpc64/libswt-gtk-4965r11.so (gone) | 3 ---
 .../libswt-pi3-gtk-4965r11.so (gone)                                   | 3 ---
 .../libswt-webkit-gtk-4965r11.so (gone)                                | 3 ---
 .../binaries/org.eclipse.swt.gtk.freebsd.powerpc64le/build.properties  | 2 +-
 .../libswt-atk-gtk-4965r11.so (gone)                                   | 3 ---
 .../libswt-awt-gtk-4965r11.so (gone)                                   | 3 ---
 .../libswt-cairo-gtk-4965r11.so (gone)                                 | 3 ---
 .../libswt-glx-gtk-4965r11.so (gone)                                   | 3 ---
 .../libswt-gtk-4965r11.so (gone)                                       | 3 ---
 .../libswt-pi3-gtk-4965r11.so (gone)                                   | 3 ---
 .../libswt-webkit-gtk-4965r11.so (gone)                                | 3 ---
 .../binaries/org.eclipse.swt.gtk.freebsd.x86_64/build.properties       | 2 +-
 .../libswt-atk-gtk-4965r11.so (gone)                                   | 3 ---
 .../libswt-awt-gtk-4965r11.so (gone)                                   | 3 ---
 .../libswt-cairo-gtk-4965r11.so (gone)                                 | 3 ---
 .../libswt-glx-gtk-4965r11.so (gone)                                   | 3 ---
 .../org.eclipse.swt.gtk.freebsd.x86_64/libswt-gtk-4965r11.so (gone)    | 3 ---
 .../libswt-pi3-gtk-4965r11.so (gone)                                   | 3 ---
 .../libswt-webkit-gtk-4965r11.so (gone)                                | 3 ---
 32 files changed, 4 insertions(+), 88 deletions(-)
Comment 8 Norbert Grundmann 2024-09-20 05:18:00 UTC
(In reply to Vladimir Druzenko from comment #5)

Sorry, it may (was) not clear enough...  the part in Makefile

. for _SO in atk- glx- cairo- awt- "" pi3- webkit-
        ${TOUCH} ${WRKSRC}/eclipse.platform.swt/binaries/org.eclipse.swt.gtk.freebsd.${_ARCH}/libswt-${_SO}gtk-4965r11.so
. endfor

is not needed and can be deleted.  I removed all *.so files from the addons folders, because they are really obsolte - I did not know in the beginning.

And I will move the addons folder in near future to an external github project on my github site :-)

Cheers, Norbert