Created attachment 253718 [details] choclate-doom 3.1.0 WIP Hello, I've tried to update chocolate-doom to latest version, however at the staging I got hit by ===> Generating temporary packing list ninja: error: unknown target 'install/strip' *** Error code 1 could anybody lend me a hand here? Attaching a patch which shows what I had to change to get to this stage.
You changed gmake to cmake, but keep GNU_CONFIGURE - is it correct?
Created attachment 253724 [details] v1 Try this patch. Without migrate from configure/gmake to cmake.
WWW= https://www.chocolate-doom.org/
(In reply to Vladimir Druzenko from comment #2) Thanks very much for help! I've updated the WWW and pkg-message in v2. I don't think we need to force fluidsynth.
Created attachment 253733 [details] WWW, fluidsynth and pkg-message changes WWW, fluidsynth and pkg-message changes
(In reply to jakub_lach from comment #4) Port grab silently both fluidsynth and samplerate. I added options: OPTIONS_DEFINE= DOCS FLUIDSYNTH PNG SAMPLERATE OPTIONS_DEFAULT= FLUIDSYNTH PNG SAMPLERATE OPTIONS_SUB= yes DOCS_CONFIGURE_ENABLE= doc FLUIDSYNTH_LIB_DEPENDS= libfluidsynth.so:audio/fluidsynth FLUIDSYNTH_CONFIGURE_WITH= fluidsynth PNG_LIB_DEPENDS= libpng.so:graphics/png PNG_CONFIGURE_WITH= libpng SAMPLERATE_LIB_DEPENDS= libsamplerate.so:audio/libsamplerate SAMPLERATE_CONFIGURE_WITH= libsamplerate And remove mandatory: LIB_DEPENDS= libfluidsynth.so:audio/fluidsynth \ libpng.so:graphics/png \ libsamplerate.so:audio/libsamplerate Also fixed pkg-plist around docs: %%DOCS%%share/doc/chocolate-heretic/CMDLINE.heretic share/doc/chocolate-heretic/COPYING.md share/doc/chocolate-heretic/ChangeLog %%DOCS%%share/doc/chocolate-heretic/INSTALL.heretic %%DOCS%%share/doc/chocolate-heretic/NEWS.md share/doc/chocolate-heretic/PHILOSOPHY.md share/doc/chocolate-heretic/README.Music.md share/doc/chocolate-heretic/README.md %%DOCS%%share/doc/chocolate-hexen/CMDLINE.hexen share/doc/chocolate-hexen/COPYING.md share/doc/chocolate-hexen/ChangeLog %%DOCS%%share/doc/chocolate-hexen/INSTALL.hexen share/doc/chocolate-hexen/NEWS.md share/doc/chocolate-hexen/PHILOSOPHY.md share/doc/chocolate-hexen/README.Music.md share/doc/chocolate-hexen/README.md %%DOCS%%share/doc/chocolate-strife/CMDLINE.strife share/doc/chocolate-strife/COPYING.md share/doc/chocolate-strife/ChangeLog %%DOCS%%share/doc/chocolate-strife/INSTALL.strife share/doc/chocolate-strife/NEWS.md share/doc/chocolate-strife/PHILOSOPHY.md share/doc/chocolate-strife/README.Music.md share/doc/chocolate-strife/README.Strife.md share/doc/chocolate-strife/README.md share/icons/hicolor/128x128/apps/chocolate-doom.png share/icons/hicolor/128x128/apps/chocolate-heretic.png share/icons/hicolor/128x128/apps/chocolate-hexen.png share/icons/hicolor/128x128/apps/chocolate-setup.png share/icons/hicolor/128x128/apps/chocolate-strife.png %%DOCS%%share/man/man5/chocolate-doom.cfg.5.gz %%DOCS%%share/man/man5/chocolate-heretic.cfg.5.gz %%DOCS%%share/man/man5/chocolate-hexen.cfg.5.gz %%DOCS%%share/man/man5/chocolate-strife.cfg.5.gz %%DOCS%%share/man/man5/default.cfg.5.gz %%DOCS%%share/man/man5/heretic.cfg.5.gz %%DOCS%%share/man/man5/hexen.cfg.5.gz %%DOCS%%share/man/man5/strife.cfg.5.gz %%DOCS%%share/man/man6/chocolate-doom-setup.6.gz %%DOCS%%share/man/man6/chocolate-doom.6.gz %%DOCS%%share/man/man6/chocolate-heretic-setup.6.gz %%DOCS%%share/man/man6/chocolate-heretic.6.gz %%DOCS%%share/man/man6/chocolate-hexen-setup.6.gz %%DOCS%%share/man/man6/chocolate-hexen.6.gz %%DOCS%%share/man/man6/chocolate-server.6.gz %%DOCS%%share/man/man6/chocolate-strife-setup.6.gz %%DOCS%%share/man/man6/chocolate-strife.6.gz fluidsynth is small dependency - I suggest to keep it on by default.
(In reply to Vladimir Druzenko from comment #6) Ok, appreciated
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=0ad5676a980fc93d78bdf3053caf7ab40d47f97b commit 0ad5676a980fc93d78bdf3053caf7ab40d47f97b Author: jakub_lach <jakub_lach@mailplus.pl> AuthorDate: 2024-09-21 23:17:17 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-09-21 23:17:17 +0000 games/chocolate-doom: Update 3.0.1 → 3.1.0 Changelog: https://github.com/chocolate-doom/chocolate-doom/releases/tag/chocolate-doom-3.1.0 Improve port: - Add default options FLUIDSYNTH PNG SAMPLERATE to prevent silent grab - Disabling option DOCS prevents installation of man pages and documentation that are built during port building - Remove GNU_CONFIGURE_MANPREFIX - Pet portclippy PR: 281630 games/chocolate-doom/Makefile | 43 +++++++----- games/chocolate-doom/distinfo | 6 +- .../files/patch-src_d__iwad.c (gone) | 11 --- .../files/patch-src_hexen_mn__menu.c (gone) | 11 --- games/chocolate-doom/pkg-message | 6 ++ games/chocolate-doom/pkg-plist | 80 ++++++++++++---------- 6 files changed, 77 insertions(+), 80 deletions(-)
Thanks.
(In reply to Vladimir Druzenko from comment #9) Thank you!