Bug 281731 - [NEW PORT] sysutils/loaders-update: Tool that helps to update the bootcodes / loaders.
Summary: [NEW PORT] sysutils/loaders-update: Tool that helps to update the bootcodes /...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Many People
Assignee: Robert Clausecker
URL: https://github.com/emrion/uploaders/
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-26 17:40 UTC by Emrion
Modified: 2024-11-20 19:06 UTC (History)
2 users (show)

See Also:


Attachments
Patch for the port tree 2024/Q3, add loaders-update (1.56 KB, patch)
2024-09-26 17:40 UTC, Emrion
no flags Details | Diff
Patch for the port tree 2024/Q3, add loaders-update v1.0.1 (1.99 KB, patch)
2024-10-20 11:03 UTC, Emrion
no flags Details | Diff
Add loaders-update to the 2024Q3 ports branch (2.14 KB, patch)
2024-10-27 07:57 UTC, Emrion
no flags Details | Diff
Version 1.1.0 (1.20 KB, patch)
2024-11-20 19:06 UTC, Emrion
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emrion 2024-09-26 17:40:46 UTC
Created attachment 253835 [details]
Patch for the port tree 2024/Q3, add loaders-update
Comment 1 Emrion 2024-10-20 11:03:36 UTC
Created attachment 254393 [details]
Patch for the port tree 2024/Q3, add loaders-update v1.0.1

New version.
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2024-10-26 14:05:36 UTC
Patch looks reasonable.

 - please use PORTVERSION instead of DISTVERSION
 - please mark obsolete patches as obsolete as you upload a new patch
 - please extend pkg-descr to at least three lines; the text should
   give an explanation of the features and advantages of the port.

Please check these issues and resubmit.
Comment 3 Emrion 2024-10-26 16:08:48 UTC
(In reply to Robert Clausecker from comment #2)
Sorry, but I never used DISTVERSION. I always used PORTVERSION.
The previous patch has been tagged obsolete.
I will improve the pkg-descr and make a new patch soon.

Thanks.
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2024-10-26 16:12:42 UTC
(In reply to Emrion from comment #3)

Sorry, it's the other way round.  I messed up writing the comment.  You should use DISTVERSION over PORTVERSION unless DISTVERSION doesn't yield correct results (see ยง 5.2.2 Porter's Handbook).  I'll fix that on commit.
Comment 5 Emrion 2024-10-27 07:57:58 UTC
Created attachment 254555 [details]
Add loaders-update to the 2024Q3 ports branch

This is a new patch that adresses the issues you mentioned.

- DISTVERSION instead of PORTVERSION
- pkg-descr is 3 lines long.
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-10-28 12:45:04 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e5baa4d9c682a430a04a17f2d5b310721a21eeb3

commit e5baa4d9c682a430a04a17f2d5b310721a21eeb3
Author:     Emrion <kmachine@free.fr>
AuthorDate: 2024-10-27 07:47:57 +0000
Commit:     Robert Clausecker <fuz@FreeBSD.org>
CommitDate: 2024-10-28 12:42:08 +0000

    sysutils/loaders-update: update bootcode / loaders

    This utility is a tool designed to keep the FreeBSD bootcodes and loaders
    up-to-date.  It's useful because the FreeBSD upgrade process doesn't update
    them.  It verifies if they are up to date and updates them if desired.

    WWW: https://github.com/emrion/uploaders/

    PR:             281731

 sysutils/Makefile                       |  1 +
 sysutils/loaders-update/Makefile (new)  | 30 ++++++++++++++++++++++++++++++
 sysutils/loaders-update/distinfo (new)  |  3 +++
 sysutils/loaders-update/pkg-descr (new) |  4 ++++
 4 files changed, 38 insertions(+)
Comment 7 Robert Clausecker freebsd_committer freebsd_triage 2024-10-28 12:49:25 UTC
Thank you for your contribution.
Comment 8 Emrion 2024-10-28 18:41:59 UTC
(In reply to Robert Clausecker from comment #7)
Thanks for your patience and also your work for improving the Makefile.
I suppose that next time, I should use the head ports tree to make a patch. Recorded.
Comment 9 Emrion 2024-11-20 19:06:31 UTC
Created attachment 255328 [details]
Version 1.1.0

New version of loaders-update v1.1.0 (head ports).