Bug 281750 - devel/subversion{,-lts}: investigate issue with WITH_SUBVERSION_VER=lts instead of LTS
Summary: devel/subversion{,-lts}: investigate issue with WITH_SUBVERSION_VER=lts inste...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Joseph Mingrone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-28 08:40 UTC by Michael Osipov
Modified: 2024-10-04 19:25 UTC (History)
2 users (show)

See Also:

Attachments
Patch to add missing .include directive to devel/subversion/Makefile.addons (1.29 KB, patch)
2024-10-01 18:08 UTC, Joseph Mingrone 		no flags Details | Diff
Patch to add missing .include directive to devel/subversion/Makefile.addons (1.29 KB, patch)
2024-10-01 18:11 UTC, Joseph Mingrone 		jrm: maintainer-approval?
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Osipov freebsd_committer freebsd_triage 2024-09-28 08:40:26 UTC 
Reported by jrm@: https://reviews.freebsd.org/D46807#1067249
Comment 1 Michael Osipov freebsd_committer freebsd_triage 2024-10-01 10:42:42 UTC 
jrm@

Can you elaborate on that statement:
> FYI, when I was testing, I set WITH_SUBVERSION_VER to lts instead of LTS and it wasn't handled as would be expected after a look in devel/subversion/Makefile.addons.

I don't see what you expect from that Makefile?!
Comment 2 Joseph Mingrone freebsd_committer freebsd_triage 2024-10-01 18:08:08 UTC 
Created attachment 253938 [details]
Patch to add missing .include directive to devel/subversion/Makefile.addons
Comment 3 Joseph Mingrone freebsd_committer freebsd_triage 2024-10-01 18:08:45 UTC 
Hello Michael,

In short, when users set the value of WITH_SUBVERSION_VER to something other than 'latest' or 'LTS', they will encounter errors.

% make -C/usr/ports/devel/py-subversion -VPORTNAME
make: "/usr/ports/Mk/bsd.port.mk" line 1829: Malformed conditional (${ARCH} == "amd64")
        in /usr/share/mk/bsd.port.mk:27
        in /usr/share/mk/bsd.port.post.mk:4
        in /usr/ports/devel/py-subversion/Makefile:34
make: "/usr/ports/Mk/bsd.port.mk" line 1859: Malformed conditional (${WITH_PKG} == devel)
        in /usr/share/mk/bsd.port.mk:27
        in /usr/share/mk/bsd.port.post.mk:4
        in /usr/ports/devel/py-subversion/Makefile:34
...
...
...
make: "/usr/ports/Mk/bsd.port.mk" line 5555: Malformed conditional (${UID} != 0 && defined(_${:Upackage:tu}_REAL_SUSEQ) && !defined(INSTALL_AS_USER))
        in .for loop from /usr/ports/Mk/bsd.port.mk:5535 with target = package
        in /usr/share/mk/bsd.port.mk:27
        in /usr/share/mk/bsd.port.post.mk:4
        in /usr/ports/devel/py-subversion/Makefile:34
make: Fatal errors encountered -- cannot continue
make: stopped making "all" in /usr/ports/devel/py-subversion

The simplest solution is to add a missing .include directive.  See the attached patch.

Joe
Comment 4 Joseph Mingrone freebsd_committer freebsd_triage 2024-10-01 18:11:53 UTC 
Created attachment 253939 [details]
Patch to add missing .include directive to devel/subversion/Makefile.addons
Comment 5 Michael Osipov freebsd_committer freebsd_triage 2024-10-04 18:29:44 UTC 
(In reply to Joseph Mingrone from comment #4)

Now I understand, totally right. Good catch. Please go ahead and commit that patch!
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-10-04 18:43:00 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=009c251da4e078b2048d99c352a4d5b5c2c2b07b

commit 009c251da4e078b2048d99c352a4d5b5c2c2b07b
Author:     Joseph Mingrone <jrm@FreeBSD.org>
AuthorDate: 2024-10-01 17:53:46 +0000
Commit:     Joseph Mingrone <jrm@FreeBSD.org>
CommitDate: 2024-10-04 18:32:45 +0000

    devel/subversion/Makefile.addons: Add missing .include

    Users who incorrectly set WITH_SUBVERSION_VER to something other than
    latest or LTS encounter errors.

    make -C/usr/ports/devel/py-subversion -VPORTNAME
    make: "/usr/ports/Mk/bsd.port.mk" line 1829: Malformed conditional (${ARCH} == "amd64")
            in /usr/share/mk/bsd.port.mk:27
            in /usr/share/mk/bsd.port.post.mk:4
            in /usr/ports/devel/py-subversion/Makefile:34
    ...

    Resolve these errors by adding a missing .include directive.

    PR:             281750
    Sponsored by:   The FreeBSD Foundation
    Differential Revision:  https://reviews.freebsd.org/D46807

 devel/subversion/Makefile.addons | 1 +
 1 file changed, 1 insertion(+)
Comment 7 Michael Osipov freebsd_committer freebsd_triage 2024-10-04 19:25:03 UTC 
(In reply to commit-hook from comment #6)

Fix appreciated!