Bug 281974 - x11-toolkits/mygui: fix build with libc++ 19
Summary: x11-toolkits/mygui: fix build with libc++ 19
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks: 280562
  Show dependency treegraph
 
Reported: 2024-10-09 18:59 UTC by Dimitry Andric
Modified: 2024-10-26 11:09 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (amdmi3)


Attachments
x11-toolkits/mygui: fix build with libc++ 19 (2.47 KB, patch)
2024-10-09 19:04 UTC, Dimitry Andric
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2024-10-09 18:59:43 UTC
As noted in the libc++ 19 release notes [1], std::char_traits<> is now
only provided for char, char8_t, char16_t, char32_t and wchar_t, and any
instantiation for other types will fail.

This causes x11-toolkits/mygui to fail to compile with clang 19 and
libc++ 19, resulting in errors similar to:

  In file included from /wrkdirs/usr/ports/x11-toolkits/mygui/work/mygui-MyGUI3.4.2/MyGUIEngine/include/MyGUI_Common.h:12:
  /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned short>'
    820 |   static_assert(is_same<_CharT, typename traits_type::char_type>::value,
   y     |                                          ^
  /wrkdirs/usr/ports/x11-toolkits/mygui/work/mygui-MyGUI3.4.2/MyGUIEngine/include/MyGUI_UString.h:213:4: note: in instantiation of template class 'std::basic_string<unsigned short>' requested here
    213 |                         dstring::iterator mIter;
        |                         ^
  /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here
     23 | struct _LIBCPP_TEMPLATE_VIS char_traits;
        |                             ^

These can be fixed by using `char16_t` instead of `uint16_t` for the
`code_point` type, and `char32_t` instead of `uint32_t` for the
`unicode_char` type.

[1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2024-10-09 19:04:26 UTC
Created attachment 254120 [details]
x11-toolkits/mygui: fix build with libc++ 19
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-10-26 11:08:44 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2e294149c6682f1a8cb384d0e36a14b12b9c3e35

commit 2e294149c6682f1a8cb384d0e36a14b12b9c3e35
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-10-08 09:08:59 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-10-26 11:06:23 +0000

    x11-toolkits/mygui: fix build with libc++ 19

    As noted in the libc++ 19 release notes [1], std::char_traits<> is now
    only provided for char, char8_t, char16_t, char32_t and wchar_t, and any
    instantiation for other types will fail.

    This causes x11-toolkits/mygui to fail to compile with clang 19 and
    libc++ 19, resulting in errors similar to:

      In file included from /wrkdirs/usr/ports/x11-toolkits/mygui/work/mygui-MyGUI3.4.2/MyGUIEngine/include/MyGUI_Common.h:12:
      /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned short>'
        820 |   static_assert(is_same<_CharT, typename traits_type::char_type>::value,
       y     |                                          ^
      /wrkdirs/usr/ports/x11-toolkits/mygui/work/mygui-MyGUI3.4.2/MyGUIEngine/include/MyGUI_UString.h:213:4: note: in instantiation of template class 'std::basic_string<unsigned short>' requested here
        213 |                         dstring::iterator mIter;
            |                         ^
      /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here
         23 | struct _LIBCPP_TEMPLATE_VIS char_traits;
            |                             ^

    These can be fixed by using `char16_t` instead of `uint16_t` for the
    `code_point` type, and `char32_t` instead of `uint32_t` for the
    `unicode_char` type.

    [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals

    PR:             281974
    Approved by:    maintainer timeout (2 weeks)
    MFH:            2024Q4

 .../patch-MyGUIEngine_include_MyGUI__UString.h (new)      | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-10-26 11:08:45 UTC
A commit in branch 2024Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7337e5d55caf016095c2523bc26892666cc373c0

commit 7337e5d55caf016095c2523bc26892666cc373c0
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2024-10-08 09:08:59 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2024-10-26 11:08:03 +0000

    x11-toolkits/mygui: fix build with libc++ 19

    As noted in the libc++ 19 release notes [1], std::char_traits<> is now
    only provided for char, char8_t, char16_t, char32_t and wchar_t, and any
    instantiation for other types will fail.

    This causes x11-toolkits/mygui to fail to compile with clang 19 and
    libc++ 19, resulting in errors similar to:

      In file included from /wrkdirs/usr/ports/x11-toolkits/mygui/work/mygui-MyGUI3.4.2/MyGUIEngine/include/MyGUI_Common.h:12:
      /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned short>'
        820 |   static_assert(is_same<_CharT, typename traits_type::char_type>::value,
       y     |                                          ^
      /wrkdirs/usr/ports/x11-toolkits/mygui/work/mygui-MyGUI3.4.2/MyGUIEngine/include/MyGUI_UString.h:213:4: note: in instantiation of template class 'std::basic_string<unsigned short>' requested here
        213 |                         dstring::iterator mIter;
            |                         ^
      /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here
         23 | struct _LIBCPP_TEMPLATE_VIS char_traits;
            |                             ^

    These can be fixed by using `char16_t` instead of `uint16_t` for the
    `code_point` type, and `char32_t` instead of `uint32_t` for the
    `unicode_char` type.

    [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals

    PR:             281974
    Approved by:    maintainer timeout (2 weeks)
    MFH:            2024Q4

    (cherry picked from commit 2e294149c6682f1a8cb384d0e36a14b12b9c3e35)

 .../patch-MyGUIEngine_include_MyGUI__UString.h (new)      | 15 +++++++++++++++
 1 file changed, 15 insertions(+)