Bug 282527 - graphics/ogre3d19: fix build with libc++ 19
Summary: graphics/ogre3d19: fix build with libc++ 19
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks: 280562
  Show dependency treegraph
 
Reported: 2024-11-03 22:59 UTC by Dimitry Andric
Modified: 2024-11-08 16:07 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (amdmi3)


Attachments
graphics/ogre3d19: fix build with libc++ 19 (2.32 KB, patch)
2024-11-03 23:00 UTC, Dimitry Andric
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2024-11-03 22:59:28 UTC
As noted in the libc++ 19 release notes [1], std::char_traits<> is now
only provided for char, char8_t, char16_t, char32_t and wchar_t, and any
instantiation for other types will fail.

This causes graphics/ogre3d19 to fail to compile with clang 19 and
libc++ 19, resulting in errors similar to:

  /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits<unsigned short>'
    820 |   static_assert(is_same<_CharT, typename traits_type::char_type>::value,
        |                                          ^
  /wrkdirs/usr/ports/graphics/ogre3d19/work/sinbad-ogre-dd30349ea667/OgreMain/include/OgreUTFString.h:234:4: note: in instantiation of template class 'std::basic_string<unsigned short>' requested here
    234 |                         dstring::iterator mIter;
        |                         ^
  /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here
     23 | struct _LIBCPP_TEMPLATE_VIS char_traits;
        |                             ^

This can be fixed by defining `unicode_char` as `char32_t` instead of
`uint32`, and `code_point` as `char16_t` instead of `uint16` in
`OgreUTFString.h`.

[1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2024-11-03 23:00:35 UTC
Created attachment 254922 [details]
graphics/ogre3d19: fix build with libc++ 19
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-11-08 16:07:54 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=da8138aa53e8f11947a37cef7eb2d874fd3370e6

commit da8138aa53e8f11947a37cef7eb2d874fd3370e6
Author:     Dmitry Marakasov <amdmi3@FreeBSD.org>
AuthorDate: 2024-11-08 15:35:45 +0000
Commit:     Dmitry Marakasov <amdmi3@FreeBSD.org>
CommitDate: 2024-11-08 15:35:45 +0000

    graphics/ogre3d19: fix build with libc++ 19

    PR:             282527
    Submitted by:   dim

 .../files/patch-OgreMain_include_OgreUTFString.h (new)    | 15 +++++++++++++++
 1 file changed, 15 insertions(+)