Bug 282570 - devel/libqb: Fix port
Summary: devel/libqb: Fix port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-05 19:04 UTC by Daniel Engberg
Modified: 2024-11-05 22:19 UTC (History)
2 users (show)

See Also:
alster: maintainer-feedback+
alster: merge-quarterly?


Attachments
Patch for libqb (2.53 KB, patch)
2024-11-05 19:04 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-11-05 19:04:45 UTC
Created attachment 254972 [details]
Patch for libqb

* Remove BUILD_DEPENDS hack, these will be a pain to fix if sprinkled all over the tree
* Remove Python dependency
* Add USES= pathfix
* Remove LDFLAGS variable (builds fine without)
* Fix build with DOXYGEN disabled
* Rearrage port for better readability

Poudriere testport OK 14.1-RELEASE (amd64)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-11-05 19:06:36 UTC
..forgot to add

* Use gnome helper for libxml2
Comment 2 Älven 2024-11-05 19:34:13 UTC
Comment on attachment 254972 [details]
Patch for libqb

Thank you! Your improvement of this port is more significant than mine. You know it much better. It should be you, not me as a real maintainer of it :)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-11-05 20:17:52 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ca513743832b301e1bd80e83d27d845020bfba8e

commit ca513743832b301e1bd80e83d27d845020bfba8e
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-11-05 19:57:09 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-11-05 20:17:24 +0000

    devel/libqb: Fix build and improve port

    * Remove BUILD_DEPENDS hack, these will be a pain to fix if sprinkled all over the tree
    * Remove Python dependency
    * Add USES= pathfix
    * Remove LDFLAGS variable (builds fine without)
    * Fix build with DOXYGEN disabled
    * Use gnome helper for libxml2
    * Rearrage port for better readability

    PR:             282570
    Reviewed by:    Älven <alster@vinterdalen.se> (maintainer)

 devel/libqb/Makefile                       | 36 ++++++++++++++----------------
 devel/libqb/files/patch-configure.ac (new) | 13 +++++++++++
 2 files changed, 30 insertions(+), 19 deletions(-)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2024-11-05 20:30:36 UTC
Committed, thanks!
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2024-11-05 22:19:00 UTC
(In reply to Daniel Engberg from comment #4)
MFH 2024Q4?