Created attachment 255102 [details] simplify port The following changes are made to simplify the port: * remove unnecessary localbase from USES * promote unbundled utf8cpp include path to CMakeLists.txt instead of replacing C include directive in ${WRKSRC}/es-core/utils/StringUtil.h * use CMake's modules for finding unbundled RapidJSON and rlottie package * this allows to remove the INCLUDE_DIRS for both libraries (CMake already does the right thing when using find_package) * replace rlottie_LINK_LIBRARIES with the more proper rlottie_LIBRARIES
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=9c26b7dfb8ba801430daf3c364b86e6284857b70 commit 9c26b7dfb8ba801430daf3c364b86e6284857b70 Author: Stefan Schlosser <bsdcode@disroot.org> AuthorDate: 2024-11-12 18:29:13 +0000 Commit: Zsolt Udvari <uzsolt@FreeBSD.org> CommitDate: 2024-11-12 18:31:16 +0000 emulators/es-de: Simplify port Remove unnecessary localbase from USES. Promote unbundled utf8cpp include path to CMakeLists.txt instead of replacing C include directive in ${WRKSRC}/es-core/utils/StringUtil.h. Use CMake's modules for finding unbundled RapidJSON and rlottie package. This allows to remove the INCLUDE_DIRS for both libraries (CMake already does the right thing when using find_package). Replace rlottie_LINK_LIBRARIES with the more proper rlottie_LIBRARIES. PR: 282698 Approved by: submitter is maintainer emulators/es-de/Makefile | 15 ++++++--------- emulators/es-de/files/patch-CMakeLists.txt | 26 ++++++++------------------ 2 files changed, 14 insertions(+), 27 deletions(-)
Committed, thanks!