Bug 282725 (cmake-3.31.0) - [exp-run] devel/cmake: Update to 3.31.0
Summary: [exp-run] devel/cmake: Update to 3.31.0
Status: Closed FIXED
Alias: cmake-3.31.0
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason E. Hale
URL: https://people.freebsd.org/~jhale/pat...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-13 09:11 UTC by Jason E. Hale
Modified: 2024-11-17 23:02 UTC (History)
1 user (show)

See Also:
antoine: exp-run+


Attachments
v1 (55.18 KB, patch)
2024-11-13 09:11 UTC, Jason E. Hale
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason E. Hale freebsd_committer freebsd_triage 2024-11-13 09:11:05 UTC
Created attachment 255135 [details]
v1

Moin moin!

kde@ would like to ask for an exp-run to update devel/cmake and friends to 3.31.0.

Patch is attached and can also be found here: https://people.freebsd.org/~jhale/patches/0001-devel-cmake-Update-to-3.31.0.patch
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-11-17 12:47:43 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=65282872b7e34c008ca3448412055b589120807a

commit 65282872b7e34c008ca3448412055b589120807a
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-11-17 12:09:45 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-11-17 12:47:22 +0000

    devel/allegro: Fix build with CMake >= 3.31.0

    For some reason, the check for XDGAQueryExtension in Xxf86dga was
    failing in previous versions of CMake, but it now succeeds, which is the
    expected result. It's an oversimplified check, however, that just adds
    the library name without path if found.

    Just using raw data from pkg_check_modules() results in a similar
    problem, which this project does. The ALSA option already had the
    usual workaround for this scenario (USES+=localbase:ldflags) in place,
    but the JACK option did not. Build would fail if the JACK option was
    enabled, but not ALSA even in previous versions of CMake.

    This version of allegro is ancient, so just elevate the workaround
    to the port level.

    PR:             282725

 devel/allegro/Makefile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Comment 3 Jason E. Hale freebsd_committer freebsd_triage 2024-11-17 13:38:09 UTC
Thanks, Antoine! devel/allegro is fixed. Skipped ports that build with CMake (games/opensonic, games/opensurge, graphics/aseprite) were tested with no regressions.
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-11-17 22:59:58 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4263e3aac0c0c3230eb75ddc8dc5229eae67fcd4

commit 4263e3aac0c0c3230eb75ddc8dc5229eae67fcd4
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2024-11-13 08:38:26 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2024-11-17 22:58:51 +0000

    devel/cmake*: Update to 3.31.0

    devel/cmake-gui: Convert to out-of-source build

    Announcement:
    https://www.kitware.com/cmake-3-31-0-available-for-download/

    Release notes:
    https://cmake.org/cmake/help/latest/release/3.31.html

    PR:             282725
    Exp-run by:     antoine

 Mk/Uses/cmake.mk                                   |   2 +-
 devel/cmake-core/distinfo                          |   6 +-
 .../cmake-core/files/patch-Modules_FindBoost.cmake |   8 +-
 devel/cmake-core/files/patch-Modules_FindSDL.cmake |   4 +-
 .../files/patch-Modules_GNUInstallDirs.cmake       |   4 +-
 .../files/patch-Modules_Platform_FreeBSD.cmake     |   8 +-
 .../patch-Source_cmBinUtilsLinuxELFLinker.cxx      |  20 +-
 devel/cmake-core/pkg-plist                         | 305 ++++++++++++++++++++-
 devel/cmake-doc/Makefile                           |   2 +-
 devel/cmake-doc/pkg-plist                          |  60 ++++
 devel/cmake-gui/Makefile                           |  14 +-
 devel/cmake-man/Makefile                           |   2 +-
 12 files changed, 400 insertions(+), 35 deletions(-)