Bug 282875 - net-p2p/litecoin fix build with boost-libs 1.85+
Summary: net-p2p/litecoin fix build with boost-libs 1.85+
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-20 14:31 UTC by adrian
Modified: 2024-11-21 09:33 UTC (History)
1 user (show)

See Also:
hsw: maintainer-feedback+

Attachments
fix function calls instead of using BOOST_FILESYSTEM_NO_DEPRECATED (1.66 KB, text/plain)
2024-11-20 14:31 UTC, adrian 		no flags Details
patch-src_wallet_bdb.cpp (562 bytes, patch)
2024-11-20 14:37 UTC, adrian 		no flags Details | Diff
patch-src_wallet_walletutil.cpp (1.08 KB, patch)
2024-11-20 14:38 UTC, adrian 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description adrian 2024-11-20 14:31:41 UTC 
Created attachment 255324 [details]
fix function calls instead of using BOOST_FILESYSTEM_NO_DEPRECATED
Comment 1 adrian 2024-11-20 14:37:40 UTC 
Created attachment 255325 [details]
patch-src_wallet_bdb.cpp

fix function calls instead of using BOOST_FILESYSTEM_NO_DEPRECATED
Comment 2 adrian 2024-11-20 14:38:19 UTC 
Created attachment 255326 [details]
patch-src_wallet_walletutil.cpp
Comment 3 Christopher Hall 2024-11-21 02:35:27 UTC 
Looks good to me
Comment 4 Christopher Hall 2024-11-21 02:38:16 UTC 
Looks goot to me
Comment 5 Christopher Hall 2024-11-21 02:41:10 UTC 
I was not able to set maintainer approval on the two patches, but only on the flags at the top, hopefully that is enough to approve this fix.

Thanks you for the fix Adrian.
Comment 6 adrian 2024-11-21 08:41:19 UTC 
(In reply to Christopher Hall from comment #5)

well, maybe I did something wrong. I just left the default (X) because none of those maintainer-flags labels made sense: "X", "+", "-", "?". 

It seems that I can edit the maintainer-flags on attachments, should I set to something else, like "? <your email address>" to request your approval (why isn't this the default if required, beats me)? 
The other flags really don't make sense from my perspective, unless default/none.

Sorry for the trouble.

Thank you,
Adrian
Comment 7 Christopher Hall 2024-11-21 09:33:48 UTC 
according to this https://www.bugzilla.org/docs/2.18/html/flags-overview.html

looks like you should set '?' to ask for approval then I can set '+' for accept or '-' for reject.

It has been a long time since I used bugs, I did most previous updates via reviews, so I forgot how the flags work.