Bug 282898 - comms/aldo: update 0.7.7 → 0.7.8
Summary: comms/aldo: update 0.7.7 → 0.7.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: hamradio (Nobody)
URL: https://git.savannah.nongnu.org/cgit/...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-21 20:58 UTC by Älven
Modified: 2025-01-27 20:31 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (lambert)


Attachments
[PATCH] comms/aldo: update 0.7.7 → 0.7.8 (5.13 KB, patch)
2024-11-21 20:58 UTC, Älven
alster: maintainer-approval? (lambert)
Details | Diff
[MISSED][PATCH] comms/aldo: update 0.7.7 → 0.7.8 (3.26 KB, patch)
2025-01-23 12:07 UTC, Älven
alster: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Älven 2024-11-21 20:58:32 UTC
Created attachment 255365 [details]
[PATCH] comms/aldo: update 0.7.7 → 0.7.8
Comment 1 Diane Bruce freebsd_committer freebsd_triage 2024-11-22 18:59:55 UTC
Looks good. I'll approve and commit.
Comment 2 Diane Bruce freebsd_committer freebsd_triage 2024-11-22 19:43:54 UTC
My mistake. Scott is the Maintainer but if someone could add what was changed so that can be put in the commit log that would be good. 
I'll wait until we get Scott's approval.
Comment 3 Älven 2024-11-22 20:42:19 UTC
Possible changeset message may be:

* Switch MASTER_SITES to git snapshots from GNU Savannah 
* Add second WWW for source code origin
* Correct the LICENSE to GNU GPLv2+, as stated on site and in file headers
* Switch from gmake to autoreconf+make
* Remove GNU_CONFIGURE_MANPREFIX as it's a default value from <bsd.port.mk>
* Patch configure.ac for new version of the program
* Improve pkg-descr

Also, committers usually know better what to write there and almost always do this to their own like anyway.
Comment 4 Scott Lambert 2024-11-23 17:34:41 UTC
I haven't even looked at this for a couple of years.  I have no objection if someone else wants to take maintainership.
Comment 5 Älven 2024-11-23 22:34:14 UTC
The port seems to be not difficult to maintain, so I may try and hope I could do it. And what would Diana say?
Comment 6 Älven 2024-11-23 22:35:27 UTC
s/Diana/Diane/
I'm sorry.
Comment 7 Diane Bruce freebsd_committer freebsd_triage 2024-11-24 23:41:25 UTC
(In reply to Älven from comment #5)
I think this is a grand idea. Seeing as Scott has already decided to stop maintaining I think I can just change Maintainer. I think. I'll check I hope we don't need another PR to do it.
Comment 8 Diane Bruce freebsd_committer freebsd_triage 2024-11-24 23:41:58 UTC
(In reply to Älven from comment #6)
heh Don't worry about it!
Comment 9 commit-hook freebsd_committer freebsd_triage 2025-01-17 19:02:29 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=98ec15bd966d6ff201e97c433109d328e8457dbb

commit 98ec15bd966d6ff201e97c433109d328e8457dbb
Author:     Diane Bruce <db@FreeBSD.org>
AuthorDate: 2025-01-17 18:57:38 +0000
Commit:     Diane Bruce <db@FreeBSD.org>
CommitDate: 2025-01-17 19:02:18 +0000

    comms/aldo: Updated to new version and changed Maintainer

    * Switch MASTER_SITES to git snapshots from GNU Savannah
    * Add second WWW for source code origin
    * Correct the LICENSE to GNU GPLv2+, as stated on site and in file headers
    * Switch from gmake to autoreconf+make
    * Remove GNU_CONFIGURE_MANPREFIX as it's a default value from <bsd.port.mk>
    * Patch configure.ac for new version of the program
    * Improve pkg-descr

    * As per request of Scott Lambert and with agreement of  Älven
      Älven  now has MAINTAINERSHIP see PR for more details

    PR:             ports/282898

 comms/aldo/Makefile  | 16 ++++++++--------
 comms/aldo/distinfo  |  6 +++---
 comms/aldo/pkg-descr | 17 ++++++++++++++---
 3 files changed, 25 insertions(+), 14 deletions(-)
Comment 10 Diane Bruce freebsd_committer freebsd_triage 2025-01-17 19:03:18 UTC
Apologies it took me so long! Over the holidays and I've been busy.
Comment 11 Älven 2025-01-17 21:38:23 UTC
I appreciate you still took some time to review and commit my patch. Thank you!
Comment 12 Älven 2025-01-23 12:07:50 UTC
Created attachment 256928 [details]
[MISSED][PATCH] comms/aldo: update 0.7.7 → 0.7.8

Some changes from original patch weren't included in the commit.
Comment 13 Älven 2025-01-23 12:08:11 UTC
Missed changes from original patch.
Comment 14 commit-hook freebsd_committer freebsd_triage 2025-01-27 20:31:15 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=96e7c8e5fba1b061b7942fbcfb3d22d52263b5a1

commit 96e7c8e5fba1b061b7942fbcfb3d22d52263b5a1
Author:     Älven <alster@vinterdalen.se>
AuthorDate: 2025-01-27 20:28:34 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-01-27 20:28:34 +0000

    comms/aldo: Add missed patches during update 0.7.7 → 0.7.8

    PR:     284281 282898
    Fixes:  98ec15bd966d (Updated to new version and changed Maintainer)

 comms/aldo/Makefile                               |  1 -
 comms/aldo/files/patch-VERSION (new)              |  6 ++++
 comms/aldo/files/patch-configure (gone)           | 12 --------
 comms/aldo/files/patch-configure.ac (new)         | 36 +++++++++++++++++++++++
 comms/aldo/files/patch-include_Makefile.in (gone) | 11 -------
 5 files changed, 42 insertions(+), 24 deletions(-)