Created attachment 255789 [details] lsblk.diff 3.8 => 3.9 Hi. Please update 'sysutils/lsblk' port to 3.9 with attached DIFF. Changelog Between 3.8 and 3.9 ----------------------------- - Improve searching for glabel(8) label. - Improve handling label from gpart(8) output. - Replace long Microsoft partition names to something reasonable. - Improve exFAT handling. - Improve size handling form md(4) disks. - Remove redundant spaces from labels. - Add TOTAL SYSTEM STORAGE for -d option. - Remove subshell for main devices check loop. Thank You, vermaden
Created attachment 255798 [details] lsblk.diff 3.8 => 3.9
Created attachment 255841 [details] add LICENSE Would be nice to add LICENSE_FILE (see https://docs.freebsd.org/en/books/porters-handbook/book/#licenses-license).
(In reply to Zsolt Udvari from comment #2) I believe its already specified? % grep LIC /usr/ports/sysutils/lsblk/Makefile /usr/ports/sysutils/lsblk.orig/Makefile /usr/ports/sysutils/lsblk/Makefile:LICENSE= BSD2CLAUSE /usr/ports/sysutils/lsblk.orig/Makefile:LICENSE= BSD2CLAUSE
(In reply to Slawomir Wojciech Wojtczak from comment #3) Yes, sorry. I wanted write LICENSE_FILE.
(In reply to Zsolt Udvari from comment #4) Why there is LICENSE_FILE needed when BSD2CLAUSE is established since ages and known to World license - same as GPL2 or AGPL? I agree that if I would introduce 'mine-own-created' license - then this file would be useful - but not with BSD2CLAUSE license ...
(In reply to Slawomir Wojciech Wojtczak from comment #5) The Porter's Handbook says in Example 32 (near https://docs.freebsd.org/en/books/porters-handbook/book/#licenses-license): When the software provides the license file, use this: LICENSE= LGPL21+ LICENSE_FILE= ${WRKSRC}/COPYING Your license file contains a year and your name too.
(In reply to Zsolt Udvari from comment #6) So what do you want me to do here?
(In reply to Slawomir Wojciech Wojtczak from comment #7) If you accept (as maintainer) I commit it. That's all :)
(In reply to Zsolt Udvari from comment #8) I accept. Please commit :)
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a4504275b869768b1976d33b9f4d140f4f89cdfa commit a4504275b869768b1976d33b9f4d140f4f89cdfa Author: Slawomir Wojciech Wojtczak <vermaden@interia.pl> AuthorDate: 2024-12-21 14:09:16 +0000 Commit: Zsolt Udvari <uzsolt@FreeBSD.org> CommitDate: 2024-12-21 14:11:00 +0000 sysutils/lsblk: Update to 3.9 Add LICENSE_FILE. Changelog Between 3.8 and 3.9: - Improve searching for glabel(8) label. - Improve handling label from gpart(8) output. - Replace long Microsoft partition names to something reasonable. - Improve exFAT handling. - Improve size handling form md(4) disks. - Remove redundant spaces from labels. - Add TOTAL SYSTEM STORAGE for -d option. - Remove subshell for main devices check loop. PR: 283268 Approved by: submitter is maintainer sysutils/lsblk/Makefile | 10 ++++++++-- sysutils/lsblk/distinfo | 8 +++++--- 2 files changed, 13 insertions(+), 5 deletions(-)
(In reply to Slawomir Wojciech Wojtczak from comment #9) Committed, thanks!
Re: bug 262869 comment 14 Better now, thanks: % lsblk /dev/da0 DEVICE MAJ:MIN SIZE TYPE LABEL MOUNT da0 0:137 3.7G GPT - - <FREE> -:- 47K - - - da0p1 0:140 3.7G ms-basic-data gpt/ms-basic-data /media/Basic_data_partition <FREE> -:- 1.5M - - - % su - Password: root@mowa219-gjp4-zbook-freebsd:~ # umount /media/Basic_data_partition root@mowa219-gjp4-zbook-freebsd:~ # gdisk /dev/da0 GPT fdisk (gdisk) version 1.0.10 Partition table scan: MBR: protective BSD: not present APM: not present GPT: present Found valid GPT with protective MBR; using GPT. Command (? for help): q root@mowa219-gjp4-zbook-freebsd:~ # Not mentioned yesterday: gdisk detected (at run time) and allowed me to fix an issue affecting … the protective MBR, IIRC.
(In reply to Zsolt Udvari from comment #11) Thank You!
(In reply to Graham Perrin from comment #12) Thanks for checking.