Bug 283377 - devel/{py-oci,oci-cli}: update to 2.141.0 / 3.51.0
Summary: devel/{py-oci,oci-cli}: update to 2.141.0 / 3.51.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://github.com/oracle/oci-python-...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-17 08:33 UTC by Alessandro Sagratini
Modified: 2024-12-19 09:04 UTC (History)
2 users (show)

See Also:
linimon: maintainer-feedback+


Attachments
trivial update of Makefile and distinfo (2.70 KB, patch)
2024-12-17 08:33 UTC, Alessandro Sagratini
ale_sagra: maintainer-approval+
Details | Diff
trivial update of Makefile and distinfo: I am also renaming oci-cli to oci_cli (3.45 KB, patch)
2024-12-19 07:04 UTC, Alessandro Sagratini
no flags Details | Diff
0001-devel-oci-cli.patch (1.67 KB, patch)
2024-12-19 08:41 UTC, Koichiro Iwao
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alessandro Sagratini 2024-12-17 08:33:58 UTC
Created attachment 255910 [details]
trivial update of Makefile and distinfo

* oci-cli Changelog: https://github.com/oracle/oci-cli/releases/tag/v3.51.0
* py-oci Changelog: https://github.com/oracle/oci-python-sdk/releases/tag/v2.141.0
Comment 1 Koichiro Iwao freebsd_committer freebsd_triage 2024-12-18 09:03:47 UTC
oci-cli-3.51.0.tar.gz is not availble. 

===>  License APACHE20 UPL accepted by the user
===>   py311-oci-cli-3.51.0 depends on file: /usr/local/sbin/pkg - found
=> oci-cli-3.51.0.tar.gz doesn't seem to exist in /home/meta/FreeBSD/ports/git/distfiles/.
=> Attempting to fetch http://distcache.FreeBSD.org/ports-distfiles/oci-cli-3.51.0.tar.gz
fetch: http://distcache.FreeBSD.org/ports-distfiles/oci-cli-3.51.0.tar.gz: Not Found
=> Attempting to fetch https://files.pythonhosted.org/packages/source/o/oci-cli/oci-cli-3.51.0.tar.gz
fetch: https://files.pythonhosted.org/packages/source/o/oci-cli/oci-cli-3.51.0.tar.gz: Not Found
=> Attempting to fetch https://pypi.org/packages/source/o/oci-cli/oci-cli-3.51.0.tar.gz
fetch: https://pypi.org/packages/source/o/oci-cli/oci-cli-3.51.0.tar.gz: Not Found
=> Couldn't fetch it - please try to retrieve this
Comment 2 Alessandro Sagratini 2024-12-18 10:33:16 UTC
Hello @meta,
what I found out is that oci-cli has been renamed upstream to oci_cli, with an underscore: any objections to renaming the port accordingly? It sohuld be pyXX-oci_cli instead of pyXX-oci-cli

Thank you,
Alessandro
Comment 3 Alessandro Sagratini 2024-12-18 12:48:10 UTC
the project being renamed happened from 3.50.2 and 3.50.3 versions:
https://pypi.org/project/oci-cli/3.50.2/#files
https://pypi.org/project/oci-cli/3.50.3/#files
Comment 4 Koichiro Iwao freebsd_committer freebsd_triage 2024-12-19 05:43:15 UTC
(In reply to Alessandro Sagratini from comment #2)
IMO, we need not to rename the port right now but we can fetch underscored tarball.
Comment 5 Alessandro Sagratini 2024-12-19 07:04:12 UTC
Created attachment 255945 [details]
trivial update of Makefile and distinfo: I am also renaming oci-cli to oci_cli

Thanks Koichiro! I uploaded a new patch to also rename oci-cli to oci_cli, let me know if you have any feedback
Comment 6 Koichiro Iwao freebsd_committer freebsd_triage 2024-12-19 08:03:39 UTC
Suck, upstream uses underscore for tarball but the directory inside tarball still uses hyphen. I'll try to address, leave it to me.

% tar ztf /usr/ports/distfiles/oci_cli-3.51.0.tar.gz | head
oci-cli-3.51.0/
oci-cli-3.51.0/THIRD_PARTY_LICENSES.txt
oci-cli-3.51.0/src/
oci-cli-3.51.0/src/oci_cli/
oci-cli-3.51.0/src/oci_cli/util/
oci-cli-3.51.0/src/oci_cli/util/pymd5.py
oci-cli-3.51.0/src/oci_cli/util/__init__.py
Comment 7 Koichiro Iwao freebsd_committer freebsd_triage 2024-12-19 08:41:02 UTC
Created attachment 255946 [details]
0001-devel-oci-cli.patch

Here, it addresses the odd upstream naming of the tarball without renaming the port. This patch applies to your first patch. What do you think?
Comment 8 Alessandro Sagratini 2024-12-19 08:46:22 UTC
Comment on attachment 255946 [details]
0001-devel-oci-cli.patch

it looks good, thanks!
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-12-19 09:03:00 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=144615400f7cfcfa8fcfe1f2063cbb23b57c3fb9

commit 144615400f7cfcfa8fcfe1f2063cbb23b57c3fb9
Author:     Alessandro Sagratini <alessandro.sagratini@gmail.com>
AuthorDate: 2024-12-17 08:32:06 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2024-12-19 08:59:12 +0000

    devel/{py-oci,oci-cli}: update to 2.141.0 / 3.51.0

    PR:             283377

 devel/oci-cli/Makefile | 4 ++--
 devel/oci-cli/distinfo | 6 +++---
 devel/py-oci/Makefile  | 2 +-
 devel/py-oci/distinfo  | 6 +++---
 4 files changed, 9 insertions(+), 9 deletions(-)
Comment 10 commit-hook freebsd_committer freebsd_triage 2024-12-19 09:03:01 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=67bfbfb425d7ae1bb4febb9bdc5260775fc12517

commit 67bfbfb425d7ae1bb4febb9bdc5260775fc12517
Author:     Koichiro Iwao <meta@FreeBSD.org>
AuthorDate: 2024-12-19 08:35:30 +0000
Commit:     Koichiro Iwao <meta@FreeBSD.org>
CommitDate: 2024-12-19 08:59:12 +0000

    devel/oci-cli: address the odd upstream naming of the tarball

    PR:             283377
    Approved by:    Alessandro Sagratini (maintainer)

 devel/oci-cli/Makefile | 7 +++++++
 devel/oci-cli/distinfo | 6 +++---
 2 files changed, 10 insertions(+), 3 deletions(-)
Comment 11 Koichiro Iwao freebsd_committer freebsd_triage 2024-12-19 09:04:45 UTC
Committed with minor modifications, thanks!