Bug 283410 - [exp-run] stable/14: cred: Hide internal flag CRED_FLAG_CAPMODE
Summary: [exp-run] stable/14: cred: Hide internal flag CRED_FLAG_CAPMODE
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: 14.2-STABLE
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-19 08:58 UTC by Olivier Certner
Modified: 2025-01-15 14:55 UTC (History)
2 users (show)

See Also:
olce: exp-run?


Attachments
Patch on top of stable/14 - Apply with 'git am' or 'git apply' (5.09 KB, patch)
2024-12-19 08:58 UTC, Olivier Certner
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Certner freebsd_committer freebsd_triage 2024-12-19 08:58:42 UTC
Created attachment 255947 [details]
Patch on top of stable/14 - Apply with 'git am' or 'git apply'

Hi,

I would like an exp-run of the attached patch on top of stable/14, to effectively check that the removal of the internal flag CRED_FLAG_CAPMODE doesn't have any impacts on ports.

Thanks and regards.
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2025-01-04 03:05:02 UTC
This Rust crate needs to be updated: https://github.com/dalance/bsd-kvm-sys/issues/1

I added the corresponding BROKENxx line into sysutils/procs.
Comment 3 Olivier Certner freebsd_committer freebsd_triage 2025-01-15 14:01:38 UTC
(In reply to Yuri Victorovich from comment #2)

Hi Yuri,

Sorry for the breakage.  Despite searching through the web and in particular GitHub search, I didn't notice this use, so went ahead and committed the change to -HEAD.  I requested this exp-run "just in case" before backporting it to stable/14 (fortunately!).

I was planning to MFC this change to stable/14, on the ground that it should not break anything and nobody should be using this constant.  I'm still wondering if I should do it since only sysutils/procs appears to have been broken.  I've just checked again in GitHub search, and I missed it because I chose only the C and C++ languages in the search.  Widening the search to all languages, I indeed get the references in 'procs', and do not see any other one (except for Perl ones but these are bindings automatically generated by Perl compilation).  What do you think?

Thanks and regards.
Comment 4 Olivier Certner freebsd_committer freebsd_triage 2025-01-15 14:55:37 UTC
(In reply to Yuri Victorovich from comment #2)

Proposal to unbreak the port at https://reviews.freebsd.org/D48463.