Created attachment 256748 [details] git patch See attached patch to update net-im/snac from 2.57 to 2.68. There are a large number of improvements and crash fixes between these versions as documented at https://codeberg.org/grunfink/snac2/src/branch/master/RELEASE_NOTES.md
I'm not familiar with the -pedantic flag so I can't comment on that, otherwise lgtm.
What is the purpose of adding "-pedantic"? > -pedantic, --pedantic, -no-pedantic, --no-pedantic > Warn on language extensions https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-pedantic
The `-pedantic` flag was added in snac at https://codeberg.org/grunfink/snac2/commit/12373b018e985ba0bc5628dcaceb7c406a350e45 Given the context, I'd guess there was a helpful warning it added for the upstream maintainers. It appears here so patch.Makefile will still apply cleanly after the upstream change.
(In reply to William Carrel from comment #3) Oh! Sorry, I read the patch wrong! :-D
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=ab751c3536153a8ba004f848a91bea943263b03f commit ab751c3536153a8ba004f848a91bea943263b03f Author: William Carrel <william.a@carrel.org> AuthorDate: 2025-01-18 00:07:42 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2025-01-18 00:15:49 +0000 net-im/snac: Update 2.57 → 2.68 There are a large number of improvements and crash fixes between these versions as documented at Release Notes: https://codeberg.org/grunfink/snac2/src/tag/2.68/RELEASE_NOTES.md PR: 284110 Approved by: Matthew Phillips <matthew@matthewphillips.info> (maintainer) MFH: 2025Q1 net-im/snac/Makefile | 2 +- net-im/snac/distinfo | 6 +++--- net-im/snac/files/patch-Makefile | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-)
A commit in branch 2025Q1 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=da2c16be5f410468275b19c5ff87532a925dbcb7 commit da2c16be5f410468275b19c5ff87532a925dbcb7 Author: William Carrel <william.a@carrel.org> AuthorDate: 2025-01-18 00:07:42 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2025-01-18 00:27:55 +0000 net-im/snac: Update 2.57 → 2.68 There are a large number of improvements and crash fixes between these versions as documented at Release Notes: https://codeberg.org/grunfink/snac2/src/tag/2.68/RELEASE_NOTES.md PR: 284110 Approved by: Matthew Phillips <matthew@matthewphillips.info> (maintainer) MFH: 2025Q1 (cherry picked from commit ab751c3536153a8ba004f848a91bea943263b03f) net-im/snac/Makefile | 2 +- net-im/snac/distinfo | 6 +++--- net-im/snac/files/patch-Makefile | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-)
Thanks!