Bug 284111 - filesystems/wimlib: Update to wimlib-1.14.4
Summary: filesystems/wimlib: Update to wimlib-1.14.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-17 08:13 UTC by mail_of_sergey
Modified: 2025-01-17 20:25 UTC (History)
1 user (show)

See Also:


Attachments
Maintainer's patch against current version (1.59 KB, patch)
2025-01-17 08:13 UTC, mail_of_sergey
no flags Details | Diff
Update with Vladimir Druzenko's remarks (2.19 KB, patch)
2025-01-17 19:36 UTC, mail_of_sergey
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mail_of_sergey 2025-01-17 08:13:48 UTC
Created attachment 256749 [details]
Maintainer's patch against current version

The patch for latest version of WimLib
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2025-01-17 17:26:24 UTC
1. PORTVERSION => DISTVERSION.
2. Remove PORTREVISION.
3. Remove GNU_CONFIGURE_MANPREFIX.
4. Move NTFS_LIB_DEPENDS before NTFS_CONFIGURE_WITH.
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2025-01-17 18:16:42 UTC
(In reply to Vladimir Druzenko from comment #2)
It was 5th not 4th (about libxml2).
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2025-01-17 18:46:47 UTC
5. Tested: remove USES=gnome and USE_GNOME=libxml2.

6. Remove USES=fuse:
> Warning: you might not need LIB_DEPENDS on libfuse.so

7. Add INSTALL_TARGET=install-strip.

Patch for filesystems/wimlib/Makefile:
--- filesystems/wimlib.orig/Makefile
+++ filesystems/wimlib/Makefile
@@ -1,6 +1,5 @@
 PORTNAME=      wimlib
-PORTVERSION=   1.13.0
-PORTREVISION=  3
+DISTVERSION=   1.14.4
 CATEGORIES=    filesystems sysutils
 MASTER_SITES=  https://wimlib.net/downloads/

@@ -11,20 +10,19 @@
 LICENSE=       GPLv3+
 LICENSE_FILE=  ${WRKSRC}/COPYING.GPLv3

-USES=          gmake gnome fuse libtool pkgconfig
-USE_GNOME=     libxml2
+USES=          gmake libtool pkgconfig
 USE_LDCONFIG=  yes

 GNU_CONFIGURE= yes
-GNU_CONFIGURE_MANPREFIX=${PREFIX}/share
 CONFIGURE_ARGS=        --disable-static
+INSTALL_TARGET=        install-strip

 OPTIONS_DEFINE=                NTFS
 OPTIONS_DEFAULT=       NTFS

 NTFS_DESC=     Build with libntfs-3g for NTFS support (recommended)

-NTFS_CONFIGURE_WITH=   ntfs-3g
 NTFS_LIB_DEPENDS=      libntfs-3g.so:filesystems/ntfs
+NTFS_CONFIGURE_WITH=   ntfs-3g

 .include <bsd.port.mk>
Comment 5 mail_of_sergey 2025-01-17 19:36:18 UTC
Created attachment 256758 [details]
Update with Vladimir Druzenko's remarks
Comment 6 mail_of_sergey 2025-01-17 19:37:27 UTC
(In reply to Vladimir Druzenko from comment #4)
Thank you for your important remarks
Comment 7 commit-hook freebsd_committer freebsd_triage 2025-01-17 20:24:54 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=79c61bde75b0a59ab4c18ebca6fa3358cbb32169

commit 79c61bde75b0a59ab4c18ebca6fa3358cbb32169
Author:     Sergey <mail_of_sergey@mail.ru>
AuthorDate: 2025-01-17 20:20:13 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-01-17 20:24:16 +0000

    filesystems/wimlib: Update 1.13.0 → 1.14.4

    Changelogs:
    1.13.1: https://github.com/ebiggers/wimlib/compare/v1.13.0...v1.13.1
    1.13.2: https://wimlib.net/forums/viewtopic.php?t=530
    1.13.3: https://wimlib.net/forums/viewtopic.php?t=543
    1.13.4: https://wimlib.net/forums/viewtopic.php?t=554
    1.13.5: https://wimlib.net/forums/viewtopic.php?t=570
    1.13.6: https://wimlib.net/forums/viewtopic.php?t=612
    1.14.0: https://wimlib.net/forums/viewtopic.php?t=658
    1.14.1: https://wimlib.net/forums/viewtopic.php?t=662
    1.14.2: https://wimlib.net/forums/viewtopic.php?t=675
    1.14.3: https://wimlib.net/forums/viewtopic.php?t=681
    1.14.4: https://wimlib.net/forums/viewtopic.php?t=737

    Improve port:
     - PORTVERSION → DISTVERSION;
     - remove GNU_CONFIGURE_MANPREFIX;
     - remove unnecessary dependencies from libxml2 ad fuse;
     - pet portclippy;
     - add INSTALL_TARGET=install-strip.

    PR:     284111

 filesystems/wimlib/Makefile  | 12 +++++-------
 filesystems/wimlib/distinfo  |  6 +++---
 filesystems/wimlib/pkg-plist |  2 +-
 3 files changed, 9 insertions(+), 11 deletions(-)
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2025-01-17 20:25:22 UTC
Thanks.