Bug 284122 - multimedia/gst123: Fix build on 13.4-RELEASE
Summary: multimedia/gst123: Fix build on 13.4-RELEASE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-17 21:20 UTC by mew14930xvi
Modified: 2025-01-18 16:26 UTC (History)
2 users (show)

See Also:

Attachments
fix build (708 bytes, patch)
2025-01-17 21:20 UTC, mew14930xvi 		mew14930xvi: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mew14930xvi 2025-01-17 21:20:44 UTC 
Created attachment 256762 [details]
fix build
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2025-01-17 22:07:45 UTC 
Testing build on 13.4 amd64…

IMHO, it would be better to add a comment before these new lines with a short description.
To make it easier to understand, these lines should be removed after the end of support for releng/13.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2025-01-18 01:14:16 UTC 
Better approach

https://cgit.freebsd.org/ports/tree/audio/ncmpcpp/Makefile#n55
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2025-01-18 01:18:26 UTC 
What about this:
--- multimedia/gst123.orig/Makefile
+++ multimedia/gst123/Makefile
@@ -19,8 +19,15 @@

 PLIST_FILES=   bin/${PORTNAME} share/man/man1/${PORTNAME}.1.gz

+.include <bsd.port.pre.mk>
+
+.if ${OPSYS} == FreeBSD && ${OSVERSION} < 1400000
+CONFIGURE_ENV= NCURSES_CFLAGS=-I${NCURSESINC} NCURSES_LIBS=-L${NCURSESLIB}
+LDFLAGS+=      ${TINFO_LIB}
+.endif
+
 do-install:
        ${INSTALL_PROGRAM} ${WRKSRC}/src/${PORTNAME} ${STAGEDIR}${PREFIX}/bin
        ${INSTALL_MAN} ${WRKSRC}/docs/${PORTNAME}.1 ${STAGEDIR}${PREFIX}/share/man/man1

-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2025-01-18 01:20:52 UTC 
(In reply to Daniel Engberg from comment #2)
Use:
${OPSYS}_${OSREL:R} == FreeBSD_13
instead of:
${OPSYS} == FreeBSD && ${OSVERSION} < 1400000

Look better.
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2025-01-18 08:33:34 UTC 
Not really but oh well....
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2025-01-18 11:50:24 UTC 
(In reply to Daniel Engberg from comment #5)
Ahh nm.. misread :-)
Comment 7 commit-hook freebsd_committer freebsd_triage 2025-01-18 16:19:33 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a19f517290b2ef1d12fd65ad8af38bfed1c99c46

commit a19f517290b2ef1d12fd65ad8af38bfed1c99c46
Author:     mew14930xvi <mew14930xvi@inbox.lv>
AuthorDate: 2025-01-18 16:14:24 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-01-18 16:18:56 +0000

    multimedia/gst123: Fix build on 13

    Can't find ncurses during configure stage:
    checking for ncurses >= 5... no
    checking for ncurses6-config... false
    checking for ncurses5-config... (cached) false
    checking for ncurses-config... (cached) false
    configure: error: Neither pkgconfig(ncurses) nor ncurses-config was found.
    ===>  Script "configure" failed unexpectedly.

    PR:     284122
    Fixes:  716c8f511a06 (Update 0.3.3 → 0.4.1 and remove DEPRECATED)

 multimedia/gst123/Makefile | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2025-01-18 16:26:29 UTC 
Thanks.