Bug 284139 - devel/root: Update to 6.34/02
Summary: devel/root: Update to 6.34/02
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Nuno Teixeira
URL: https://root.cern/doc/v634/release-no...
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-18 16:43 UTC by Erik Jensen
Modified: 2025-02-07 10:36 UTC (History)
1 user (show)

See Also:


Attachments
Patch for upgrade of port to version 6.34/02 (214.14 KB, patch)
2025-01-18 16:43 UTC, Erik Jensen
erik: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Jensen 2025-01-18 16:43:22 UTC
Created attachment 256777 [details]
Patch for upgrade of port to version 6.34/02

Patch for upgrade of port to version 6.34/02

'qt5web' support is now added as a port option.
This defaults to OFF, mirroring the source's default build options.

Note also that ROOT now insists on building and linking against its
own shipped version of libAfterImage, if 'asimage' option is ON.

Release notes: https://root.cern/doc/v634/release-notes.html
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2025-01-18 22:50:33 UTC
Hello Erik,

Does upstream supports Qt6?

Qt 5.x has been long deprecated upstream [1] and the FreeBSD kde@ team
recommends using Qt 6.x for end-user applications whenever possible.

[1] https://www.qt.io/blog/qt-5.15-support-ends
Comment 2 Erik Jensen 2025-01-18 23:25:39 UTC
Hi Nuno,

Upstream does support qt6 - they still support both qt5 and qt6 as separate (seemingly, not necessarily exclusive) options.

I will look into enabling qt6 as a port option and report back.

Perhaps the present patch can be pushed in the meantime?
qt{5,6} is not new to this release - I just finally got around to looking into the support of qt with this patch. 

Cheers from
Erik
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2025-01-25 01:28:27 UTC
Hello,

Do you know if i386 is still supported upstream?
I've checked my logs and previous versions builds on i386: (>= 6.30.06 && <= 6.32.08).


14.2 i386:

<snip>
FAILED: tree/ntuple/CMakeFiles/ROOTNTuple.dir/v7/src/RPageStorageFile.cxx.o
/usr/bin/c++  -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02/tree/ntuple/v7/inc -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02/tree/ntuple/inc -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02/core/unix/../
clib/res -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02/core/unix/inc -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02/core/zstd/inc -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02/core/lz4/inc -I/wrkdirs/u
sr/ports/devel/root/work/root-6.34.02/core/lzma/inc -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02/core/zip/inc -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02/core/thread/inc -I/wrkdirs/usr/ports/devel/root
/work/root-6.34.02/core/textinput/src -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02/core/textinput/inc -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02/core/rint/inc -I/wrkdirs/usr/ports/devel/root/work/root
-6.34.02/core/meta/inc -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02/core/gui/inc -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02/core/foundation/res -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02/core/f
oundation/v7/inc -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02/core/foundation/inc -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02/core/cont/inc -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02/core/clingu
tils/res -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02/core/clingutils/inc -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02/core/clib/inc -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02/core/base/v7/inc -I
/wrkdirs/usr/ports/devel/root/work/root-6.34.02/core/base/inc -I/wrkdirs/usr/ports/devel/root/work/.build/ginclude -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02/core/imt/inc -I/wrkdirs/usr/ports/devel/root/wo
rk/root-6.34.02/math/vecops/inc -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02/core/multiproc/inc -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02/net/net/inc -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02
/io/io/v7/inc -I/wrkdirs/usr/ports/devel/root/work/root-6.34.02/io/io/inc -isystem /usr/local/include -O2 -pipe -DLIBICONV_PLUG -fstack-protector-strong -fno-strict-aliasing  -DLIBICONV_PLUG -fcolor-diagnostics -
Wc++11-narrowing -Wsign-compare -Wsometimes-uninitialized -Wconditional-uninitialized -Wheader-guard -Warray-bounds -Wcomment -Wtautological-compare -Wstrncat-size -Wloop-analysis -Wbool-conversion -pipe -msse2 -
mfpmath=sse -Wall -W -Woverloaded-virtual -fsigned-char -pthread -O2 -pipe -DLIBICONV_PLUG -fstack-protector-strong -fno-strict-aliasing  -DLIBICONV_PLUG  -DNDEBUG -std=c++17 -fPIC -MD -MT tree/ntuple/CMakeFiles/
ROOTNTuple.dir/v7/src/RPageStorageFile.cxx.o -MF tree/ntuple/CMakeFiles/ROOTNTuple.dir/v7/src/RPageStorageFile.cxx.o.d -o tree/ntuple/CMakeFiles/ROOTNTuple.dir/v7/src/RPageStorageFile.cxx.o -c /wrkdirs/usr/ports/
devel/root/work/root-6.34.02/tree/ntuple/v7/src/RPageStorageFile.cxx
/wrkdirs/usr/ports/devel/root/work/root-6.34.02/tree/ntuple/v7/src/RPageStorageFile.cxx:345:66: error: non-constant-expression cannot be narrowed from type 'std::uint64_t' (aka 'unsigned long long') to 'std::size
_t' (aka 'unsigned int') in initializer list [-Wc++11-narrowing]
  345 |          {fStructureBuffer.fPtrHeader, fAnchor->GetSeekHeader(), fAnchor->GetNBytesHeader(), 0},
      |                                                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
/wrkdirs/usr/ports/devel/root/work/root-6.34.02/tree/ntuple/v7/src/RPageStorageFile.cxx:345:66: note: insert an explicit cast to silence this issue
  345 |          {fStructureBuffer.fPtrHeader, fAnchor->GetSeekHeader(), fAnchor->GetNBytesHeader(), 0},
      |                                                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                                  static_cast<size_t>(      )
/wrkdirs/usr/ports/devel/root/work/root-6.34.02/tree/ntuple/v7/src/RPageStorageFile.cxx:346:66: error: non-constant-expression cannot be narrowed from type 'std::uint64_t' (aka 'unsigned long long') to 'std::size
_t' (aka 'unsigned int') in initializer list [-Wc++11-narrowing]
  346 |          {fStructureBuffer.fPtrFooter, fAnchor->GetSeekFooter(), fAnchor->GetNBytesFooter(), 0}};
      |                                                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
/wrkdirs/usr/ports/devel/root/work/root-6.34.02/tree/ntuple/v7/src/RPageStorageFile.cxx:346:66: note: insert an explicit cast to silence this issue
  346 |          {fStructureBuffer.fPtrFooter, fAnchor->GetSeekFooter(), fAnchor->GetNBytesFooter(), 0}};
      |                                                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                                  static_cast<size_t>(      )
2 errors generated.
[ 81% 8638/10587] /usr/bin/c++ (...) </snip>
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2025-01-25 01:34:51 UTC
(In reply to Nuno Teixeira from comment #3)
(...)

https://people.freebsd.org/~eduardo/logs/root-i386/
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2025-02-07 10:36:28 UTC
Friendly ping!