Bug 284231 - benchmarks/lzbench: Update to 1.9
Summary: benchmarks/lzbench: Update to 1.9
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-21 12:11 UTC by Anton Saietskii
Modified: 2025-01-21 14:45 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (danfe)

Attachments
v0 (apply via 'git am') (1.51 KB, patch)
2025-01-21 12:11 UTC, Anton Saietskii 		vsasjason: maintainer-approval?
Details | Diff
'poudriere bulk -t' log (14.2-R amd64) (194.03 KB, text/plain)
2025-01-21 12:14 UTC, Anton Saietskii 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Saietskii 2025-01-21 12:11:41 UTC 
Created attachment 256873 [details]
v0 (apply via 'git am')

user@hostname: [?:0] /usr/ports/benchmarks/lzbench $ lzbench | head -1
lzbench 1.9 (64-bit FreeBSD)  Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
Comment 1 Anton Saietskii 2025-01-21 12:14:38 UTC 
Created attachment 256874 [details]
'poudriere bulk -t' log (14.2-R amd64)
Comment 2 Anton Saietskii 2025-01-21 14:45:47 UTC 
Noticed we don't have '-r' option (recurse directories).

Looks like here are problematic lines of code [0] which tries to detect system capabilities:
#elif (defined(__APPLE__) && defined(__MACH__)) || \
     ((defined(__unix__) || defined(__unix) || defined(__midipix__)) && defined(_POSIX_C_SOURCE) && (_POSIX_C_SOURCE >= 200112L)) /* snprintf, opendir */
#  define UTIL_HAS_CREATEFILELIST
#  include <dirent.h>       /* opendir, readdir */

I guess it would be nice to create a local patch or upstream PR, however I don't know how to work with _POSIX_C_SOURCE neither have GitHub account.

[0]: https://github.com/inikep/lzbench/blob/cbeaa92b137558ae26df428c8a2cae7598a9c6e8/_lzbench/util.h#L352