Bug 284470 - archivers/py-zlib-ng: Add an option to use zlib-ng from ports instead of bundled version
Summary: archivers/py-zlib-ng: Add an option to use zlib-ng from ports instead of bund...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-01-30 18:41 UTC by Oleg Sidorkin
Modified: 2025-01-31 12:10 UTC (History)
1 user (show)

See Also:

Attachments
Patch to optionally unbundle zlib-ng from py-zlib-ng (1017 bytes, patch)
2025-01-30 18:41 UTC, Oleg Sidorkin 		osidorkin: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Sidorkin 2025-01-30 18:41:33 UTC 
Created attachment 257134 [details]
Patch to optionally unbundle zlib-ng from py-zlib-ng

Our archivers/zlib-ng version is newer than bundled one so let's add an option to use it instead of bunlded version (off by default).

I'm using the unbundled version for a while and it works ok for me.
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2025-01-30 19:37:52 UTC 
Why not use the version from the ports by default?
Comment 2 Oleg Sidorkin 2025-01-31 10:26:47 UTC 
(In reply to Vladimir Druzenko from comment #1)

Bundled version seems to be tested more and py-zlib-ng tests are not in archive.
I think it's better to add tests before switching default.
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2025-01-31 12:03:58 UTC 
Ok.
Build fine with zlib-ng from ports.
Maybe switch default on zlib-ng from ports later.
Comment 4 commit-hook freebsd_committer freebsd_triage 2025-01-31 12:07:36 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7813c72dd2771baf7a4c7e677519d7a8dfc85f26

commit 7813c72dd2771baf7a4c7e677519d7a8dfc85f26
Author:     Oleg Sidorkin <osidorkin@gmail.com>
AuthorDate: 2025-01-31 12:04:41 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-01-31 12:04:41 +0000

    archivers/py-zlib-ng: Add an option to use zlib-ng from ports instead of bundled version

    Our archivers/zlib-ng version is newer than bundled one so let's add an
    option to use it instead of bunlded version (off by default).
    Maybe we'll switch default to archivers/zlib-ng later.

    PR:     284470

 archivers/py-zlib-ng/Makefile | 7 +++++++
 1 file changed, 7 insertions(+)
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2025-01-31 12:10:38 UTC 
Thanks.