Bug 286653 - emulators/flycast: update to 2.5
Summary: emulators/flycast: update to 2.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL: https://github.com/flyinghead/flycast...
Keywords:
Depends on:
Blocks:
 
Reported: 2025-05-07 15:55 UTC by Stefan Schlosser
Modified: 2025-05-07 21:45 UTC (History)
1 user (show)

See Also:
bsdcode: maintainer-feedback+


Attachments
update to 2.5 (8.06 KB, patch)
2025-05-07 15:55 UTC, Stefan Schlosser
bsdcode: maintainer-approval+
Details | Diff
v2 (8.13 KB, patch)
2025-05-07 20:44 UTC, Stefan Schlosser
bsdcode: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Schlosser 2025-05-07 15:55:23 UTC
Created attachment 260244 [details]
update to 2.5

Changelog:
https://github.com/flyinghead/flycast/releases/tag/v2.5

* add net/asio to BUILD_DEPENDS
* update to USES=compiler:c++20-lang


Remarks about this patch:

1) Cosmetic changes: use "glslang>0" instead of only "glslang" in VULKAN_BUILD_DEPENDS, and use newline to separate the VULKAN_CMAKE_BOOL arguments

2) The CMakeLists.txt patch to use CMake build flags for supporting the audio backends and Lua conditionally, and to use the system-provided libchdr, have been upstreamed. So the CMakeLists.txt patch is reduced to only handle the Vulkan headers now.

3) files/patch-core_rend_vulkan_vulkan__context.cpp didn't apply cleanly anymore. Rebase of the patch was necessary.
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2025-05-07 19:47:38 UTC
Not linked with libzstd.so:
Warning: you might not need LIB_DEPENDS on libzstd.so
Comment 2 Stefan Schlosser 2025-05-07 20:44:30 UTC
Created attachment 260248 [details]
v2

Thanks, you are right.

I was fooled by the output of ldd /usr/local/bin/flycast listing libzstd. But it is actually brought in indirectly by linking with libchdr. This is a leftover from the very first version of this port, when I hadn't unbundled libchdr. I unbundled it before the port got accepted, but this was missed.

v2 removes libzstd.so from LIB_DEPENDS.
Comment 3 commit-hook freebsd_committer freebsd_triage 2025-05-07 21:32:28 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ea2b117dee4cf490adf27055a216086f4270e8d3

commit ea2b117dee4cf490adf27055a216086f4270e8d3
Author:     Stefan Schlosser <bsdcode@disroot.org>
AuthorDate: 2025-05-07 21:20:25 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-05-07 21:31:34 +0000

    emulators/flycast: Update 2.4 => 2.5

    Changelog:
    https://github.com/flyinghead/flycast/releases/tag/v2.5

    * Add net/asio to BUILD_DEPENDS.
    * Update to USES=compiler:c++20-lang.
    * Remove upstreamed patches.
    * Cosmetic non-functional and whitespace changes.

    PR:     286653

 emulators/flycast/Makefile                         | 18 ++++---
 emulators/flycast/Makefile.tuples                  |  2 +-
 emulators/flycast/distinfo                         | 10 ++--
 emulators/flycast/files/patch-CMakeLists.txt       | 58 +---------------------
 .../patch-core_rend_vulkan_vulkan__context.cpp     |  6 +--
 5 files changed, 21 insertions(+), 73 deletions(-)
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2025-05-07 21:45:01 UTC
Thanks.