Bug 286748 - emulators/virtualbox-ose: missing patch
Summary: emulators/virtualbox-ose: missing patch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-05-12 17:18 UTC by Martin Birgmeier
Modified: 2025-05-16 02:16 UTC (History)
2 users (show)

See Also:
vvd: maintainer-feedback+
vvd: merge-quarterly+


Attachments
missing patch (445 bytes, patch)
2025-05-12 17:18 UTC, Martin Birgmeier
no flags Details | Diff
virtualbox-ose v1 (4.26 KB, patch)
2025-05-12 19:38 UTC, Vladimir Druzenko
no flags Details | Diff
virtualbox-ose-70 v1 (5.17 KB, patch)
2025-05-12 19:39 UTC, Vladimir Druzenko
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Birgmeier 2025-05-12 17:18:31 UTC
Created attachment 260355 [details]
missing patch

A patch is missing for 55c131637a48 to compile.

Attached.

-- Martin
Comment 1 rkoberman 2025-05-12 18:35:26 UTC
Patch worked for me on main-n277182-7ffedfe14ca8. Thanks, Martin!
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2025-05-12 18:39:15 UTC
(In reply to rkoberman from comment #1)
Did you test anything specific or just build+run?
Comment 3 Martin Birgmeier 2025-05-12 18:40:01 UTC
(In reply to Vladimir Druzenko from comment #2)

Just build here.

-- Martin
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2025-05-12 19:38:29 UTC
Created attachment 260359 [details]
virtualbox-ose v1

Add more OS_RT_FREEBSD in Graphics/*.
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2025-05-12 19:39:35 UTC
Created attachment 260360 [details]
virtualbox-ose-70 v1

Same for virtualbox-ose-70.

Build without errors, but runtime not tested.
Can anybody test runtime?
Comment 6 rkoberman 2025-05-13 00:35:32 UTC
(In reply to Vladimir Druzenko from comment #5)
Running fine for me with 6.0 on head.
Comment 7 rkoberman 2025-05-13 00:38:55 UTC
(In reply to Vladimir Druzenko from comment #5)
Sorry, I meant ti include that I manually did the one-line edit, built the port and tested with both Windows10 and Linux VMs. Worked fine.
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2025-05-13 00:43:52 UTC
(In reply to rkoberman from comment #7)
Can you test with my patch too?
Comment 9 rkoberman 2025-05-13 01:33:11 UTC
Your patch builds and runs fine with both of my VMs.
Comment 10 Vladimir Druzenko freebsd_committer freebsd_triage 2025-05-13 01:36:04 UTC
Tested (In reply to rkoberman from comment #9)
With my patch shutdown VM crashes VM if video is VMSVGA. :-(
Testing changes…
Comment 11 rkoberman 2025-05-13 01:46:06 UTC
I'm running VMSVGA on both VMs. Still no issues for me.
Comment 12 Vladimir Druzenko freebsd_committer freebsd_triage 2025-05-13 02:01:14 UTC
I'm testing 7.1.8 (not committed yet).
Did you tested VMSVGA with 3D on?
Comment 13 rkoberman 2025-05-13 02:23:10 UTC
(In reply to Vladimir Druzenko from comment #12)
Both VMs have 3D enabled.
Comment 14 Vladimir Druzenko freebsd_committer freebsd_triage 2025-05-13 17:42:10 UTC
I think it's "bug" on my side on one host - I updated nvidia drivers and didn't rebooted yet and even glxinfo can't find GLX.
But on another host all work fine.
So I'll commit patches very soon.
Comment 15 commit-hook freebsd_committer freebsd_triage 2025-05-13 17:58:00 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=47d943f3cfad86764803a0c1a99a4a65d33ddf17

commit 47d943f3cfad86764803a0c1a99a4a65d33ddf17
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2025-05-13 17:45:42 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-05-13 17:55:40 +0000

    emulators/virtualbox-ose{,-nox11}: Add patches for better graphics devices support

    While here refresh patches for graphics devices

    PR:             286748
    Tested by:      Martin Birgmeier <d8zNeCFG@aon.at>, rkoberman@gmail.com
    MFH:            2025Q2

 emulators/virtualbox-ose-nox11/Makefile              |  2 +-
 emulators/virtualbox-ose/Makefile                    |  2 +-
 ...h-src_VBox_Devices_Graphics_DevVGA-SVGA.cpp (new) | 20 ++++++++++++++++++++
 ...src_VBox_Devices_Graphics_DevVGA-SVGA3d-glLdr.cpp |  2 +-
 ...h-src_VBox_Devices_Graphics_DevVGA-SVGA3d-glLdr.h |  4 ++--
 ...x_Devices_Graphics_DevVGA-SVGA3d-internal.h (new) | 11 +++++++++++
 6 files changed, 36 insertions(+), 5 deletions(-)
Comment 16 commit-hook freebsd_committer freebsd_triage 2025-05-13 17:58:01 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=031b8f8fae05eb84510c1686e8126959216c2426

commit 031b8f8fae05eb84510c1686e8126959216c2426
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2025-05-13 17:51:09 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-05-13 17:55:40 +0000

    emulators/virtualbox-ose{,-nox11}-70: Add patches for better graphics devices support

    While here refresh patches for graphics devices

    PR:             286748
    Tested by:      Martin Birgmeier <d8zNeCFG@aon.at>, rkoberman@gmail.com
    MFH:            2025Q2

 emulators/virtualbox-ose-70/Makefile                 |  2 +-
 ...h-src_VBox_Devices_Graphics_DevVGA-SVGA.cpp (new) | 20 ++++++++++++++++++++
 ..._Devices_Graphics_DevVGA-SVGA3d-dx-dx11.cpp (new) | 11 +++++++++++
 ...src_VBox_Devices_Graphics_DevVGA-SVGA3d-glLdr.cpp |  8 ++++----
 ...h-src_VBox_Devices_Graphics_DevVGA-SVGA3d-glLdr.h |  4 ++--
 emulators/virtualbox-ose-nox11-70/Makefile           |  2 +-
 6 files changed, 39 insertions(+), 8 deletions(-)
Comment 17 commit-hook freebsd_committer freebsd_triage 2025-05-13 18:41:12 UTC
A commit in branch 2025Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b0f425fe96500cdb49ed9e39ac875e40a8fcd9fc

commit b0f425fe96500cdb49ed9e39ac875e40a8fcd9fc
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2025-05-13 17:45:42 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-05-13 18:40:20 +0000

    emulators/virtualbox-ose{,-nox11}: Add patches for better graphics devices support

    While here refresh patches for graphics devices

    PR:             286748
    Tested by:      Martin Birgmeier <d8zNeCFG@aon.at>, rkoberman@gmail.com
    MFH:            2025Q2

    (cherry picked from commit 47d943f3cfad86764803a0c1a99a4a65d33ddf17)

 emulators/virtualbox-ose-nox11/Makefile              |  2 +-
 emulators/virtualbox-ose/Makefile                    |  2 +-
 ...h-src_VBox_Devices_Graphics_DevVGA-SVGA.cpp (new) | 20 ++++++++++++++++++++
 ...src_VBox_Devices_Graphics_DevVGA-SVGA3d-glLdr.cpp |  2 +-
 ...h-src_VBox_Devices_Graphics_DevVGA-SVGA3d-glLdr.h |  4 ++--
 ...x_Devices_Graphics_DevVGA-SVGA3d-internal.h (new) | 11 +++++++++++
 6 files changed, 36 insertions(+), 5 deletions(-)
Comment 18 commit-hook freebsd_committer freebsd_triage 2025-05-13 18:41:14 UTC
A commit in branch 2025Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=02617ab4248846e42e04ee2c7b7ea410d99e3308

commit 02617ab4248846e42e04ee2c7b7ea410d99e3308
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2025-05-13 17:51:09 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2025-05-13 18:40:24 +0000

    emulators/virtualbox-ose{,-nox11}-70: Add patches for better graphics devices support

    While here refresh patches for graphics devices

    PR:             286748
    Tested by:      Martin Birgmeier <d8zNeCFG@aon.at>, rkoberman@gmail.com
    MFH:            2025Q2

    (cherry picked from commit 031b8f8fae05eb84510c1686e8126959216c2426)

 emulators/virtualbox-ose-70/Makefile                 |  2 +-
 ...h-src_VBox_Devices_Graphics_DevVGA-SVGA.cpp (new) | 20 ++++++++++++++++++++
 ..._Devices_Graphics_DevVGA-SVGA3d-dx-dx11.cpp (new) | 11 +++++++++++
 ...src_VBox_Devices_Graphics_DevVGA-SVGA3d-glLdr.cpp |  8 ++++----
 ...h-src_VBox_Devices_Graphics_DevVGA-SVGA3d-glLdr.h |  4 ++--
 emulators/virtualbox-ose-nox11-70/Makefile           |  2 +-
 6 files changed, 39 insertions(+), 8 deletions(-)
Comment 19 Vladimir Druzenko freebsd_committer freebsd_triage 2025-05-13 18:46:50 UTC
Thanks.
Comment 20 Vladimir Druzenko freebsd_committer freebsd_triage 2025-05-16 02:16:21 UTC
(In reply to Vladimir Druzenko from comment #14)
Yes, bug was on my side - after reboot host all work fine (nvidia can't kldunload && kldload - reboot only).