Bug 287694 - libc/gen/glob: glob_callback_test failing for 99+ days in CI
Summary: libc/gen/glob: glob_callback_test failing for 99+ days in CI
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: tests (show other bugs)
Version: Unspecified
Hardware: Any Any
: --- Affects Only Me
Assignee: Bojan Novković
URL: https://reviews.freebsd.org/D50965
Keywords:
Depends on:
Blocks:
 
Reported: 2025-06-20 21:23 UTC by Siva Mahadevan
Modified: 2025-06-23 08:46 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Siva Mahadevan freebsd_triage 2025-06-20 21:23:11 UTC
The tests introduced in https://reviews.freebsd.org/D50486 are failing in FreeBSD CI for 99+ days. See the latest report here at time of writing: https://ci.freebsd.org/job/FreeBSD-main-amd64-test/26612/testReport/

@bnovkov could you triage as necessary?
Comment 1 Dag-Erling Smørgrav freebsd_committer freebsd_triage 2025-06-21 17:16:56 UTC
The proximate cause appears to be that CI runs tests as root, and the callback test relies on being unable to read a directory created with mode 0007, which does not constrain root.
Comment 2 commit-hook freebsd_committer freebsd_triage 2025-06-23 08:45:26 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=7fe39bec801a08f541d0111219fe8701a6a20cf1

commit 7fe39bec801a08f541d0111219fe8701a6a20cf1
Author:     Dag-Erling Smørgrav <des@FreeBSD.org>
AuthorDate: 2025-06-23 08:44:12 +0000
Commit:     Dag-Erling Smørgrav <des@FreeBSD.org>
CommitDate: 2025-06-23 08:44:31 +0000

    glob: Improve callback tests.

    Most importantly, they need to run without privileges, since root is
    allowed to read a directory regardless of its permission bits.

    PR:             287694
    Fixes:          4d7c31bca252
    Sponsored by:   Klara, Inc.
    Reviewed by:    bnovkov
    Differential Revision:  https://reviews.freebsd.org/D50965

 lib/libc/tests/gen/glob2_test.c       | 47 +++++++++++++++++++++-----------
 lib/libc/tests/gen/glob_blocks_test.c | 51 ++++++++++++++++++++++-------------
 2 files changed, 63 insertions(+), 35 deletions(-)