Bug 3361 - Enhancement patch for bsd.port.mk
Summary: Enhancement patch for bsd.port.mk
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 1997-04-20 19:50 UTC by jhs
Modified: 1997-04-22 05:04 UTC (History)
1 user (show)

See Also:

Attachments
file.diff (791 bytes, patch)
1997-04-20 19:50 UTC, jhs 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jhs freebsd_committer freebsd_triage 1997-04-20 19:50:02 UTC 
	-

How-To-Repeat: 	setenv NEARBY_DISTFILES_SITE ftp://my_local_provider.net//bla/distfiles
	make fetch
Comment 1 Jordan K. Hubbard 1997-04-20 20:44:15 UTC 
> 	setenv NEARBY_DISTFILES_SITE ftp://my_local_provider.net//bla/distfiles

How is this any different than the existing:

setenv MASTER_SITE_OVERRIDE ftp://my_local_provider.net//bla/distfiles

??

					Jordan
Comment 2 james 1997-04-20 20:48:19 UTC 
On Sun, 20 Apr 1997 jhs@freebsd.org wrote:

> + MASTER_SITES:=	${NEARBY_DISTFILES_SITE}/ ${MASTER_SITES}
> + PATCH_SITES:=	${NEARBY_DISTFILES_SITE}/ ${MASTER_SITES}
> + .endif

Sounds like a good idea, but doesn't MASTER_SITE_OVERRIDE already do
this ? 

.if !defined(MASTER_SITE_OVERRIDE)
MASTER_SITES+=  ${MASTER_SITE_BACKUP}
PATCH_SITES+=   ${MASTER_SITE_BACKUP}
.else
MASTER_SITES:=  ${MASTER_SITE_OVERRIDE} ${MASTER_SITES}
PATCH_SITES:=   ${MASTER_SITE_OVERRIDE} ${PATCH_SITES}
.endif

${MASTER_SITE_OVERRIDE} doesn't (as I once thought) override
${MASTER_SITES}, it just prepends the one you name to the defined list.

--
j.
Comment 3 Satoshi Asami freebsd_committer freebsd_triage 1997-04-22 05:03:59 UTC 
State Changed
From-To: open->closed

Equivalent functionality already provided as MASTER_SITE_OVERRIDE.