Wed Jun 12 22:58:39 CEST 2002 on a FreeBSD-4.5-Release system I found the following patch to be necessary, else after running pkg_add exmh-2.5_1.tgz which invokes pkg_add nmh-1.0.4_1.tgz exmh-2.5 when you click on "Reply all" (but not just on "Reply to sender" ) fails with this error message: repl: repl: unable to open format file replgroupcomps: No such file or directory, The patch is made against current almost-4.6 sources. Fix: EXMH no longer fails after a cd /usr/ports/mail/nmh;make install which adds the necessary etc/nmh/replgroupcomps, so I identified all the extra files the install adds for my patch, However I someone, presumably MAINTAINER= Scott.Blachowicz@seaslug.org please check if it's appropriate to add all of these files, or whether some need to be omitted, or added via some interactive. checker (though make install is not interactive on an empty directory, it adds them, else my EXMH wouldn't now be working. This patch will be archived in http://bim.bsn.com/~jhs/src/bsd/fixes/FreeBSD/ports/gen/mail/nmh/pkg-plist.diff All my fixes are indexed from http://bim.bsn.com/~jhs/src/fixes.html How-To-Repeat: pkg_delete nmh and exmh rm -rf /usr/local/etc/nmh # to clear any extras a direct # make install may have delivered pkg_add the 2, start EXMH, click on reply-all
The current nmh port patches the etc/Makefile.in file (based on a patch that someone else provided, I forget who...sorry) so that it installs all those config files to *.default files, then the port Makefile goes through and copies from *.default to * if the config file isn't already there: post-install: @PKG_PREFIX='${PREFIX}' ${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL chgrp mail ${PREFIX}/bin/inc ${CHMOD} g+s ${PREFIX}/bin/inc for file in ${PREFIX}/etc/nmh/*.default ; do \ if [ \! -f $${file%%.default} ] ; then \ cp $$file $${file%%.default} ; \ chmod u+w $${file%%.default} ; \ fi \ done Hmmm...unfortunately, that logic doesn't get executed when you install the package (right?). So, I should move it into the 'pkg-install POST-INSTALL' processing? Same (I imagine) for the setgid stuff on the 'inc' program? Or is that even supposed to be setgid 'mail' any more? (I don't know what the standard is for FreeBSD). I don't think we want to put those config files into the pkg-plist because that means that deleting the package would remove the config files (right?) which makes going from one version to a newer one a pain. What IS the standard way for handling site-customizable config files anyways? Thanx, Scott On Wed, Jun 12, 2002 at 11:29:54PM +0200, Julian Stacey wrote: > > >Number: 39205 > >Category: ports > >Synopsis: Patch to add nmh package files so EXMH reply-all works > >Confidential: no > >Severity: serious > >Priority: medium > >Responsible: freebsd-ports > >State: open > >Quarter: > >Keywords: > >Date-Required: > >Class: change-request > >Submitter-Id: current-users > >Arrival-Date: Wed Jun 12 15:40:01 PDT 2002 > >Closed-Date: > >Last-Modified: > >Originator: Julian Stacey > >Release: current > >Organization: > Vector Systems Ltd - Munich Unix & Sys. Eng. Consultancy > >Environment: > System: FreeBSD flip.jhs.private 4.5-RELEASE FreeBSD 4.5-RELEASE #0: Wed Jun 12 00:14:50 CEST 2002 jhs@build.jhs:/usr/src/sys/compile/BUILD i386 > > > >Description: > > Wed Jun 12 22:58:39 CEST 2002 on a FreeBSD-4.5-Release system > I found the following patch to be necessary, > else after running > pkg_add exmh-2.5_1.tgz > which invokes > pkg_add nmh-1.0.4_1.tgz > exmh-2.5 when you click on > "Reply all" > (but not just on > "Reply to sender" > ) fails with this error message: > repl: repl: unable to open format file replgroupcomps: > No such file or directory, > The patch is made against current almost-4.6 sources. > > >How-To-Repeat: > pkg_delete nmh and exmh > rm -rf /usr/local/etc/nmh # to clear any extras a direct > # make install may have delivered > pkg_add the 2, start EXMH, click on reply-all > >Fix: > > EXMH no longer fails after a > cd /usr/ports/mail/nmh;make install > which adds the necessary > etc/nmh/replgroupcomps, > so I identified all the extra files the install adds for my patch, > However I someone, presumably > MAINTAINER= Scott.Blachowicz@seaslug.org > please check if it's appropriate to add all of these files, > or whether some need to be omitted, or added via some interactive. > checker (though > make install > is not interactive on an empty directory, it adds them, else my EXMH > wouldn't now be working. > > This patch will be archived in > http://bim.bsn.com/~jhs/src/bsd/fixes/FreeBSD/ports/gen/mail/nmh/pkg-plist.diff > All my fixes are indexed from > http://bim.bsn.com/~jhs/src/fixes.html > > > *** FreeBSD-almost-4.6.ports-cur.4271.2002.06.12/ports/mail/nmh/pkg-plist Fri Jul 27 02:23:08 2001 > --- new/ports/mail/nmh/pkg-plist Wed Jun 12 22:45:39 2002 > *************** > *** 64,69 **** > --- 64,95 ---- > etc/nmh/scan.timely.default > etc/nmh/scan.unseen.default > etc/nmh/tmac.h > + etc/nmh/MailAliases > + etc/nmh/components > + etc/nmh/digestcomps > + etc/nmh/distcomps > + etc/nmh/forwcomps > + etc/nmh/mhl.body > + etc/nmh/mhl.digest > + etc/nmh/mhl.format > + etc/nmh/mhl.forward > + etc/nmh/mhl.headers > + etc/nmh/mhl.reply > + etc/nmh/mhn.defaults > + etc/nmh/mts.conf > + etc/nmh/rcvdistcomps > + etc/nmh/rcvdistcomps.outbox > + etc/nmh/replcomps > + etc/nmh/replgroupcomps > + etc/nmh/scan.MMDDYY > + etc/nmh/scan.YYYYMMDD > + etc/nmh/scan.default > + etc/nmh/scan.mailx > + etc/nmh/scan.nomime > + etc/nmh/scan.size > + etc/nmh/scan.time > + etc/nmh/scan.timely > + etc/nmh/scan.unseen > libexec/nmh/ap > libexec/nmh/conflict > libexec/nmh/dp > >Release-Note: > >Audit-Trail: > >Unformatted: > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-ports" in the body of the message -- Scott Blachowicz
On Wed, Jun 12, 2002 at 05:03:19PM -0700, Scott Blachowicz wrote: > The current nmh port patches the etc/Makefile.in file (based on a patch > that someone else provided, I forget who...sorry) so that it installs all > those config files to *.default files, then the port Makefile goes through > and copies from *.default to * if the config file isn't already there: > > post-install: > @PKG_PREFIX='${PREFIX}' ${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL > chgrp mail ${PREFIX}/bin/inc > ${CHMOD} g+s ${PREFIX}/bin/inc > for file in ${PREFIX}/etc/nmh/*.default ; do \ > if [ \! -f $${file%%.default} ] ; then \ > cp $$file $${file%%.default} ; \ > chmod u+w $${file%%.default} ; \ > fi \ > done > > Hmmm...unfortunately, that logic doesn't get executed when you install the > package (right?). So, I should move it into the 'pkg-install POST-INSTALL' > processing? Same (I imagine) for the setgid stuff on the 'inc' program? Or > is that even supposed to be setgid 'mail' any more? (I don't know what the > standard is for FreeBSD). > > I don't think we want to put those config files into the pkg-plist because > that means that deleting the package would remove the config files > (right?) which makes going from one version to a newer one a pain. What IS > the standard way for handling site-customizable config files anyways? Well...I don't think I got an answer to that, but I tried using this patch to generate a package, then install the package and the etc/nmh/* files got properly setup on the pkg_add. So, unless someone knows better, how about we use this patch on the port instead? I also updated my email address (as maintainer) to point at a different server. Thanx, Scott diff -ru ../nmh-orig/Makefile ./Makefile --- ../nmh-orig/Makefile Mon Apr 22 03:28:48 2002 +++ ./Makefile Sat Jun 15 18:43:59 2002 @@ -1,6 +1,6 @@ # New ports collection makefile for: nmh # Date created: 07 Feb 1999 -# Whom: Scott Blachowicz <Scott.Blachowicz@seaslug.org> +# Whom: Scott Blachowicz <scott+ports@sabami.seaslug.org> # # $FreeBSD: ports/mail/nmh/Makefile,v 1.29 2002/04/21 16:25:02 cy Exp $ # @@ -59,7 +59,7 @@ ${MASTER_SITE_LOCAL} MASTER_SITE_SUBDIR= jkoshy -MAINTAINER= Scott.Blachowicz@seaslug.org +MAINTAINER= scott+ports@sabami.seaslug.org USE_AUTOCONF_VER=213 CONFIGURE_ARGS= --libdir=${PREFIX}/libexec/nmh \ @@ -114,13 +114,5 @@ post-install: @PKG_PREFIX='${PREFIX}' ${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL - chgrp mail ${PREFIX}/bin/inc - ${CHMOD} g+s ${PREFIX}/bin/inc - for file in ${PREFIX}/etc/nmh/*.default ; do \ - if [ \! -f $${file%%.default} ] ; then \ - cp $$file $${file%%.default} ; \ - chmod u+w $${file%%.default} ; \ - fi \ - done .include <bsd.port.mk> diff -ru ../nmh-orig/pkg-install ./pkg-install --- ../nmh-orig/pkg-install Mon Feb 22 19:17:12 1999 +++ ./pkg-install Sat Jun 15 18:13:31 2002 @@ -1,7 +1,22 @@ #!/bin/sh case "$2" in - ""|POST-INSTALL) cat <<EOF + ""|POST-INSTALL) + echo "Changing ${PKG_PREFIX}/bin/inc to group 'mail'" + chgrp mail ${PKG_PREFIX}/bin/inc + + echo "Enabling setgid for ${PKG_PREFIX}/bin/inc" + chmod g+s ${PKG_PREFIX}/bin/inc + + for file in ${PKG_PREFIX}/etc/nmh/*.default ; do + b=`basename $file .default` + if [ \! -f ${PKG_PREFIX}/etc/nmh/$b ] ; then + cp $file ${PKG_PREFIX}/etc/nmh/$b + chmod u+w ${PKG_PREFIX}/etc/nmh/$b + fi + done + + cat <<EOF ============================================================= Some files you might need to customize include the following:
< discovered in my drafts folder, Sorry!> Scott Blachowicz wrote: > The current nmh port patches the etc/Makefile.in file (based on a patch > that someone else provided, I forget who...sorry) so that it installs all > those config files to *.default files, then the port Makefile goes through > and copies from *.default to * if the config file isn't already there: > > post-install: > @PKG_PREFIX='${PREFIX}' ${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL > chgrp mail ${PREFIX}/bin/inc > ${CHMOD} g+s ${PREFIX}/bin/inc > for file in ${PREFIX}/etc/nmh/*.default ; do \ > if [ \! -f $${file%%.default} ] ; then \ > cp $$file $${file%%.default} ; \ > chmod u+w $${file%%.default} ; \ > fi \ > done > > Hmmm...unfortunately, that logic doesn't get executed when you install the > package (right?). Yes, I confirm on 4.5 pkg_add does not add them. > So, I should move it into the 'pkg-install POST-INSTALL' > processing? Yes, putting some if ! exist ... install in pkg-install seems good. > Same (I imagine) for the setgid stuff on the 'inc' program? Or > is that even supposed to be setgid 'mail' any more? (I don't know what the > standard is for FreeBSD). Don't know. > I don't think we want to put those config files into the pkg-plist Agreed, I rescind my patch (not nearly as good as what you propose). > because > that means that deleting the package would remove the config files > (right?) Yes. > which makes going from one version to a newer one a pain. What IS > the standard way for handling site-customizable config files anyways? I suppose, pretty much what you've got already, an echo statement saying aprox "You may want to edit these later" > Thanx, Scott, do you have commit authority (I don't) if so could you please cancel (or clear whatever) my gnats report ports/39205, once you've committed your pkg-install enhancement ? Thanks. > Scott > > On Wed, Jun 12, 2002 at 11:29:54PM +0200, Julian Stacey wrote: > > > > >Number: 39205 > > >Category: ports > > >Synopsis: Patch to add nmh package files so EXMH reply-all works > > >Confidential: no > > >Severity: serious > > >Priority: medium > > >Responsible: freebsd-ports > > >State: open > > >Quarter: > > >Keywords: > > >Date-Required: > > >Class: change-request > > >Submitter-Id: current-users > > >Arrival-Date: Wed Jun 12 15:40:01 PDT 2002 > > >Closed-Date: > > >Last-Modified: > > >Originator: Julian Stacey > > >Release: current > > >Organization: > > Vector Systems Ltd - Munich Unix & Sys. Eng. Consultancy > > >Environment: > > System: FreeBSD flip.jhs.private 4.5-RELEASE FreeBSD 4.5-RELEASE #0: Wed Ju > n 12 00:14:50 CEST 2002 jhs@build.jhs:/usr/src/sys/compile/BUILD i386 > > > > > > >Description: > > > > Wed Jun 12 22:58:39 CEST 2002 on a FreeBSD-4.5-Release system > > I found the following patch to be necessary, > > else after running > > pkg_add exmh-2.5_1.tgz > > which invokes > > pkg_add nmh-1.0.4_1.tgz > > exmh-2.5 when you click on > > "Reply all" > > (but not just on > > "Reply to sender" > > ) fails with this error message: > > repl: repl: unable to open format file replgroupcomps: > > No such file or directory, > > The patch is made against current almost-4.6 sources. > > > > >How-To-Repeat: > > pkg_delete nmh and exmh > > rm -rf /usr/local/etc/nmh # to clear any extras a direct > > # make install may have delivered > > pkg_add the 2, start EXMH, click on reply-all > > >Fix: > > > > EXMH no longer fails after a > > cd /usr/ports/mail/nmh;make install > > which adds the necessary > > etc/nmh/replgroupcomps, > > so I identified all the extra files the install adds for my patch, > > However I someone, presumably > > MAINTAINER= Scott.Blachowicz@seaslug.org > > please check if it's appropriate to add all of these files, > > or whether some need to be omitted, or added via some interactive. > > checker (though > > make install > > is not interactive on an empty directory, it adds them, else my EXMH > > wouldn't now be working. > > > > This patch will be archived in > > http://bim.bsn.com/~jhs/src/bsd/fixes/FreeBSD/ports/gen/mail/nmh/pkg-pl > ist.diff > > All my fixes are indexed from > > http://bim.bsn.com/~jhs/src/fixes.html > > > > > > *** FreeBSD-almost-4.6.ports-cur.4271.2002.06.12/ports/mail/nmh/pkg-plist > Fri Jul 27 02:23:08 2001 > > --- new/ports/mail/nmh/pkg-plist Wed Jun 12 22:45:39 2002 > > *************** > > *** 64,69 **** > > --- 64,95 ---- > > etc/nmh/scan.timely.default > > etc/nmh/scan.unseen.default > > etc/nmh/tmac.h > > + etc/nmh/MailAliases > > + etc/nmh/components > > + etc/nmh/digestcomps > > + etc/nmh/distcomps > > + etc/nmh/forwcomps > > + etc/nmh/mhl.body > > + etc/nmh/mhl.digest > > + etc/nmh/mhl.format > > + etc/nmh/mhl.forward > > + etc/nmh/mhl.headers > > + etc/nmh/mhl.reply > > + etc/nmh/mhn.defaults > > + etc/nmh/mts.conf > > + etc/nmh/rcvdistcomps > > + etc/nmh/rcvdistcomps.outbox > > + etc/nmh/replcomps > > + etc/nmh/replgroupcomps > > + etc/nmh/scan.MMDDYY > > + etc/nmh/scan.YYYYMMDD > > + etc/nmh/scan.default > > + etc/nmh/scan.mailx > > + etc/nmh/scan.nomime > > + etc/nmh/scan.size > > + etc/nmh/scan.time > > + etc/nmh/scan.timely > > + etc/nmh/scan.unseen > > libexec/nmh/ap > > libexec/nmh/conflict > > libexec/nmh/dp > > >Release-Note: > > >Audit-Trail: > > >Unformatted: > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > > with "unsubscribe freebsd-ports" in the body of the message > > -- > Scott Blachowicz > Julian Stacey Munich Unix (FreeBSD, Linux etc) Independent Consultant jhs@bim.bsn.com http://bim.bsn.com/~jhs/ Ihr Rauchen = mein allergischer Kopfschmerz ! Schnupftabak probieren !
No, I don't have commit access. Maybe some kind soul on the ports list with commit access will see this message and apply my patch for me? (the patch should be associated with this ports/39205 report - my message from Sat, 15 Jun 2002 18:45:22 -0700 - or just email me and I'll send it to you) Scott On Fri, Jul 12, 2002 at 01:10:17AM +0200, Julian H. Stacey wrote: > < discovered in my drafts folder, Sorry!> > > Scott Blachowicz wrote: > > The current nmh port patches the etc/Makefile.in file (based on a patch > > that someone else provided, I forget who...sorry) so that it installs all > > those config files to *.default files, then the port Makefile goes through > > and copies from *.default to * if the config file isn't already there: > > > > post-install: > > @PKG_PREFIX='${PREFIX}' ${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL > > chgrp mail ${PREFIX}/bin/inc > > ${CHMOD} g+s ${PREFIX}/bin/inc > > for file in ${PREFIX}/etc/nmh/*.default ; do \ > > if [ \! -f $${file%%.default} ] ; then \ > > cp $$file $${file%%.default} ; \ > > chmod u+w $${file%%.default} ; \ > > fi \ > > done > > > > Hmmm...unfortunately, that logic doesn't get executed when you install the > > package (right?). > > Yes, I confirm on 4.5 pkg_add does not add them. > > > So, I should move it into the 'pkg-install POST-INSTALL' > > processing? > > Yes, putting some if ! exist ... install in pkg-install seems good. > > > Same (I imagine) for the setgid stuff on the 'inc' program? Or > > is that even supposed to be setgid 'mail' any more? (I don't know what the > > standard is for FreeBSD). > > Don't know. > > > I don't think we want to put those config files into the pkg-plist > > Agreed, I rescind my patch (not nearly as good as what you propose). > > > because > > that means that deleting the package would remove the config files > > (right?) > > Yes. > > > which makes going from one version to a newer one a pain. What IS > > the standard way for handling site-customizable config files anyways? > > I suppose, pretty much what you've got already, an echo statement saying > aprox "You may want to edit these later" > > > Thanx, > > Scott, do you have commit authority (I don't) if so could you please > cancel (or clear whatever) my gnats report ports/39205, once you've > committed your pkg-install enhancement ? Thanks. > > > Scott > > > > On Wed, Jun 12, 2002 at 11:29:54PM +0200, Julian Stacey wrote: > > > > > > >Number: 39205 > > > >Category: ports > > > >Synopsis: Patch to add nmh package files so EXMH reply-all works > > > >Confidential: no > > > >Severity: serious > > > >Priority: medium > > > >Responsible: freebsd-ports > > > >State: open > > > >Quarter: > > > >Keywords: > > > >Date-Required: > > > >Class: change-request > > > >Submitter-Id: current-users > > > >Arrival-Date: Wed Jun 12 15:40:01 PDT 2002 > > > >Closed-Date: > > > >Last-Modified: > > > >Originator: Julian Stacey > > > >Release: current > > > >Organization: > > > Vector Systems Ltd - Munich Unix & Sys. Eng. Consultancy > > > >Environment: > > > System: FreeBSD flip.jhs.private 4.5-RELEASE FreeBSD 4.5-RELEASE #0: Wed Ju > > n 12 00:14:50 CEST 2002 jhs@build.jhs:/usr/src/sys/compile/BUILD i386 > > > > > > > > > >Description: > > > > > > Wed Jun 12 22:58:39 CEST 2002 on a FreeBSD-4.5-Release system > > > I found the following patch to be necessary, > > > else after running > > > pkg_add exmh-2.5_1.tgz > > > which invokes > > > pkg_add nmh-1.0.4_1.tgz > > > exmh-2.5 when you click on > > > "Reply all" > > > (but not just on > > > "Reply to sender" > > > ) fails with this error message: > > > repl: repl: unable to open format file replgroupcomps: > > > No such file or directory, > > > The patch is made against current almost-4.6 sources. > > > > > > >How-To-Repeat: > > > pkg_delete nmh and exmh > > > rm -rf /usr/local/etc/nmh # to clear any extras a direct > > > # make install may have delivered > > > pkg_add the 2, start EXMH, click on reply-all > > > >Fix: > > > > > > EXMH no longer fails after a > > > cd /usr/ports/mail/nmh;make install > > > which adds the necessary > > > etc/nmh/replgroupcomps, > > > so I identified all the extra files the install adds for my patch, > > > However I someone, presumably > > > MAINTAINER= Scott.Blachowicz@seaslug.org > > > please check if it's appropriate to add all of these files, > > > or whether some need to be omitted, or added via some interactive. > > > checker (though > > > make install > > > is not interactive on an empty directory, it adds them, else my EXMH > > > wouldn't now be working. > > > > > > This patch will be archived in > > > http://bim.bsn.com/~jhs/src/bsd/fixes/FreeBSD/ports/gen/mail/nmh/pkg-pl > > ist.diff > > > All my fixes are indexed from > > > http://bim.bsn.com/~jhs/src/fixes.html > > > > > > > > > *** FreeBSD-almost-4.6.ports-cur.4271.2002.06.12/ports/mail/nmh/pkg-plist > > Fri Jul 27 02:23:08 2001 > > > --- new/ports/mail/nmh/pkg-plist Wed Jun 12 22:45:39 2002 > > > *************** > > > *** 64,69 **** > > > --- 64,95 ---- > > > etc/nmh/scan.timely.default > > > etc/nmh/scan.unseen.default > > > etc/nmh/tmac.h > > > + etc/nmh/MailAliases > > > + etc/nmh/components > > > + etc/nmh/digestcomps > > > + etc/nmh/distcomps > > > + etc/nmh/forwcomps > > > + etc/nmh/mhl.body > > > + etc/nmh/mhl.digest > > > + etc/nmh/mhl.format > > > + etc/nmh/mhl.forward > > > + etc/nmh/mhl.headers > > > + etc/nmh/mhl.reply > > > + etc/nmh/mhn.defaults > > > + etc/nmh/mts.conf > > > + etc/nmh/rcvdistcomps > > > + etc/nmh/rcvdistcomps.outbox > > > + etc/nmh/replcomps > > > + etc/nmh/replgroupcomps > > > + etc/nmh/scan.MMDDYY > > > + etc/nmh/scan.YYYYMMDD > > > + etc/nmh/scan.default > > > + etc/nmh/scan.mailx > > > + etc/nmh/scan.nomime > > > + etc/nmh/scan.size > > > + etc/nmh/scan.time > > > + etc/nmh/scan.timely > > > + etc/nmh/scan.unseen > > > libexec/nmh/ap > > > libexec/nmh/conflict > > > libexec/nmh/dp > > > >Release-Note: > > > >Audit-Trail: > > > >Unformatted: > > > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > > > with "unsubscribe freebsd-ports" in the body of the message
Responsible Changed From-To: freebsd-ports->bmah Over to exmh Maintainer.
State Changed From-To: open->closed Committed the maintainer's patch...thanks!