Bug 41977 - biology/pymol: fix broken build and install example scripts
Summary: biology/pymol: fix broken build and install example scripts
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Hye-Shik Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-08-24 17:40 UTC by glennpj
Modified: 2002-08-25 09:38 UTC (History)
0 users

See Also:


Attachments
pymol.update (2.49 KB, text/plain)
2002-08-24 17:40 UTC, glennpj
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description glennpj 2002-08-24 17:40:01 UTC
        This PR for biology/pymol fixes the build and adds some useful
        example python scripts to the installation.

        - Change ${WRKSRC} to ${PORTNAME}-${PORTVERSION} because the
          current value of ${WRKSRC}=${PKGNAME} no longer works due to
          the appending of the ${PORTREVISION} value.

        - Correct the pmw dependency to check for
          ${PYTHON_SITELIBDIR}/Pmw rather than ${PYTHON_SITELIBDIR}/PMW.

        - Add the example scripts, with the exception of the red-hat
          spec files.  These scripts are potentially useful and one is
          necessary for the Compiled Graphics Object demo.

	- Bump the PORTREVISION
Comment 1 chat95 2002-08-24 18:08:58 UTC
Hi, Glenn,
I checked your port
just make install; make deinstall and portlint.

However, 
===>  Deinstalling for pymol-0.82_2
pkg_delete: unable to completely remove directory '/usr/local/share/pymol'
pkg_delete: couldn't entirely delete package (perhaps the packing list is
incorrectly specified?)

I noticed your pkg-plist is wrong
you may be forgetting about adding 
share/pymol/test/README
share/pymol/test/inp
...

Thank you very much for your effort, but please remake pkg-plist
and please confirm make deinstall really cleans up all the files
and subdirectories.

Sincerely yours,
 Nakata Maho
Comment 2 glennpj 2002-08-24 20:45:36 UTC
This works fine for me.  Here is the output from 'script', and
deinstalling the port after a successful install.

=========
Script started on Sat Aug 24 14:37:07 2002
gforce biology/pymol# make deinstall
===>  Deinstalling for pymol-0.82_2
gforce biology/pymol# exit
exit

Script done on Sat Aug 24 14:37:13 2002
=========

As you can see, everything is removed just fine.  If you look at the
patch I sent in the PR, you will see that I did not remove anything from
the pkg-plist, only added the example scripts.  Please check this again
on your system because this patch does work and the pkg-plist is not
wrong.  Might you have some local modifications that interfered with the
patch?

-- 
Glenn Johnson
glennpj@charter.net
Comment 3 Hye-Shik Chang freebsd_committer 2002-08-24 21:13:37 UTC
Responsible Changed
From-To: freebsd-ports->perky

Oops. I'm sorry, Glenn. I forgot to fix this problem. 
I'll handle this, soon.
Comment 4 chat95 2002-08-25 00:44:09 UTC
I'm sorry. I was bit confused or something(?)
In this morning, I tested your patch and everything worked
fine for me, too.

# make deinstall
===>  Deinstalling for pymol-0.82_2

Thank you very much for your effort, and I'm sorry
that I told an inaccurate thing...

Sincerely yours,
 Nakata Maho
Comment 5 Hye-Shik Chang freebsd_committer 2002-08-25 09:38:10 UTC
State Changed
From-To: open->closed

Committed. Thanks!