Bug 44801 - audio/flac: includes /usr/local/include before its own .h files
Summary: audio/flac: includes /usr/local/include before its own .h files
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Christian Weisgerber
Depends on:
Reported: 2002-11-01 01:40 UTC by Alan Eldridge
Modified: 2002-11-01 18:38 UTC (History)
1 user (show)

See Also:

file.diff (653 bytes, patch)
2002-11-01 01:40 UTC, Alan Eldridge
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Eldridge freebsd_committer 2002-11-01 01:40:00 UTC
Flac includes /usr/local/include in the build before its own .h files. In the
previous update, this was catastriphic - it could not build without the old version being removed first.

Fix: ==8<====8<====8<====8<====8<====8<====8<====8<====8<====8<==
To show this is happening, I seeded /usr/local/include/FLAC/format.h with a 
#error directive. Sure enough, doing the upgrade, I got this:

cc -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE=\"flac\" -DVERSION=\"1.0.4\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DFLAC__CPU_IA32=1 -DFLAC__ALIGN_MALLOC_DATA=1 -DFLAC__SSE_OS=1 -DFLAC__USE_3DNOW=1 -DFLAC__HAS_OGG=1 -DHAVE_ICONV=1 -DICONV_CONST=const -DHAVE_LANGINFO_CODESET=1 -DFLAC__HAS_ID3LIB=1 -DID3LIB_MAJOR=3 -DID3LIB_MINOR=7 -DID3LIB_PATCH=13 -DFLAC__HAS_NASM=1 -DSIZEOF_SHORT=2 -DSIZEOF_INT=4 -DSIZEOF_LONG=4 -DSIZEOF_LONG_LONG=8 -I. -I. -I/usr/local/include -I../.. -I./include -I../../include -O -pipe -march=pentiumpro -DNDEBUG -fomit-frame-pointer -funroll-loops -finline-functions -Wall -W -Winline -DFLaC__INLINE=__inline__ -c file_decoder.c -Wp,-MD,.deps/file_decoder.TPlo  -fPIC -DPIC -o .libs/file_decoder.lo
In file included from /usr/local/include/FLAC/stream_decoder.h:23,
                 from /usr/local/include/FLAC/seekable_stream_decoder.h:23,
                 from /usr/local/include/FLAC/file_decoder.h:23,
                 from include/protected/file_decoder.h:23,
                 from file_decoder.c:32:
/usr/local/include/FLAC/format.h:24: #error build should not include this file
*** Error code 1

Stop in /home/bsd/ports/audio/flac/work/flac-1.0.4/src/libFLAC.
*** Error code 1

Stop in /home/bsd/ports/audio/flac/work/flac-1.0.4/src/libFLAC.
*** Error code 1

Stop in /home/bsd/ports/audio/flac/work/flac-1.0.4/src.
*** Error code 1

Stop in /home/bsd/ports/audio/flac/work/flac-1.0.4.
*** Error code 1

Stop in /home/bsd/ports/audio/flac.
Comment 1 Alan Eldridge freebsd_committer 2002-11-01 01:45:25 UTC
Responsible Changed
From-To: freebsd-ports->naddy

To maintainer.
Comment 2 Christian Weisgerber freebsd_committer 2002-11-01 18:37:40 UTC
State Changed
From-To: open->closed

Fixed.  I think.