Bug 53544 - [patch] net/poptop does not install + more issues
Summary: [patch] net/poptop does not install + more issues
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Christian Weisgerber
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-20 09:50 UTC by Akifyev Sergey
Modified: 2003-06-25 02:06 UTC (History)
0 users

See Also:

Attachments
file.diff (1.96 KB, patch)
2003-06-20 09:50 UTC, Akifyev Sergey 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Akifyev Sergey 2003-06-20 09:50:16 UTC 
1) poptop port does not install because of incorrect patch, which
adds recursive variable in Makefile

2) this port is suffering from double build: first when you type 'make',
second when you type 'make install'

3) poptop lacks option for compiling with kernel ppp support

P.S. I tried to contact maintainer with this about 2 month ago, but he didn't
respond, so please commit this due to timeout. Also, please close my previous
PR about poptop, as this is more complete solution of problem.
(PR = http://www.freebsd.org/cgi/query-pr.cgi?pr=53135)

Fix: Above patch fixes all these issues
How-To-Repeat: # cd /usr/ports/net/poptop
# make install
Variable CFLAGS is recursive.
*** Error code 2
 
Stop in /usr/ports/net/poptop.
Comment 1 Christian Weisgerber freebsd_committer freebsd_triage 2003-06-25 01:54:42 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->naddy

I'll handle this.
Comment 2 Christian Weisgerber freebsd_committer freebsd_triage 2003-06-25 02:05:27 UTC 
State Changed
From-To: open->closed

Committed with modifications, thanks.