Bug 55256 - x11-wm/fvwm2-devel PATCHes - take one, add four knobs
Summary: x11-wm/fvwm2-devel PATCHes - take one, add four knobs
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-08-04 21:50 UTC by parv
Modified: 2003-08-08 07:21 UTC (History)
0 users

See Also:


Attachments
file.diff (2.38 KB, patch)
2003-08-04 21:50 UTC, parv
no flags Details | Diff
file.diff (25.30 KB, patch)
2003-08-04 21:50 UTC, parv
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description parv 2003-08-04 21:50:13 UTC
Included are two patches for fvwm2-devel port: one for Makefile, other
for pkg-plist.  Patch for pkg-list is needed in case of icons are not
installed.

  (In case the patches do not apply due to tabs being lost or other
  formatting errors, get them here...

    http://www103.pair.com/parv/comp/src/patch/fvwm/patch-Makefile
    http://www103.pair.com/parv/comp/src/patch/fvwm/patch-pkg-plist
  )

WITHOUT_SHAPE option is removed (which i suggested some time in past)
as w/o it too many artifacts are generated while moving anything: a
window on a page, page to page, etc.

Four other options are added: WITHOUT_BIDI, WITHOUT_XINERAMA,
WITHOUT_ICONS, WITHOUT_GNOME.  First two do the obvious.

When WITHOUT_ICONS is specified no icons are installed/extracted.  It
works best (as in checksum is not verified) when given on the command
line (as opposed to Makefile.local).  '%%ICONS%%' appropriately
updates the plist.  (I am slightly concerned that WITHOUT_ICONS may be
confused w/ WITHOUT_ICONV if one is not careful.)

WITHOUT_GNOME is needed -- to explicitly disable gnome support -- in
case imlib, gtk, etc are installed but not the everything that makes
gnome a gnome.  As currently is the case, configure does not detect
gnome libs, so it disables that support.  I do not know if you agree
w/ this change, let me know what you think.

How-To-Repeat: 
Apply the patch
Comment 1 Kirill Ponomarev freebsd_committer freebsd_triage 2003-08-06 11:09:03 UTC
Responsible Changed
From-To: freebsd-ports-bugs->cy

Over to maintainer.
Comment 2 Cy Schubert freebsd_committer freebsd_triage 2003-08-08 07:21:10 UTC
State Changed
From-To: open->closed

Committed (with modification).  Thanks for the patch.