Bug 59775 - [patch] ftpd(8)/FreeBSD 5: incorrect reply for "unimplemented" SITE command
Summary: [patch] ftpd(8)/FreeBSD 5: incorrect reply for "unimplemented" SITE command
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: unspecified
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-11-28 23:30 UTC by Nick Leuta
Modified: 2018-01-03 05:16 UTC (History)
0 users

See Also:


Attachments
file.diff (346 bytes, patch)
2003-11-28 23:30 UTC, Nick Leuta
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Leuta 2003-11-28 23:30:21 UTC
An unimplemented FTP command is marked by '*' symbol and an attempt to use it
returns something like "502 ACCT command not implemented."
It's also possible to mark any SITE command as "unimplemented", and it also
will be marked by '*'... But an attempt to use such command leads to
the significantly different reply like
"500 'SITE MD5 xxx': command not understood.".

Both situations are handled by the similar ways, and the difference is that
unimplemented command matches to "| NOTIMPL", but unimplemented SITE
command matches to "| SITE SP NOTIMPL"...

p.s. I think that the better way is not to show unimplemented commands at all,
but if the mentioned above way is selected, it must be implemented
completely...

How-To-Repeat: 1. modify sitetab[] like this:
--- ftpcmd.y.ORI	Tue Feb 11 17:28:28 2003
+++ ftpcmd.y	Fri Nov 28 19:57:09 2003
@@ -1149,7 +1149,7 @@
 };
 
 struct tab sitetab[] = {
-	{ "MD5", MDFIVE, STR1, 1,	"[ <sp> file-name ]" },
+	{ "MD5", MDFIVE, STR1, 0,	"[ <sp> file-name ]" },
 	{ "UMASK", UMASK, ARGS, 1,	"[ <sp> umask ]" },
 	{ "IDLE", IDLE, ARGS, 1,	"[ <sp> maximum-idle-time ]" },
 	{ "CHMOD", CHMOD, NSTR, 1,	"<sp> mode <sp> file-name" },
2. recompile and install ftpd...
3. run ftp(1), connect to server as the non-anonymous user...
4. enter the command like "site md5 xxx"
Comment 1 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 08:00:34 UTC
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped